Review main Merged

85495[BUGFIX] Fulfil Site Set dependencies on EXT:styleguide frontend

Garvin Hicking CR +2 V +2 Easy +6 −0 updated 08/04/24, 07:42

Commit message

This patch ensures that the dependencies which are declared in
the Site Set configuration of EXT:styleguide are also fulfilled
via actual extension dependencies.

Without these extensions being enabled, the Styleguide frontend
cannot resolve its dependencies, and a hard failure will
not apply any TypoScript at all, leading to a
"No TypoScript found" error.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1420

  1. Garvin Hicking uploaded patch set 1 08/02/24, 15:09

  2. Garvin Hicking updated the commit message in patch set 2 08/02/24, 15:11

    Fulfill the fullfiling
  3. Georg Ringer commented on patch set 1 08/02/24, 15:11

    composer.json:27

    can we have it alphabetically ordered?
  4. Markus Klein voted on patch set 2 CR -1 08/02/24, 15:18

  5. core-ci voted on patch set 1 V -1 08/02/24, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62750

  6. Markus Klein voted on patch set 2 CR 0 08/02/24, 15:20

  7. core-ci voted on patch set 2 V -1 08/02/24, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62751

  8. Garvin Hicking abandoned the change 08/02/24, 15:22

    There will be a parallel patch
  9. Garvin Hicking restored the change 08/02/24, 15:32

  10. Markus Timtner uploaded patch set 3 08/02/24, 15:37

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  11. core-ci voted on patch set 3 V -1 08/02/24, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62755

  12. Garvin Hicking uploaded patch set 4 V -1 08/02/24, 20:36

    alphabetic sorting of dep
  13. core-ci voted on patch set 4 V -1 08/02/24, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62771

  14. Garvin Hicking uploaded patch set 5 V -1 08/02/24, 20:56

    Add dependencies to TF deps
  15. core-ci voted on patch set 5 V -1 08/02/24, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62773

  16. core-ci voted on patch set 5 V +1 08/02/24, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62773

  17. Garvin Hicking commented on patch set 5 08/02/24, 21:17

    Verified working in a fresh instance of mine, too

    composer.json:27 Reply

    Done. Also adjusted tests.
  18. Markus Klein voted on patch set 5 CR +1 V +1 08/04/24, 07:33

  19. Benjamin Franzke voted on patch set 5 CR +2 V +2 08/04/24, 07:42

  20. Benjamin Franzke merged patch set 6 08/04/24, 07:42