85495[BUGFIX] Fulfil Site Set dependencies on EXT:styleguide frontend
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Markus Klein +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1420
-
Garvin Hicking uploaded patch set 1 08/02/24, 15:09
-
Garvin Hicking updated the commit message in patch set 2 08/02/24, 15:11
Fulfill the fullfiling -
Georg Ringer commented on patch set 1 08/02/24, 15:11
composer.json:27can we have it alphabetically ordered? -
Markus Klein voted on patch set 2 CR -1 08/02/24, 15:18
-
core-ci voted on patch set 1 V -1 08/02/24, 15:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62750
-
Markus Klein voted on patch set 2 CR 0 08/02/24, 15:20
-
core-ci voted on patch set 2 V -1 08/02/24, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62751
-
Garvin Hicking abandoned the change 08/02/24, 15:22
There will be a parallel patch -
Garvin Hicking restored the change 08/02/24, 15:32
-
Markus Timtner uploaded patch set 3 08/02/24, 15:37
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 3 V -1 08/02/24, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62755
-
Garvin Hicking uploaded patch set 4
V -108/02/24, 20:36alphabetic sorting of dep -
core-ci voted on patch set 4 V -1 08/02/24, 20:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62771
-
Garvin Hicking uploaded patch set 5
V -108/02/24, 20:56Add dependencies to TF deps -
core-ci voted on patch set 5 V -1 08/02/24, 21:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62773
-
core-ci voted on patch set 5 V +1 08/02/24, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62773
-
Garvin Hicking commented on patch set 5 08/02/24, 21:17
Verified working in a fresh instance of mine, toocomposer.json:27ReplyDone. Also adjusted tests. -
Markus Klein voted on patch set 5 CR +1 V +1 08/04/24, 07:33
-
Benjamin Franzke voted on patch set 5 CR +2 V +2 08/04/24, 07:42
-
Benjamin Franzke merged patch set 6 08/04/24, 07:42