Review main Merged

85497[BUGFIX] Include sets in TypoScript setup & conditions cache keys

Benjamin Franzke CR +2 V +2 Easy +7 −1 updated 08/06/24, 09:07

Commit message

The TypoScript setup & conditions cache key is currently hashed with the
list of active sys_template rows. With the introduction of Site Sets
sys_tempate rows are no longer the only possible provider of TypoScript
records. Therefore the list of active sets is now taken into
consideration for the calculation of the cache keys.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 08/02/24, 16:51

  2. Benjamin Franzke uploaded patch set 2 08/02/24, 16:58

  3. core-ci voted on patch set 1 V -1 08/02/24, 17:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62760

  4. core-ci voted on patch set 2 V +1 08/02/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62761

  5. Georg Ringer voted on patch set 2 CR +1 V +1 08/04/24, 07:36

  6. Benni Mack voted on patch set 2 CR +1 V +1 08/06/24, 08:25

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/06/24, 09:07

  8. Christian Kuhn merged patch set 3 08/06/24, 09:07