85498[BUGFIX] Replace hardcoded attributes for <span> tags
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1419
-
Gerrit uploaded patch set 1 08/02/24, 18:54
-
core-ci voted on patch set 1 V +1 08/02/24, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62763
-
Garvin Hicking commented on patch set 1 08/03/24, 22:33
Many thanks for contributing this! This helps a lot. I think we'll need a fallback to the current allowedAttribs list here? Haven't checked deep enough into what $this->procOptions[] contains in a default setup. I'll try to inspect this a bit more (unless someone else knows). -
Benni Mack uploaded patch set 2
V +108/06/24, 12:12 -
core-ci voted on patch set 2 V +1 08/06/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62921
-
Benni Mack voted on patch set 2 CR +1 V +1 08/06/24, 12:31
-
Georg Ringer updated the commit message in patch set 3
CR +1V +108/06/24, 14:16 -
Georg Ringer voted on patch set 3 CR +1 V +1 08/06/24, 14:16
-
core-ci voted on patch set 3 V +1 08/06/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62944
-
Benni Mack voted on patch set 3 CR +1 08/06/24, 15:44
-
Garvin Hicking uploaded patch set 4
CR +1V +108/06/24, 21:07Adjust code comments to match facts -
core-ci voted on patch set 4 V +1 08/06/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62973
-
Garvin Hicking updated the commit message in patch set 5
V +108/06/24, 21:45 -
Garvin Hicking voted on patch set 5 CR +1 V +1 08/06/24, 21:45
-
Benni Mack voted on patch set 5 CR +1 V +1 08/06/24, 21:51
-
core-ci voted on patch set 5 V +1 08/06/24, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62975
-
Benni Mack voted on patch set 5 CR +2 V +2 08/07/24, 12:47
-
Benni Mack merged patch set 6 08/07/24, 12:47
-
Oliver Hader commented on patch set 6 08/15/24, 08:25