Review main Merged

85498[BUGFIX] Replace hardcoded attributes for <span> tags

Bastian Stargazer CR +2 V +2 Easy +18 −7 updated 08/15/24, 08:25

Commit message

This commit fixes the former hard-coded "allowAttribs"
for <span> tags by replacing them with the defined
"allowAttributes" values of the YAML/TSconfig processing
configuration.

In addition, some other fixed lists are moved into class
properties.

Note that to alter the "span" configuration for example
to restrict allowed attributes (or to allow an empty span
tag) you can still use the following YAML/TSconfig:

YAML:
```
processing:
  HTMLparser_db:
    tags:
      span:
        rmTagIfNoAttrib: 0
        allowedAttribs: 'class,data'
```

TSconfig:
```
RTE.default.proc.HTMLparser_db.tags.span {
    rmTagIfNoAttrib = 0
    allowedAttribs = class,data
}
```

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1419

  1. Gerrit uploaded patch set 1 08/02/24, 18:54

  2. core-ci voted on patch set 1 V +1 08/02/24, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62763

  3. Garvin Hicking commented on patch set 1 08/03/24, 22:33

    Many thanks for contributing this! This helps a lot. I think we'll need a fallback to the current allowedAttribs list here? Haven't checked deep enough into what $this->procOptions[] contains in a default setup. I'll try to inspect this a bit more (unless someone else knows).
  4. Benni Mack uploaded patch set 2 V +1 08/06/24, 12:12

  5. core-ci voted on patch set 2 V +1 08/06/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62921

  6. Benni Mack voted on patch set 2 CR +1 V +1 08/06/24, 12:31

  7. Georg Ringer updated the commit message in patch set 3 CR +1 V +1 08/06/24, 14:16

  8. Georg Ringer voted on patch set 3 CR +1 V +1 08/06/24, 14:16

  9. core-ci voted on patch set 3 V +1 08/06/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62944

  10. Benni Mack voted on patch set 3 CR +1 08/06/24, 15:44

  11. Garvin Hicking uploaded patch set 4 CR +1 V +1 08/06/24, 21:07

    Adjust code comments to match facts
  12. core-ci voted on patch set 4 V +1 08/06/24, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62973

  13. Garvin Hicking updated the commit message in patch set 5 V +1 08/06/24, 21:45

  14. Garvin Hicking voted on patch set 5 CR +1 V +1 08/06/24, 21:45

  15. Benni Mack voted on patch set 5 CR +1 V +1 08/06/24, 21:51

  16. core-ci voted on patch set 5 V +1 08/06/24, 21:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62975

  17. Benni Mack voted on patch set 5 CR +2 V +2 08/07/24, 12:47

  18. Benni Mack merged patch set 6 08/07/24, 12:47

  19. Oliver Hader commented on patch set 6 08/15/24, 08:25