Review main Abandoned

85500[WIP][TASK] Revamp display of "Form editor" view of EXT:form

Jasmina Ließmann CR 0 V 0 Expert +696 −1363 updated 10/10/24, 19:35

Commit message

EXT:form allows to create and maintain forms in the backend. When
editing a form, the "Form editor" view is called up, which is divided
into three parts - form tree, stage area and inspector area.

This patch revises and modernizes the entire view to bring it into line
with the look and feel of the rest of the backend. This includes among
other things the following changes:

Form tree:
The form tree now largely uses the markup of the page tree. This
ensures a uniform appearance and a familiar user experience. The
readability of the individual tree elements is thereby increased.

Stage area:
The stage area has been widened. Animations and visual mouse-over
effects have been removed from both the form fields and when switching
between the "Preview" and "Abstract" view.

The form field identifiers are now displayed - as in the rest of the
backend - when hovering over the respective form field icon.

Inspector area:
The width of the inspector area has also been slightly expanded. The
markup of the individual fields in this area has been updated so that
it also matches the look of the rest of the backend.

The elements in the doc header have also been repositioned. In the
process, the "Settings" button, which is synonymous with the active
selection of the form record/name in the form tree, has been removed.

As part of the patch, the responsive display of the "Form editor" view
has also been optimized. For example, the form tree is now hidden on
smaller output devices and the inspector area is placed below the stage
area.

---

ToDo:
- form tree: nesting of grid rows is not correct in deeper tree levels
- stage area: if element has errors and is selected .t3-form-validation-errors must not be removed

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 42

Show 22 more files

Review log 3262

Show 1837 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 08/02/24, 20:52

  2. core-ci voted on patch set 1 V -1 08/02/24, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62772

  3. Jasmina Ließmann uploaded patch set 2 V -1 08/05/24, 22:31

  4. core-ci voted on patch set 2 V +1 08/05/24, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62862

  5. Jasmina Ließmann uploaded patch set 3 V +1 08/06/24, 10:05

  6. core-ci voted on patch set 3 V +1 08/06/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62893

  7. Jasmina Ließmann uploaded patch set 4 V +1 08/15/24, 13:16

  8. core-ci voted on patch set 4 V +1 08/15/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63490

  9. Jasmina Ließmann uploaded patch set 5 V +1 08/15/24, 13:35

  10. core-ci voted on patch set 5 V +1 08/15/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63493

  11. Jasmina Ließmann uploaded patch set 6 V +1 08/19/24, 20:08

  12. core-ci voted on patch set 6 V +1 08/19/24, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63785

  13. Jasmina Ließmann uploaded patch set 7 V +1 08/19/24, 22:46

  14. core-ci voted on patch set 7 V +1 08/19/24, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63787

  15. Jasmina Ließmann uploaded patch set 8 V +1 08/21/24, 11:11

  16. core-ci voted on patch set 8 V +1 08/21/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63898

  17. Jasmina Ließmann uploaded patch set 9 V +1 08/21/24, 12:26

  18. core-ci voted on patch set 9 V +1 08/21/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63906

  19. Jasmina Ließmann uploaded patch set 10 V +1 08/21/24, 14:31

  20. core-ci voted on patch set 10 V +1 08/21/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63917

  21. Jasmina Ließmann uploaded patch set 11 V +1 08/31/24, 09:18

  22. core-ci voted on patch set 11 V +1 08/31/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64579

  23. Jasmina Ließmann uploaded patch set 12 V +1 08/31/24, 10:22

  24. core-ci voted on patch set 12 V -1 08/31/24, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64582

  25. Jasmina Ließmann uploaded patch set 13 V -1 09/09/24, 18:17

  26. core-ci voted on patch set 13 V +1 09/09/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65130

  27. Jasmina Ließmann uploaded patch set 14 V +1 09/09/24, 18:43

  28. core-ci voted on patch set 14 V +1 09/09/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65132

  29. Jasmina Ließmann uploaded patch set 15 V +1 09/10/24, 17:42

  30. core-ci voted on patch set 15 V +1 09/10/24, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65302

  31. Jasmina Ließmann uploaded patch set 16 V +1 09/11/24, 20:27

  32. core-ci voted on patch set 16 V +1 09/11/24, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65493

  33. Jasmina Ließmann uploaded patch set 17 V +1 09/11/24, 21:48

  34. core-ci voted on patch set 17 V -1 09/11/24, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65502

  35. core-ci commented on patch set 17 09/11/24, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65502

  36. Jasmina Ließmann uploaded patch set 18 V -1 09/11/24, 22:37

  37. core-ci voted on patch set 18 V +1 09/11/24, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65506

  1. Jasmina Ließmann uploaded patch set 19 V +1 09/13/24, 15:43

  2. core-ci voted on patch set 19 V +1 09/13/24, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65696

  3. Jasmina Ließmann uploaded patch set 20 V +1 09/13/24, 20:45

  4. core-ci voted on patch set 20 V +1 09/13/24, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65707

  5. Jasmina Ließmann uploaded patch set 21 V +1 09/17/24, 15:02

  6. core-ci voted on patch set 21 V +1 09/17/24, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66047

  7. Jasmina Ließmann uploaded patch set 22 V +1 09/17/24, 21:24

  8. core-ci voted on patch set 22 V +1 09/17/24, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66081

  9. Jasmina Ließmann updated the commit message in patch set 23 V +1 09/17/24, 22:25

  10. core-ci voted on patch set 23 V +1 09/17/24, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66084

  11. Jasmina Ließmann updated the commit message in patch set 24 V +1 09/17/24, 22:43

  12. core-ci voted on patch set 24 V +1 09/17/24, 23:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66085

  13. Jasmina Ließmann uploaded patch set 25 V +1 09/19/24, 11:39

  14. core-ci voted on patch set 25 V +1 09/19/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66205

  15. Andreas Kienast uploaded patch set 26 V +1 09/20/24, 10:50

  16. core-ci voted on patch set 26 V +1 09/20/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66313

  17. Jasmina Ließmann updated the commit message in patch set 27 V +1 09/25/24, 10:07

  18. core-ci voted on patch set 27 V +1 09/25/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66569

  19. Jasmina Ließmann uploaded patch set 28 V +1 09/25/24, 18:19

  20. core-ci voted on patch set 28 V +1 09/25/24, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66617

  21. Jasmina Ließmann uploaded patch set 29 V +1 09/26/24, 14:35

  22. core-ci voted on patch set 29 V +1 09/26/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66676

  23. Jasmina Ließmann abandoned the change 10/10/24, 16:00

    This patch never received any feedback and was ousted by https://review.typo3.org/c/Packages/TYPO3.CMS/+/86404. RIP little patch.
  24. Benjamin Franzke commented on patch set 29 10/10/24, 18:57

    > This patch never received any feedback and was ousted by https://review.typo3.org/c/Packages/TYPO3.CMS/+/86404. RIP little patch. Hey Jasmina, we talked with you about this patch during our team meeting and the alternative approach we'd like to go as this patch is not ready, and we couldn't make it so. Let me summarize some technical details why: * You couldn't finalize it – we neither, because we didn't know what was broken and why. We can not takeover from a broken state * Harmonizing the trees was a great idea, but can must not reuse the tree-component internal markup in a tree implementation that is not based on the tree component. That "locks" us into not being able to change the tree web component without site effects. (It make it appear as API which is not) * We needed context awareness because we exposed light/dark recently. I really hope it's fine that the good ideas of this patch could be realized – only with a slightly different approach. I don't think that needs to be seen as "RIP", but rather as: Thanks litte patch!
  25. Jasmina Ließmann commented on patch set 29 10/10/24, 19:35

    Reply

    Hello Benjamin, I remember the outcome of the team meeting a little differently. It was said that the patch was too big to review in the current time up to the release date. The only feedback I received was the verbal statements in the meeting. Not in the weeks before, when I had contacted developers. In the team meeting, there was uncertainty as to whether the form API would be affected by changes in this patch. It was said that due to the code base of EXT:form, it would first have to be clarified to what extent the module could be revised. Therefore, a patch should be started that only brings context awareness into the form editor. A revision of the appearance exclusively using CSS was briefly brought into play, but not that this should be done before release. It would have been no problem to reinstall the previous tree in this patch, or to roll back individual adjustments. But this was never requested in the team meeting, in Slack, or here in Gerrit. Instead, a new patch was created that neither contains changes exclusively to context awareness nor purely CSS-based changes. The new patch simply reworked the entire look, making this patch and all the work that went into it completely obsolete.