85500[WIP][TASK] Revamp display of "Form editor" view of EXT:form
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 42
- Build/Sources/Sass/form.scss+180 −616
- Build/Sources/TypeScript/form/backend/form-editor/helper.ts+1 −1
- Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts+3 −11
- Build/Sources/TypeScript/form/backend/form-editor/mediator.ts+7 −20
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts+8 −17
- Build/Sources/TypeScript/form/backend/form-editor/tree-component.ts+77 −78
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+25 −156
- typo3/sysext/form/Classes/Controller/FormEditorController.php+4 −21
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html+8 −10
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CollectionElementHeaderEditor.html+2 −2
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CountrySelectEditor.html+8 −8
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FinishersEditor.html+7 −6
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/FormElementHeaderEditor.html+4 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/GridColumnViewPortConfigurationEditor.html+7 −5
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MaximumFileSizeEditor.html+3 −4
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/MultiSelectEditor.html+8 −8
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/PropertyGridEditor.html+31 −23
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RemoveElementEditor.html+11 −3
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RequiredValidatorEditor.html+7 −7
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/SingleSelectEditor.html+8 −8
Show 22 more files
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextareaEditor.html+9 −9
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/TextEditor.html+20 −20
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/Typo3WinBrowserEditor.html+23 −9
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidationErrorMessageEditor.html+9 −9
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidatorsEditor.html+7 −6
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/ContentElement.html+5 −15
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/Fieldset.html+5 −10
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/FileUploadTemplate.html+5 −15
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/SelectTemplate.html+5 −15
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/SimpleTemplate.html+11 −21
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/StaticText.html+5 −15
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Stage/_ElementToolbar.html+30 −14
- typo3/sysext/form/Resources/Private/Frontend/Partials/Form/Navigation.html+20 −3
- typo3/sysext/form/Resources/Private/Language/Database.xlf+7 −4
- typo3/sysext/form/Resources/Private/Templates/Backend/FormEditor/Index.html+38 −43
- typo3/sysext/form/Resources/Public/Css/form.css+82 −141
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/helper.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/mediator.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/tree-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
Review log 3262
Show 1837 earlier messages
-
Jasmina Ließmann uploaded patch set 1 08/02/24, 20:52
-
core-ci voted on patch set 1 V -1 08/02/24, 20:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62772
-
Jasmina Ließmann uploaded patch set 2
V -108/05/24, 22:31 -
core-ci voted on patch set 2 V +1 08/05/24, 22:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62862
-
Jasmina Ließmann uploaded patch set 3
V +108/06/24, 10:05 -
core-ci voted on patch set 3 V +1 08/06/24, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62893
-
Jasmina Ließmann uploaded patch set 4
V +108/15/24, 13:16 -
core-ci voted on patch set 4 V +1 08/15/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63490
-
Jasmina Ließmann uploaded patch set 5
V +108/15/24, 13:35 -
core-ci voted on patch set 5 V +1 08/15/24, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63493
-
Jasmina Ließmann uploaded patch set 6
V +108/19/24, 20:08 -
core-ci voted on patch set 6 V +1 08/19/24, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63785
-
Jasmina Ließmann uploaded patch set 7
V +108/19/24, 22:46 -
core-ci voted on patch set 7 V +1 08/19/24, 22:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63787
-
Jasmina Ließmann uploaded patch set 8
V +108/21/24, 11:11 -
core-ci voted on patch set 8 V +1 08/21/24, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63898
-
Jasmina Ließmann uploaded patch set 9
V +108/21/24, 12:26 -
core-ci voted on patch set 9 V +1 08/21/24, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63906
-
Jasmina Ließmann uploaded patch set 10
V +108/21/24, 14:31 -
core-ci voted on patch set 10 V +1 08/21/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63917
-
Jasmina Ließmann uploaded patch set 11
V +108/31/24, 09:18 -
core-ci voted on patch set 11 V +1 08/31/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64579
-
Jasmina Ließmann uploaded patch set 12
V +108/31/24, 10:22 -
core-ci voted on patch set 12 V -1 08/31/24, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64582
-
Jasmina Ließmann uploaded patch set 13
V -109/09/24, 18:17 -
core-ci voted on patch set 13 V +1 09/09/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65130
-
Jasmina Ließmann uploaded patch set 14
V +109/09/24, 18:43 -
core-ci voted on patch set 14 V +1 09/09/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65132
-
Jasmina Ließmann uploaded patch set 15
V +109/10/24, 17:42 -
core-ci voted on patch set 15 V +1 09/10/24, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65302
-
Jasmina Ließmann uploaded patch set 16
V +109/11/24, 20:27 -
core-ci voted on patch set 16 V +1 09/11/24, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65493
-
Jasmina Ließmann uploaded patch set 17
V +109/11/24, 21:48 -
core-ci voted on patch set 17 V -1 09/11/24, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65502
-
core-ci commented on patch set 17 09/11/24, 21:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65502
-
Jasmina Ließmann uploaded patch set 18
V -109/11/24, 22:37 -
core-ci voted on patch set 18 V +1 09/11/24, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65506
-
Jasmina Ließmann uploaded patch set 19
V +109/13/24, 15:43 -
core-ci voted on patch set 19 V +1 09/13/24, 15:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65696
-
Jasmina Ließmann uploaded patch set 20
V +109/13/24, 20:45 -
core-ci voted on patch set 20 V +1 09/13/24, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65707
-
Jasmina Ließmann uploaded patch set 21
V +109/17/24, 15:02 -
core-ci voted on patch set 21 V +1 09/17/24, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66047
-
Jasmina Ließmann uploaded patch set 22
V +109/17/24, 21:24 -
core-ci voted on patch set 22 V +1 09/17/24, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66081
-
Jasmina Ließmann updated the commit message in patch set 23
V +109/17/24, 22:25 -
core-ci voted on patch set 23 V +1 09/17/24, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66084
-
Jasmina Ließmann updated the commit message in patch set 24
V +109/17/24, 22:43 -
core-ci voted on patch set 24 V +1 09/17/24, 23:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66085
-
Jasmina Ließmann uploaded patch set 25
V +109/19/24, 11:39 -
core-ci voted on patch set 25 V +1 09/19/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66205
-
Andreas Kienast uploaded patch set 26
V +109/20/24, 10:50 -
core-ci voted on patch set 26 V +1 09/20/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66313
-
Jasmina Ließmann updated the commit message in patch set 27
V +109/25/24, 10:07 -
core-ci voted on patch set 27 V +1 09/25/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66569
-
Jasmina Ließmann uploaded patch set 28
V +109/25/24, 18:19 -
core-ci voted on patch set 28 V +1 09/25/24, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66617
-
Jasmina Ließmann uploaded patch set 29
V +109/26/24, 14:35 -
core-ci voted on patch set 29 V +1 09/26/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66676
-
Jasmina Ließmann abandoned the change 10/10/24, 16:00
This patch never received any feedback and was ousted by https://review.typo3.org/c/Packages/TYPO3.CMS/+/86404. RIP little patch. -
Benjamin Franzke commented on patch set 29 10/10/24, 18:57
> This patch never received any feedback and was ousted by https://review.typo3.org/c/Packages/TYPO3.CMS/+/86404. RIP little patch. Hey Jasmina, we talked with you about this patch during our team meeting and the alternative approach we'd like to go as this patch is not ready, and we couldn't make it so. Let me summarize some technical details why: * You couldn't finalize it – we neither, because we didn't know what was broken and why. We can not takeover from a broken state * Harmonizing the trees was a great idea, but can must not reuse the tree-component internal markup in a tree implementation that is not based on the tree component. That "locks" us into not being able to change the tree web component without site effects. (It make it appear as API which is not) * We needed context awareness because we exposed light/dark recently. I really hope it's fine that the good ideas of this patch could be realized – only with a slightly different approach. I don't think that needs to be seen as "RIP", but rather as: Thanks litte patch! -
Jasmina Ließmann commented on patch set 29 10/10/24, 19:35
Reply
Hello Benjamin, I remember the outcome of the team meeting a little differently. It was said that the patch was too big to review in the current time up to the release date. The only feedback I received was the verbal statements in the meeting. Not in the weeks before, when I had contacted developers. In the team meeting, there was uncertainty as to whether the form API would be affected by changes in this patch. It was said that due to the code base of EXT:form, it would first have to be clarified to what extent the module could be revised. Therefore, a patch should be started that only brings context awareness into the form editor. A revision of the appearance exclusively using CSS was briefly brought into play, but not that this should be done before release. It would have been no problem to reinstall the previous tree in this patch, or to roll back individual adjustments. But this was never requested in the team meeting, in Slack, or here in Gerrit. Instead, a new patch was created that neither contains changes exclusively to context awareness nor purely CSS-based changes. The new patch simply reworked the entire look, making this patch and all the work that went into it completely obsolete.