85501[BUGFIX] Wrap requiring calls in methods to avoid errors
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1114
-
Georg Ringer uploaded patch set 1 08/03/24, 07:25
-
Georg Ringer commented on patch set 1 08/03/24, 07:25
This change is ready for review. -
core-ci voted on patch set 1 V +1 08/03/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62787
-
Oli Bartsch updated the commit message in patch set 2
V +108/03/24, 09:27 -
core-ci voted on patch set 2 V +1 08/03/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62793
-
Benni Mack voted on patch set 2 CR +1 08/05/24, 10:15
-
Jannis Bell commented on patch set 2 08/05/24, 13:09
https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/4647#issuecomment-2261604880 I found more places, that could need this wrapping -
Christian Kuhn commented on patch set 2 CR -1 08/06/24, 08:03
Reply
I think other places not related to AbstractServiceProvider should be separate patches. For AbstractServiceProvider: TYPO3\CMS\Dashboard\ServiceProvider has a couple of places that should use this helper method as well, and this should be included in the patch. -
Georg Ringer uploaded patch set 3
CR +1V +108/06/24, 18:24 -
core-ci voted on patch set 3 V +1 08/06/24, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62966
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 08/07/24, 17:31
-
Stefan Bürk commented on patch set 3 CR +1 V +1 08/07/24, 17:31
Reply
Done -
Anja Leichsenring voted on patch set 3 CR +2 V +2 08/07/24, 17:31
-
Anja Leichsenring merged patch set 4 08/07/24, 17:31