Review main Merged

85501[BUGFIX] Wrap requiring calls in methods to avoid errors

Georg Ringer CR +2 V +2 Easy +17 −9 updated 08/07/24, 17:31

Commit message

Moves require statements into a custom method to avoid
clashes with local variables.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Georg Ringer uploaded patch set 1 08/03/24, 07:25

  2. Georg Ringer commented on patch set 1 08/03/24, 07:25

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 08/03/24, 07:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62787

  4. Oli Bartsch updated the commit message in patch set 2 V +1 08/03/24, 09:27

  5. core-ci voted on patch set 2 V +1 08/03/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62793

  6. Benni Mack voted on patch set 2 CR +1 08/05/24, 10:15

  7. Jannis Bell commented on patch set 2 08/05/24, 13:09

  8. Christian Kuhn commented on patch set 2 CR -1 08/06/24, 08:03

    Reply

    I think other places not related to AbstractServiceProvider should be separate patches. For AbstractServiceProvider: TYPO3\CMS\Dashboard\ServiceProvider has a couple of places that should use this helper method as well, and this should be included in the patch.
  9. Georg Ringer uploaded patch set 3 CR +1 V +1 08/06/24, 18:24

  10. core-ci voted on patch set 3 V +1 08/06/24, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62966

  11. Anja Leichsenring voted on patch set 3 CR +1 V +1 08/07/24, 17:31

  12. Stefan Bürk commented on patch set 3 CR +1 V +1 08/07/24, 17:31

    Reply

    Done
  13. Anja Leichsenring voted on patch set 3 CR +2 V +2 08/07/24, 17:31

  14. Anja Leichsenring merged patch set 4 08/07/24, 17:31