Review main Merged

85502[TASK] Use QueryBuilder `UNION` API in CTE API

Stefan Bürk CR +2 V +2 Easy +6 −6 updated 08/16/24, 18:50

Commit message

Replace `sprintf()` union building for the
recursive Common Table Expression part with
`UNION clause` QueryBuilder API to resolve
`@todo` in the TYPO3 implementation.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1324

  1. Stefan Bürk uploaded patch set 1 08/03/24, 09:47

  2. core-ci voted on patch set 1 V +1 08/03/24, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62795

  3. core-ci commented on patch set 1 08/03/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62797

  4. Stefan Bürk rebased onto patch set 2 V +1 08/14/24, 17:49

  5. core-ci voted on patch set 2 V -1 08/14/24, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63403

  6. Stefan Bürk rebased onto patch set 3 V -1 08/14/24, 23:13

  7. Stefan Bürk updated the commit message in patch set 4 08/14/24, 23:18

  8. core-ci voted on patch set 3 V -1 08/14/24, 23:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63426

  9. core-ci voted on patch set 4 V -1 08/14/24, 23:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63427

  10. Stefan Bürk updated the commit message in patch set 5 V -1 08/15/24, 00:29

  11. core-ci voted on patch set 5 V +1 08/15/24, 00:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63430

  12. Stefan Bürk uploaded patch set 6 V +1 08/15/24, 14:51

  13. Stefan Bürk updated the commit message in patch set 7 08/15/24, 14:52

  14. core-ci voted on patch set 6 V +1 08/15/24, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63507

  15. core-ci voted on patch set 7 V +1 08/15/24, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63508

  16. Stefan Bürk rebased onto patch set 8 V +1 08/15/24, 15:07

  17. core-ci voted on patch set 8 V +1 08/15/24, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63512

  18. Stefan Bürk rebased onto patch set 9 V +1 08/16/24, 13:43

  19. Stefan Bürk updated the commit message in patch set 10 08/16/24, 13:43

  20. core-ci voted on patch set 9 V +1 08/16/24, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63581

  21. core-ci voted on patch set 10 V +1 08/16/24, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63582

  22. Christian Kuhn voted on patch set 10 CR +1 V +1 08/16/24, 18:30

  23. Anja Leichsenring voted on patch set 10 CR +2 V +2 08/16/24, 18:50

  24. Anja Leichsenring merged patch set 11 08/16/24, 18:50