85503[TASK] Use TcaSchema in EXT:styleguide
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombination.php+5 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeInlineUsecombinationGroup.php+5 −2
- typo3/sysext/styleguide/Classes/TcaDataGenerator/TableHandler/General.php+8 −4
- typo3/sysext/styleguide/Classes/TcaDataGenerator/Generator.php+3 −1
- typo3/sysext/styleguide/Classes/TcaDataGenerator/RecordData.php+5 −3
Review log 712
-
Oli Bartsch uploaded patch set 1 08/03/24, 10:09
-
core-ci voted on patch set 1 V -1 08/03/24, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62798
-
Oli Bartsch uploaded patch set 2
V -108/03/24, 11:28 -
core-ci voted on patch set 2 V -1 08/03/24, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62801
-
Oli Bartsch uploaded patch set 3
V -108/05/24, 08:02 -
core-ci voted on patch set 3 V -1 08/05/24, 08:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62849
-
Oli Bartsch uploaded patch set 4
V -108/05/24, 08:22 -
core-ci voted on patch set 4 V -1 08/05/24, 08:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62850
-
Oli Bartsch uploaded patch set 5
V -101/09/25, 11:12 -
core-ci voted on patch set 5 V -1 01/09/25, 11:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72133
-
Christian Kuhn commented on patch set 5 01/09/25, 17:38
this does not work in ac tests since ac tests don't call core bootstrap far enough to create tcaSchema. this can not be solved easily. i suggest to abandon/reject this change for now: whith the transition to playwright, the instance can use the cli command to create styleguide data structure, and after that, this change may be possible. imho, it is not worth looking at this change in more detail at the moment, before a codeceptions->playwright transition finished. -
Christian Kuhn abandoned the change 01/09/25, 17:38