85505[BUGFIX] Fixed execution of scheduler tasks directly after stopping them
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Marno Schmigotzki uploaded patch set 1 08/03/24, 15:15
-
core-ci voted on patch set 1 V +1 08/03/24, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62804
-
Georg Ringer commented on patch set 1 08/04/24, 07:06
what about using a different approach ``` if (!empty($queryParams['action']['stop'])) { $this->stopTask($view, (int)$queryParams['action']['stop']); return new RedirectResponse($this->uriBuilder->buildUriFromRoute('scheduler')); } ``` so after stopping just redirect to default action? -
Marno Schmigotzki commented on patch set 1 08/06/24, 07:55
Reply
This would also work, but I have adapted the implementation of the stop button in the template to the other actions (e.g. delete) in order to solve the problem at the origin and to align the code. The redirect would therefore only fix the effect. Or do you see an advantage in retaining the implementation via query parameters? -
Christian Kuhn commented on patch set 1 08/06/24, 08:05
Reply
solution is fine: post request is the way to go here. -
Christian Kuhn voted on patch set 1 CR +1 V +1 08/06/24, 08:17
-
Georg Ringer voted on patch set 1 CR +1 V +1 08/06/24, 09:06
-
Christian Kuhn voted on patch set 1 CR +2 V +2 08/06/24, 09:28
-
Christian Kuhn merged patch set 2 08/06/24, 09:28