Review main Merged

85506[BUGFIX] Fix multiple file upload handling in UploadViewHelper

Torben Hansen CR +2 V +2 Easy +8 −2 updated 08/06/24, 07:37

Commit message

When using the `f:form.upload` ViewHelper to upload files for a
property of a DTO or domain model, it is not possible to upload
multiple files using the ViewHelpers `multiple` attribute, because
the field name for form token generation is wrong. Uploading
multiple files result in a extbase property mapping exception.

The patch ensures that if the ViewHelper is configured to handle
multiple files for upload, the field name for
`registerFieldNameForFormTokenGeneration` is calculated correctly
to allow multiple files in extbase property mapping.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Torben Hansen uploaded patch set 1 08/04/24, 07:37

  2. core-ci voted on patch set 1 V +1 08/04/24, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62821

  3. Torben Hansen updated the commit message in patch set 2 V +1 08/05/24, 17:31

  4. core-ci voted on patch set 2 V +1 08/05/24, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62856

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 08/06/24, 07:21

  6. Benni Mack voted on patch set 2 CR +2 V +2 08/06/24, 07:37

  7. Benni Mack merged patch set 3 08/06/24, 07:37