85508[FEATURE] Add backend usergroup restriction to sys_note records
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/13.3/Feature-43501-GroupRestrictionsForSys_noteRecords.rstnew+29 −0
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php3+24 −10
- typo3/sysext/sys_note/Classes/Renderer/NoteRenderer.php+1 −1
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php6+15 −1
Review log 1315
-
Georg Ringer uploaded patch set 1 08/04/24, 10:59
-
Georg Ringer commented on patch set 1 08/04/24, 11:00
This change is ready for review. -
core-ci voted on patch set 1 V +1 08/04/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62825
-
Chris Müller commented on patch set 1 08/04/24, 15:11
SysNoteRepository.php:43UnresolvedThe method name does now not match anymore, better: findByPidAndUser or similar.SysNoteRepository.php:59In which case is the empty groups string constraint necessary? -
Georg Ringer commented on patch set 1 08/05/24, 07:40
SysNoteRepository.php:59Reply UnresolvedTBH I don't yet know but better check before having some edgecases, right -
Christian Kuhn commented on patch set 1 CR -1 08/05/24, 09:22
sys_note.php:88the issue with this field is that non-admin users now "see" all existing BE groups, which is an information usually available to admins only. this *might* be perceived as an information disclosure issue, but i'm not entirely sure about this. i think members of the security team should have a 'go' or 'no-go' vote on this patch before merge. i hope it's ok to -1 for now until this has been decided on. -
Georg Ringer commented on patch set 1 08/05/24, 09:31
sys_note.php:88Replywhat about making the field admin only with displaycond? -
Georg Ringer uploaded patch set 2
CR -1V +108/05/24, 19:21 -
core-ci voted on patch set 2 V +1 08/05/24, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62858
-
Christian Kuhn commented on patch set 2 08/06/24, 07:10
sys_note.php:88Replythat would certainly 'fix' the security impact, but will reduce the usefulness. could be a first solution, though. -
Georg Ringer commented on patch set 2 08/06/24, 18:20
sys_note.php:88ReplyI use the feature most of time to give editors hint and for that this would be a nice help -
Frank Nägler commented on patch set 2 09/10/24, 13:35
sys_note.php:88ReplyAfter an exchange with Oliver Hader, we see several aspects here: 1) Admin Only limits the feature. I (Frank) think this is not so good 2) Showing all BE user groups is generally not a security issue if it is on purpose. If you name groups unwisely, it is your fault 3) This is where it gets critical: BE users / BE groups are on PID 0 and are, therefore, visible to everyone (admin), even in multi-site setups. We can not assign groups or users to parts of a tree or a site. This could expose names such as "Company A Editors" and "Company B Editors," which could make information visible that you want to protect; this is not a security issue per se, but a problem for integrators/operators who do not wish to or are not allowed to expose such multi-site setups. 4) Real-World Issue: BE Groups Definitions: I have seen systems with hundreds of BE Groups, which is maybe not a good idea, but such systems exist. What you want for the feature is a selection of meta groups like "News Editor", "Proofreader", "Boss" etc. Consequence: If you cannot restrict the groups to page trees or make the groups configurable, this field should remain "admin only". So, idea from my side: What about allowing to define the allowed BE Usergroups for this field? If the integrator can define which BE Usergroups appear in the field, we can drop the admin only and enable that feature for every backend user. -
Georg Ringer commented on patch set 2 09/10/24, 18:26
sys_note.php:88Reply Unresolvedwe once had such checkbox in be_groups several versions ago - but TBH I don't want extend be_groups by sys_note ext. I see the drawback of 1) but IMHO this displaycond allows to ship this feature without too many issues of 2/3 and a big improvement for a lot of installations -
Benni Mack marked it work in progress 04/08/25, 19:28
-
Benni Mack abandoned the change 11/13/26, 10:43
won't do this