Review 12.4 Merged

85511[BUGFIX] Mitigate change detection loop for enum and set fields

Stefan Bürk CR +2 V +2 Easy +9 −1 updated 08/06/24, 07:51

Commit message

Doctrine DBAL retrieves for MariaDB `ENUM()` and `SET()`
field default values quotes with single quotes, which
leads to an endless field change reporting recursion in
the database analyzer. The default value is now trimmed
to ensure a working field compare within the extending
`TYPO3\CMS\Core\Database\Schema\Comparator` class.

Note that TYPO3 v13 (main) may reveal the same issue but
is shadowed due to the general `ENUM()` and `SET()` type
field issue since Doctrine DBAL 4, reported in #104413.
That needs a change on its own for main only.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Markus Klein +1
    • Christian Kuhn +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 08/05/24, 20:37

  2. core-ci voted on patch set 1 V +1 08/05/24, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62860

  3. Stefan Bürk updated the commit message in patch set 2 V +1 08/05/24, 20:50

  4. core-ci voted on patch set 2 V +1 08/05/24, 20:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62861

  5. Markus Klein voted on patch set 2 CR +1 V +1 08/05/24, 20:59

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 08/06/24, 05:06

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 08/06/24, 07:07

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 08/06/24, 07:13

  9. Stefan Bürk merged patch set 3 08/06/24, 07:51