Review 12.4 Merged

85516[TASK] Consider soft delete in file reference delete method

Christian Kuhn CR +2 V +2 Normal +86 −28 updated 08/06/24, 09:13

Commit message

With #102770 the `delete()` method for a FileReference object has
been implemented. This was however performed using a hard delete
of the file reference record in the database, which is not
appropriate, since the delete functionality must take into account,
if the table is configured for soft or hard deletes.

This patch changes the implementation, so the file reference is
either hard or soft deleted depending on the TCA configuration.
If the delete operation was successful, the reference index
for affected records is now updated. Additionally, functional
tests are extended to ensure, that the file used in the file
reference remains when the file reference is deleted and that
the reference index is updated accordingly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 46

  1. Christian Kuhn uploaded patch set 1 08/06/24, 08:56

  2. core-ci voted on patch set 1 V -1 08/06/24, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62884

  3. Christian Kuhn uploaded patch set 2 V -1 08/06/24, 09:04

  4. core-ci voted on patch set 2 V +1 08/06/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62885

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 08/06/24, 09:13

  6. Christian Kuhn merged patch set 3 08/06/24, 09:13