Review 12.4 Merged

85518[BUGFIX] Avoid exceptions due to non-HTTP URI values in CSP reporter

Christian Kuhn CR +2 V +2 Easy +37 −2 updated 08/06/24, 10:12

Commit message

CSP violation reports might contain non-HTTP referrer URIs, like
`android-app://com.google.android.googlequicksearchbox/`, which
results in an exception, since the `android-app:` scheme is not
supported by the model in `\TYPO3\CMS\Core\Http\Uri`.

This change introduces the `Uri::fromAnyScheme()` factory method,
which instructs the parsing logic to skip the scheme validation.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Christian Kuhn uploaded patch set 1 08/06/24, 10:05

  2. core-ci voted on patch set 1 V +1 08/06/24, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62892

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 08/06/24, 10:12

  4. Christian Kuhn merged patch set 2 08/06/24, 10:12