Review main Abandoned

85525[WIP][FEATURE] Introduce SensitiveParameterValue for TYPO3_CONF_VARS

Oliver Hader CR 0 V 0 Normal +227 −1 updated 08/06/24, 21:11

Commit message

@todo
+ extract configuration layer into separate patch
+ add test cases
+ add documentation

* PHP 8.2 feature SensitiveParameterValue denies accidenally
  disclosing credentials in stack traces or variable dumps
* \TYPO3\CMS\Core\Security\SecretString wraps SensitiveParameterValue
  to be usable as string as well for backward compatibility
* \TYPO3\CMS\Core\Configuration\ConfigurationDescriber is an
  object-oriented accessor for DefaultConfigurationDescription.yaml
* \TYPO3\CMS\Core\Configuration\ConfigurationProcessor is used
  to enforece types in the TYPO3_CONF_VARS configuration array
* \TYPO3\CMS\Core\Configuration\ConfigurationManager enforces
  the new SecretString type by invoking ConfigurationProcessor

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 57

  1. Oliver Hader uploaded patch set 1 08/06/24, 11:18

  2. Oliver Hader uploaded patch set 2 08/06/24, 11:22

  3. core-ci voted on patch set 1 V -1 08/06/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62905

  4. core-ci voted on patch set 2 V -1 08/06/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62909

  5. Oliver Hader marked it work in progress 08/06/24, 19:38

  6. Oliver Hader commented on patch set 2 08/06/24, 20:27

    Probably does not work with primitive types... besides that, PHP does not seem to apply the `SensitiveParameter` behavior to any internal flow-graph. Thus, passing a sensitive value to a method still would not mark it as "sensitive"...
  7. Oliver Hader abandoned the change 08/06/24, 21:11

    Does not work...