85525[WIP][FEATURE] Introduce SensitiveParameterValue for TYPO3_CONF_VARS
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 6
- typo3/sysext/core/Classes/Configuration/ConfigurationDescriber.phpnew+82 −0
- typo3/sysext/core/Classes/Configuration/ConfigurationManager.php+3 −0
- typo3/sysext/core/Classes/Configuration/ConfigurationProcessor.phpnew+80 −0
- typo3/sysext/core/Classes/Security/JwtTrait.php+1 −1
- typo3/sysext/core/Classes/Security/SecretString.phpnew+53 −0
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+8 −0
Review log 57
-
Oliver Hader uploaded patch set 1 08/06/24, 11:18
-
Oliver Hader uploaded patch set 2 08/06/24, 11:22
-
core-ci voted on patch set 1 V -1 08/06/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62905
-
core-ci voted on patch set 2 V -1 08/06/24, 11:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62909
-
Oliver Hader marked it work in progress 08/06/24, 19:38
-
Oliver Hader commented on patch set 2 08/06/24, 20:27
Probably does not work with primitive types... besides that, PHP does not seem to apply the `SensitiveParameter` behavior to any internal flow-graph. Thus, passing a sensitive value to a method still would not mark it as "sensitive"... -
Oliver Hader abandoned the change 08/06/24, 21:11
Does not work...