Review main Merged

85535[BUGFIX] Render empty icon instead of invalid identifier

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 08/06/24, 15:13

Commit message

This additionally resolves a display bug, since the
elements without an icon were moving to the left
and are now properly in line with the elements,
having an icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Oli Bartsch uploaded patch set 1 08/06/24, 14:41

  2. core-ci voted on patch set 1 V +1 08/06/24, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62948

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 08/06/24, 14:59

  4. Georg Ringer voted on patch set 1 CR +2 V +2 08/06/24, 15:13

  5. Georg Ringer merged patch set 2 08/06/24, 15:13