85543[TASK] Improve detail and comparison views of "Backend Users" BE module
Commit message
Review
-
Code review CR +2 Done
- Jasmina Ließmann +2
- Guido Schmechel +1
- Stefan Bürk +1
-
Verified V +2 Done
- Jasmina Ließmann +2
- Guido Schmechel +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 13
- Build/Sources/Sass/component/_panel.scss+11 −0
- Build/Sources/Sass/module/_beuser.scssnew+32 −0
- Build/Sources/Sass/backend.scss+1 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+12 −0
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+9 −2
- typo3/sysext/beuser/Classes/Service/UserInformationService.php+0 −4
- typo3/sysext/beuser/Classes/ViewHelpers/Display/TableAccessViewHelper.phpdeleted+0 −46
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+39 −17
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+252 −127
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+162 −119
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Show.html+621 −106
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Compare.html+177 −126
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+5 −6
Review log 2949
Show 1224 earlier messages
-
Jasmina Ließmann uploaded patch set 1 08/06/24, 17:01
-
core-ci voted on patch set 1 V +1 08/06/24, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62961
-
Jasmina Ließmann uploaded patch set 2
V +108/06/24, 19:56 -
core-ci voted on patch set 2 V -1 08/06/24, 20:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62969
-
Jasmina Ließmann uploaded patch set 3
V -108/12/24, 13:35 -
core-ci voted on patch set 3 V -1 08/12/24, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63242
-
Jasmina Ließmann uploaded patch set 4
V -108/12/24, 21:40 -
core-ci voted on patch set 4 V +1 08/12/24, 21:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63264
-
Jasmina Ließmann uploaded patch set 5
V +108/13/24, 12:38 -
core-ci voted on patch set 5 V -1 08/13/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63308
-
Jasmina Ließmann uploaded patch set 6
V -108/13/24, 14:51 -
core-ci voted on patch set 6 V +1 08/13/24, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63324
-
Jasmina Ließmann uploaded patch set 7
V +108/14/24, 18:01 -
core-ci voted on patch set 7 V -1 08/14/24, 18:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63405
-
Jasmina Ließmann uploaded patch set 8
V -108/14/24, 21:54 -
Jasmina Ließmann uploaded patch set 9 08/14/24, 22:00
-
core-ci voted on patch set 8 V -1 08/14/24, 22:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63420
-
core-ci voted on patch set 9 V -1 08/14/24, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63421
-
Jasmina Ließmann uploaded patch set 10
V -108/15/24, 09:31 -
core-ci voted on patch set 10 V -1 08/15/24, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63461
-
Jasmina Ließmann uploaded patch set 11
V -108/15/24, 10:46 -
core-ci voted on patch set 11 V -1 08/15/24, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63470
-
Jasmina Ließmann uploaded patch set 12
V -108/15/24, 12:00 -
core-ci voted on patch set 12 V -1 08/15/24, 12:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63476
-
Jasmina Ließmann uploaded patch set 13
V -108/15/24, 12:34 -
core-ci voted on patch set 13 V -1 08/15/24, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63481
-
Jasmina Ließmann uploaded patch set 14
V -108/15/24, 12:54 -
core-ci voted on patch set 14 V -1 08/15/24, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63484
-
Jasmina Ließmann uploaded patch set 15
V -108/17/24, 09:13 -
Jasmina Ließmann uploaded patch set 16 08/17/24, 09:25
-
core-ci voted on patch set 15 V -1 08/17/24, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63625
-
core-ci voted on patch set 16 V -1 08/17/24, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63630
-
core-ci voted on patch set 16 V +1 08/17/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63630
-
Jasmina Ließmann updated the commit message in patch set 17
V +108/17/24, 10:24 -
core-ci voted on patch set 17 V +1 08/17/24, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63636
-
Stefan Bürk voted on patch set 17 CR +1 08/17/24, 10:44
-
Stefan Bürk voted on patch set 17 V +1 08/17/24, 10:50
-
Jasmina Ließmann uploaded patch set 18
CR +1V +108/17/24, 10:57 -
Guido Schmechel commented on patch set 17 V +1 08/17/24, 10:59
Does it make sense to be able to edit further data records from the view? Example: Filemount As a user, I would save myself a click if I could jump directly to the filemount in the view. Or also backend groups. Otherwise, it looks good for me! -
Stefan Bürk voted on patch set 18 CR +1 V +1 08/17/24, 11:00
-
core-ci voted on patch set 18 V +1 08/17/24, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63642
-
Jasmina Ließmann commented on patch set 18 08/17/24, 11:19
Reply
Thanks for your feedback. The current status is that you can only click on some of the numerous icons, but not all of them. For the following lists, you can click on the icon and the context menu opens. Clicking on the title has no function: - Backend user avatar - Backend user groups - DB mount points - File mounts - Category mounts From a user perspective, I found it confusing to only be able to click on certain icons (and not others) and only on the icons. That's why I removed these context menu calls from the views with the patch. The main thing is the (simple) comparison between individual backend users or backend user groups. If desired, I can also add these context menu calls again for the time being. -
Jasmina Ließmann uploaded patch set 19
CR +1V +108/17/24, 12:23 -
core-ci voted on patch set 19 V +1 08/17/24, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63649
-
Jasmina Ließmann commented on patch set 19 08/17/24, 12:38
Reply
I have now added the context menu call again and also linked the labels. The ID of ech element is now displayed on the respective icon when you mouse over it - as is usual in the rest of the system. -
Guido Schmechel commented on patch set 19 CR +1 V +1 08/17/24, 14:36
Thanks for that! It makes sense from my point of view, but let's also listen to other opinions :-) -
Stefan Bürk voted on patch set 19 CR +1 V +1 08/17/24, 15:04
-
Jasmina Ließmann voted on patch set 19 CR +2 V +2 08/18/24, 08:38
-
Jasmina Ließmann merged patch set 20 08/18/24, 08:38