85546[TASK] Decouple dependency serialization logic from Extension Model
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 16
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+4 −4
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+4 −1
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+9 −7
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php+2 −36
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+8 −54
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php2+8 −0
- typo3/sysext/extensionmanager/Classes/Factory/DependencyFactory.phpnew+61 −0
- typo3/sysext/extensionmanager/Classes/Factory/ExtensionFactory.phpnew+55 −0
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+6 −4
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php4+44 −0
- typo3/sysext/extensionmanager/Tests/Unit/Controller/ActionControllerTest.php+3 −1
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/DependencyTest.php+5 −3
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Model/ExtensionTest.php+0 −108
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/ExtensionRepositoryTest.php+10 −6
- typo3/sysext/extensionmanager/Tests/Unit/Service/ExtensionManagementServiceTest.php+3 −1
- typo3/sysext/extensionmanager/Tests/Unit/Utility/DependencyUtilityTest.php+155 −17
Review log 1828
Show 23 earlier messages
-
Nikita Hovratov uploaded patch set 1 08/06/24, 20:24
-
core-ci voted on patch set 1 V -1 08/06/24, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62971
-
Nikita Hovratov uploaded patch set 2
V -108/06/24, 20:32
-
core-ci voted on patch set 2 V +1 08/06/24, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/62972
-
Nikita Hovratov uploaded patch set 3
V +110/26/24, 14:12 -
core-ci voted on patch set 3 V -1 10/26/24, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68675
-
Nikita Hovratov uploaded patch set 4
V -110/26/24, 14:22 -
core-ci voted on patch set 4 V -1 10/26/24, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68676
-
Nikita Hovratov uploaded patch set 5
V -110/26/24, 14:39 -
core-ci voted on patch set 5 V -1 10/26/24, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68677
-
Nikita Hovratov uploaded patch set 6
V -110/26/24, 14:46 -
core-ci voted on patch set 6 V +1 10/26/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68678
-
Nikita Hovratov uploaded patch set 7
V +112/05/24, 19:28 -
core-ci voted on patch set 7 V -1 12/05/24, 19:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70666
-
Nikita Hovratov uploaded patch set 8
V -112/05/24, 19:39 -
Nikita Hovratov uploaded patch set 9 12/05/24, 19:40
-
core-ci voted on patch set 8 V -1 12/05/24, 19:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70668
-
core-ci voted on patch set 9 V +1 12/05/24, 19:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70669
-
Benni Mack voted on patch set 9 CR +1 12/10/24, 15:22
-
Benni Mack commented on patch set 9 V +1 12/13/24, 17:08
works on my machine(tm) -
Benjamin Franzke commented on patch set 9 CR -1 03/04/25, 12:56
ExtensionRepository.php:366I feels fragile that we need to be clever enough not to forget to call `dependencyUtility->convertDependenciesToObjects` and to know *when* to call it. I'd love a lazy closure (as in our record objects) if the reason is performance.DependencyUtility.php:178Looks like this could use a `DepdencyFactory`.DependencyUtility.php:183The return type of this method implies that is is stateless, but it is actually stateful by modifying the input-object. It should therefore return `void`. -
Nikita Hovratov uploaded patch set 10
CR +1V +103/04/25, 20:37 -
core-ci voted on patch set 10 V +1 03/04/25, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75113
-
Nikita Hovratov commented on patch set 10 03/04/25, 20:50
ExtensionRepository.php:366Reply UnresolvedI know, it also felt not right for me when I wrote it. But: As long as it is a Domain Model, it's very hard to have a proper "RecordFactory / RecordFieldTransformer" in between. The whole strategy of this patch is to first thin out the Model of every logic until only the properties are left. Then, I can finally remove all TCA and rewrite the repositories to query builder. For the meantime this is a workaround to call it explicitly where it's needed. These are however assessable and we are still on v14 dev, so I hope this fragileness is acceptable,DependencyUtility.php:178ReplyDoneDependencyUtility.php:183ReplyDone -
Benni Mack commented on patch set 10 03/26/25, 10:56
OK. I tried to work with this... I think that this strategy does not help in our overall goal to get rid of Extbase in our case. What I would do (will do a separate change): Switch to plain SQL queries in repository instead of Extbase Queries. -
Benni Mack voted on patch set 10 CR -1 03/26/25, 10:56
-
Benni Mack marked it work in progress 03/26/25, 11:10
-
Nikita Hovratov abandoned the change 03/26/25, 16:22