Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
85550[BUGFIX] Remove movement of closing notification message
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 7
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/85550/7 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/50/85550/7 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -1 Needs a vote
- Benni Mack -1
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 2
Files 2
Review log 1117
-
Ayke Halder uploaded patch set 1 08/07/24, 15:09
-
Ayke Halder updated the commit message in patch set 2 08/07/24, 15:16
-
core-ci voted on patch set 1 V +1 08/07/24, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63001
-
Ayke Halder updated the commit message in patch set 3 08/07/24, 15:17
-
core-ci voted on patch set 2 V +1 08/07/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63002
-
core-ci voted on patch set 3 V +1 08/07/24, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63003
-
Ayke Halder uploaded patch set 4
V +108/22/24, 19:49 -
core-ci voted on patch set 4 V -1 08/22/24, 19:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64015
-
Ayke Halder rebased onto patch set 5
V -108/22/24, 20:56 -
core-ci voted on patch set 5 V +1 08/22/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64020
-
Benni Mack updated the commit message in patch set 6
V +110/18/24, 13:44 -
Benjamin Kott commented on patch set 6 V -1 11/18/24, 20:13
patch seems to be obsolete, cannot notice any changes in behaviour. at least target v13, main seems to be invalid. -
Ayke Halder commented on patch set 6 11/19/24, 07:36
Reply
The change in behaviour is recognizable - also in v13: See discussion: https://typo3.slack.com/archives/C027S88NY/p1722843500253449 Videos there show closing of green notification box. The difference should be directly recognizable or really visible by playing at 0.25x speed. With the current implementation the icon and text actually 'moves' - and thereby gets recognized subconsciously. With this patch here implemented it doesn't move, it just closes and fades away without being recognized. -
Benjamin Kott commented on patch set 6 11/20/24, 11:32
Reply Unresolved
It moved to fast, so several people did not really notice the change here at the code sprint when comparing side by side. The only feedback that was given was that this version Version felt off and wrong, but no one could really spot the difference. After slowing down as you suggested we could see the difference and had several discussions and had a deeper look how the animation takes place in general, and we came to the conclusion that neither version - the current nor the suggested really feel good. There is no entry animation at all, and the closing animation feels off and not like a natural movement. Adding new elements seems flickering and not smooth. This is a result of moving the notifications from top to bottom, adding an overflow and a clear button, needing to hotfix and add a border around the scrollable container to make it some kind of working. I think we need to stop patching around in this area and take a step back and talk about a more general approach on handling notifications to fix it and provide a good feeling to the user. A quick look at the current codebase for handling notifications suggests that we need to rework this area even more to be able to provide good feeling natural unintrusive animations here. We will check this After the Code Sprint to see how we can rework this area, for now i would like to reject this patch for the named reasons. As is made people pointing out something feels wrong and it really does not have a huge impact. -
Benni Mack updated the commit message in patch set 7
V -104/22/26, 06:54 -
core-ci voted on patch set 7 V -1 04/22/26, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100829
-
Benni Mack commented on patch set 7 CR -1 10/09/26, 16:28
Unresolved
ping, please continue, rebase or abandon