85552[TASK] Replace column length comparison with schema normalization
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php5+27 −13
- typo3/sysext/core/Tests/Functional/Database/Fixtures/mediumTextTable.sqlnew+7 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/mediumTextTable_changeToLongText.sqlnew+7 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newTable.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+36 −0
Review log 2029
Show 24 earlier messages
-
Stefan Bürk uploaded patch set 1 08/07/24, 19:06
-
Stefan Bürk updated the commit message in patch set 2 08/07/24, 19:10
-
core-ci voted on patch set 1 V +1 08/07/24, 19:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63013
-
core-ci voted on patch set 2 V +1 08/07/24, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63014
-
Stefan Bürk updated the commit message in patch set 3
V +108/07/24, 21:04 -
core-ci voted on patch set 3 V +1 08/07/24, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63016
-
Stefan Bürk uploaded patch set 4
V +108/08/24, 09:34 -
core-ci voted on patch set 4 V -1 08/08/24, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63038
-
Stefan Bürk uploaded patch set 5
V -108/08/24, 09:54 -
core-ci voted on patch set 5 V +1 08/08/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63039
-
Stefan Bürk rebased onto patch set 6
V +108/08/24, 12:10 -
core-ci voted on patch set 6 V +1 08/08/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63044
-
Stefan Bürk wrote 08/08/24, 12:52
Topic set to doctrine/dbal -
Stefan Bürk rebased onto patch set 7
V +108/08/24, 17:00 -
core-ci voted on patch set 7 V +1 08/08/24, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63067
-
Christian Kuhn uploaded patch set 8
V +108/08/24, 17:30 -
core-ci voted on patch set 8 V +1 08/08/24, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63068
-
Christian Kuhn voted on patch set 8 CR +1 V +1 08/08/24, 17:36
-
Garvin Hicking updated the commit message in patch set 9
CR +1V +108/08/24, 17:40 -
Christian Kuhn updated the commit message in patch set 10 08/08/24, 17:42
-
Christian Kuhn updated the commit message in patch set 11 08/08/24, 17:45
-
Garvin Hicking commented on patch set 11 CR +1 V +1 08/08/24, 17:45
(minor feedback, advance vote)ConnectionMigrator.php:299Use constant PHP_INT_MAX instead?ConnectionMigrator.php:1893PHP_INT_MAX? -
Christian Kuhn voted on patch set 11 CR +1 V +1 08/08/24, 17:45
-
Anja Leichsenring voted on patch set 11 CR +1 V +1 08/08/24, 17:46
-
Christian Kuhn commented on patch set 11 08/08/24, 17:47
ConnectionMigrator.php:299Replyno. this is 2^31-1 ... PHP_INT_MAX is 2^32 on 32 bit h/w and 2^64 on 64 bit.ConnectionMigrator.php:1893ReplyDone -
Christian Kuhn commented on patch set 11 08/08/24, 17:49
ConnectionMigrator.php:299Replyactually, PHP_INT_MAX signed, but still, we want the db-length and not php-int-max here. -
core-ci voted on patch set 11 V +1 08/08/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63071
-
Christian Kuhn voted on patch set 11 CR +2 V +2 08/08/24, 17:53
-
Christian Kuhn merged patch set 12 08/08/24, 17:53