Review main Merged

85553[TASK] Normalize DecimalType default value for comparison

Stefan Bürk CR +2 V +2 Easy +29 −0 updated 08/08/24, 18:10

Commit message

With #102875 Doctrine DBAL has been upgraded to the
`Doctine DBAL v4` major version, keeping the column
comparison from Doctrine DBAL 3 by cloning the old
code into the TYPO3 Core `Comparator` until compare
issues have been mitigated.

Changes #104567 and #104568 already mitigated some
of these comparison failures using the new method
`AbstractPlatform::columnsEqual()` for compare.

This change prepares the switch to Doctrine DBAL 4
by ensuring default values for DecimalTypes are
normalized. This matches how MySQL/MariaDB
reports them based on the scale setting.

This can be tested by manually removing `columnsEqual()`
from `\TYPO3\CMS\Core\Database\Schema\Comparator`, which
resolves the remaining "failed" changes in the clean
database schema test

    `CleanSchemaMigrationForAllSystemExtensionTest`

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 4

Files 1

Review log 912

  1. Stefan Bürk uploaded patch set 1 08/08/24, 11:21

  2. core-ci voted on patch set 1 V +1 08/08/24, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63041

  3. Stefan Bürk rebased onto patch set 2 V +1 08/08/24, 12:10

  4. core-ci voted on patch set 2 V +1 08/08/24, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63045

  5. Stefan Bürk wrote 08/08/24, 12:52

    Topic set to doctrine/dbal
  6. Christian Kuhn uploaded patch set 3 V +1 08/08/24, 17:58

  7. Christian Kuhn uploaded patch set 4 08/08/24, 18:00

  8. Anja Leichsenring voted on patch set 4 CR +1 V +1 08/08/24, 18:02

  9. Christian Kuhn voted on patch set 4 CR +1 V +1 08/08/24, 18:02

  10. core-ci voted on patch set 4 V +1 08/08/24, 18:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63074

  11. Christian Kuhn voted on patch set 4 CR +2 V +2 08/08/24, 18:10

  12. Christian Kuhn merged patch set 5 08/08/24, 18:10