85554[TASK] Reduce amount of noisy CSP reports
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Oliver Hader +2
- Garvin Hicking +1
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1922
-
Oliver Hader uploaded patch set 1 08/08/24, 11:24
-
core-ci voted on patch set 1 V +1 08/08/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63042
-
Andreas Kienast commented on patch set 1 08/08/24, 12:19
-
Garvin Hicking commented on patch set 1 08/08/24, 22:34
AbstractContentSecurityPolicyReporter.php:58ReplyI believe typo3/sysext/core/Classes/Security/ContentSecurityPolicy/PolicyProvider.php L94 in this patch? -
Andreas Kienast commented on patch set 1 08/09/24, 05:50
AbstractContentSecurityPolicyReporter.php:58ReplyArgh, thanks. For whatever reason I didn't notice the other changed file. Scrap my comment. -
Andreas Kienast voted on patch set 1 CR +1 08/09/24, 07:00
-
Garvin Hicking commented on patch set 1 CR +1 V +1 08/09/24, 10:47
Works for me, and IMO a good idea. I wonder though if `isCspReport` may be a more natural place to do this validation (also moving the requestTime check there)? -
Benni Mack updated the commit message in patch set 2
CR +1V +110/18/24, 13:42 -
Garvin Hicking voted on patch set 2 CR +1 V +1 10/18/24, 19:42
-
Benni Mack rebased onto patch set 3
CR +1V +110/28/24, 09:00 -
Andreas Kienast commented on patch set 3 CR +1 V +1 10/28/24, 09:03
Reply
I don't think it matches there. Whether the hmac is valid or not, the request is still a CSP report, from a technical POV. -
core-ci voted on patch set 3 V +1 10/28/24, 09:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68712
-
Garvin Hicking commented on patch set 3 CR +1 V +1 10/28/24, 09:12
Reply
ack -
Oliver Hader updated the commit message in patch set 4
CR +1V +112/24/24, 11:29 -
Oliver Hader commented on patch set 4 12/24/24, 11:30
I'd opt for back-porting this to TYPO3 v12 as well. -
core-ci voted on patch set 4 V +1 12/24/24, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71600
-
Garvin Hicking voted on patch set 4 CR +1 V +1 12/24/24, 13:00
-
Stefan Bürk voted on patch set 4 CR +1 01/03/25, 09:20
-
Stefan Bürk voted on patch set 4 V +1 01/03/25, 13:17
-
Christian Kuhn voted on patch set 4 CR +1 V +1 01/06/25, 13:31
-
Oliver Hader voted on patch set 4 CR +2 V +2 01/07/25, 17:57
-
Oliver Hader merged patch set 5 01/07/25, 17:57
AbstractContentSecurityPolicyReporter.php:58