Review main Merged

85555[TASK] Move ConnectionMigrator index normalization to method

Stefan Bürk CR +2 V +2 Normal +46 −65 updated 08/08/24, 18:28

Commit message

Doctrine DBAL 4 has been introduced with #102875.
The new version required additional normalization in
`ConnectionMigrator`, implemented via #104571, #104568
and #104567. This kept an intermediate method calling
the new normalization chain and contained table index
normalization.

This change moves the index normalization into a dedicated
method and adds it to the central table loop.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 5

Files 1

Review log 710

  1. Stefan Bürk uploaded patch set 1 08/08/24, 12:10

  2. core-ci voted on patch set 1 V +1 08/08/24, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63046

  3. Stefan Bürk wrote 08/08/24, 12:52

    Topic set to doctrine/dbal
  4. Garvin Hicking updated the commit message in patch set 2 V +1 08/08/24, 18:06

  5. core-ci voted on patch set 2 V +1 08/08/24, 18:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63076

  6. Christian Kuhn uploaded patch set 3 V +1 08/08/24, 18:17

  7. Anja Leichsenring voted on patch set 3 CR +1 V +1 08/08/24, 18:20

  8. core-ci voted on patch set 3 V +1 08/08/24, 18:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63077

  9. Christian Kuhn voted on patch set 3 CR +2 V +2 08/08/24, 18:28

  10. Christian Kuhn merged patch set 4 08/08/24, 18:28