Review main Abandoned

85556[BUGFIX] Remove clearfixes in palette rendering

Armin Vieweg CR 0 V 0 Hard +227 −123 updated 04/16/25, 10:25

Commit message

The grid system in Bootstrap CSS framework is able
to handle sizing of columns on its own. Therefore,
no column width calculation is required anymore.

To align form fields correctly, the max-width
inline style on "form-control-wrap" has been
entirely removed.

To avoid a single line field with 100% width,
a "col-lg-9" class will get added, if a palette
row contains only one item.

Also, instead of using "clearfix" to interrupt
a grid row (used for --linebreak--), a new grid row
is being used.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 17

Review log 2735

Show 810 earlier messages
  1. Armin Vieweg uploaded patch set 1 08/08/24, 12:26

  2. core-ci voted on patch set 1 V +1 08/08/24, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63047

  3. Markus Klein voted on patch set 1 CR +1 08/08/24, 19:14

  4. Nikita Hovratov voted on patch set 1 CR +1 V +1 08/11/24, 12:54

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 08/23/24, 12:26

  6. Benni Mack updated the commit message in patch set 2 CR +1 V +1 10/18/24, 13:44

  7. Benni Mack rebased onto patch set 3 10/28/24, 15:40

  8. core-ci voted on patch set 3 V +1 10/28/24, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68730

  9. Jörg Bösche voted on patch set 3 CR +1 11/01/24, 11:15

  10. Garvin Hicking uploaded patch set 4 CR +1 V +1 11/02/24, 10:09

    Add styleguide example
  1. Garvin Hicking commented on patch set 4 11/02/24, 10:14

    I've added an EXT:styleguide example (not to be backported to v12). Screenshots are in the issue: https://forge.typo3.org/issues/98354#note-13 I think it improves the situation somewhat, but I must admit it makes many floating checkboxes look a lot more confusing than before.
  2. core-ci voted on patch set 4 V +1 11/02/24, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68976

  3. Simon Schaufelberger commented on patch set 4 CR +1 11/02/24, 12:06

    I'm not sure if this is critical to be packported.
  4. Garvin Hicking commented on patch set 4 11/02/24, 12:17

    Reply

    Me neither, I left it how Benni rebased it after branching. Actually I might even recommend to address this in main only.
  5. Nikita Hovratov commented on patch set 4 11/02/24, 22:44

    Reply

    @gh@faktor-e.de This is actually a welcome bugfix for the editing interface, as fields are not wrapped "randomly" even if there is still space. My collegue had this problem and it seemed just unintuitive why it does that. So for v13 this should definitely go in. For v12 this is not critical enough, yeah.
  6. Garvin Hicking commented on patch set 4 11/03/24, 00:33

    Reply

    Sure! I don't mind either - just it feels that this may not yet be the final solution, I think there are quirks left, asked in #cig-ux for feedback since I'm not versed enough in the high art of flexboxing and gridding🥲
  7. Markus Klein voted on patch set 4 CR +1 V +1 11/04/24, 13:01

  8. Simon Schaufelberger updated the commit message in patch set 5 CR +1 V +1 11/05/24, 10:20

  9. Simon Schaufelberger commented on patch set 5 CR +1 V +1 11/05/24, 10:20

    Reply

    Done
  10. core-ci voted on patch set 5 V +1 11/05/24, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69092

  11. Andreas Kienast commented on patch set 5 V -1 11/05/24, 13:16

    This patch makes the FormEngine worse now. Vertical spaces are broken and fields are not aligned anymore (tested with a regular content element).
  12. Nikita Hovratov commented on patch set 5 11/05/24, 14:48

    Reply

    Yes, you are right. This is not as easy at it seemed. Right now we kinda define a rigid grid-system based on number of columns. This allows fields to fill in the space and the alignment works. If we make everything "auto-column", then the alignment won't work anymore. It would work, if you disallow flex-grow / allow flex-shrink, but then all fields would have the minimum width possible. I have no idea how to have it both.
  13. Armin Vieweg uploaded patch set 6 CR +1 V +1 11/07/24, 13:47

  14. core-ci voted on patch set 6 V -1 11/07/24, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69192

  15. Armin Vieweg uploaded patch set 7 V -1 11/07/24, 14:44

  16. core-ci voted on patch set 7 V +1 11/07/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69198

  17. Armin Vieweg commented on patch set 7 11/07/24, 15:13

    Reply Unresolved

    Please check latest patchset. I've fixed both issues.
  18. Markus Klein commented on patch set 7 11/07/24, 18:33

    AbstractFormElement.php:336

    Wouldn't remove this method. This is the base class for almost any FormElement and hence extension may rely on this method.
  19. Armin Vieweg commented on patch set 7 11/08/24, 13:35

    AbstractFormElement.php:336 Reply Unresolved

    Yes, you are right. I've did a quick search on Github and found already FormElements using this method. I'm going to revert the deletion of the method.
  20. Armin Vieweg uploaded patch set 8 V +1 11/08/24, 13:42

  21. core-ci voted on patch set 8 V +1 11/08/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69235

  22. Benni Mack uploaded patch set 9 V +1 03/28/25, 11:44

  23. core-ci voted on patch set 9 V +1 03/28/25, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76572

  24. Benjamin Kott commented on patch set 9 CR -2 04/16/25, 10:23

    This patch will not make it. We use the calc that's being removed to limit the width of the element that is independed from cols. It´s also not addressing the issue described in the ticket.
  25. Benjamin Kott abandoned the change 04/16/25, 10:25

    Wrong approach, not feasible, does not address issue in ticket, creates new problems. not salvageable.