Review main Merged

85558[BUGFIX] Mitigate UnknownColumnOption exception in database compare

Stefan Bürk CR +2 V +2 Normal +93 −24 updated 08/08/24, 19:13

Commit message

With #102875 Doctrine DBAL has been upgraded to the Doctrine DBAL
v4 major version, which introduced additional schema normalizations
along other changes that allow to drop legacy code.

The code got removed with #104573, but still left ENUM and
SET types in a broken state. The custom platform option
transporting the ENUM or SET field values was not removed
before creating a column within one normalization method.
Doctrine DBAL does not know the option and throws an
`Doctrine\DBAL\Schema\Exception\UnknownColumnOption`
exception.

This change now splits the custom platform option and delivers
the new column object correctly, mitigating the Doctrine
exception. Adding tests revealed that ENUM and SET types
are not cross database compatible, which also affects TYPO3 v12
and is adressed by a POC fix [1].

To honor this, ENUM and SET type implementations received `@todo`
comments to properly deprecate and remove these implementations
in dedicated patches (with added complexity due to handling issues).

[1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/85557

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 8

Review log 1220

  1. Stefan Bürk uploaded patch set 1 08/08/24, 15:28

  2. Stefan Bürk uploaded patch set 2 08/08/24, 15:30

  3. Stefan Bürk wrote 08/08/24, 15:33

    Topic set to doctrine/dbal
  4. core-ci voted on patch set 2 V -1 08/08/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63060

  5. core-ci voted on patch set 1 V -1 08/08/24, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63058

  6. Stefan Bürk uploaded patch set 3 V -1 08/08/24, 15:48

  7. core-ci voted on patch set 3 V -1 08/08/24, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63062

  8. Garvin Hicking updated the commit message in patch set 4 V -1 08/08/24, 18:03

  9. core-ci voted on patch set 4 V -1 08/08/24, 18:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63075

  10. Christian Kuhn rebased onto patch set 5 V -1 08/08/24, 18:41

  11. core-ci voted on patch set 5 V -1 08/08/24, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63080

  12. Christian Kuhn uploaded patch set 6 V -1 08/08/24, 18:55

  13. Christian Kuhn uploaded patch set 7 08/08/24, 18:59

  14. Christian Kuhn uploaded patch set 8 08/08/24, 19:04

  15. core-ci voted on patch set 6 V +1 08/08/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63082

  16. core-ci voted on patch set 7 V +1 08/08/24, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63084

  17. core-ci voted on patch set 8 V +1 08/08/24, 19:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63085

  18. Anja Leichsenring voted on patch set 8 CR +1 V +1 08/08/24, 19:13

  19. Christian Kuhn voted on patch set 8 CR +2 V +2 08/08/24, 19:13

  20. Christian Kuhn merged patch set 9 08/08/24, 19:13