Review main Merged

85562[TASK] Activate PHP 8.4 unit tests

Christian Kuhn CR +2 V +2 Normal +198 −22 updated 08/09/24, 09:58

Commit message

We want to go ahead with PHP 8.4 compatibility and
activate unit tests using PHP 8.4 alpha 4 in CI.

Dependencies triggered by unit tests are mainly
ready and raised already, except firebase/php-jwt:

They merged an according patch, but did not release
yet [2]. We - for now - composer-patch this dependency
in order to focus on PHP 8.4 support in other test
suites like functionals, while being backed by green
unit tests in CI already. The applied patch is the
8.4 part of firebase/php-jwt PR #572 [1], which has
been squashed to dev-main by the maintainers with
another commit we had to submit to greenify their CI
along the way.

CI pre-merge tests now unit test "locked" 8.2 and 8.4,
skipping 8.3. 8.3 "locked" is added to nightly instead,
along with 8.4 "max". 8.4 "min" is not added since
the transitive dependencies 'symfony/string' and
'symfony/cache' are not 8.4 ready in their "min"
versions.

> composer config --no-plugins --no-interaction allow-plugins.cweagans/composer-patches true
> composer config --no-plugins --no-interaction extra.composer-exit-on-patch-failure true
> composer config --no-plugins --no-interaction extra.patches-file "Build/patches/patches.json"
> composer require --dev "cweagans/composer-patches":"^1.7.3"
> composer req firebase/php-jwt:^6.10.1

[1] https://github.com/firebase/php-jwt/pull/572/commits/7c7f4bce5570f9f7f18906ce0082deb4b64f68ee
[2] https://github.com/firebase/php-jwt/issues/570

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1528

Show 23 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/08/24, 19:44

  2. core-ci voted on patch set 1 V -1 08/08/24, 19:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63089

  3. Christian Kuhn uploaded patch set 2 V -1 08/08/24, 19:55

  1. core-ci voted on patch set 2 V +1 08/08/24, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63090

  2. core-ci voted on patch set 2 V -1 08/08/24, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63091

  3. Christian Kuhn uploaded patch set 3 V -1 08/08/24, 21:33

  4. core-ci voted on patch set 3 V +1 08/08/24, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63094

  5. core-ci voted on patch set 3 V -1 08/08/24, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63095

  6. core-ci voted on patch set 3 V +1 08/09/24, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63095

  7. Christian Kuhn uploaded patch set 4 V +1 08/09/24, 08:36

  8. Christian Kuhn updated the commit message in patch set 5 08/09/24, 08:39

  9. Christian Kuhn uploaded patch set 6 08/09/24, 08:41

  10. core-ci voted on patch set 4 V +1 08/09/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63114

  11. core-ci voted on patch set 5 V +1 08/09/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63115

  12. Christian Kuhn updated the commit message in patch set 7 08/09/24, 08:49

  13. core-ci voted on patch set 6 V +1 08/09/24, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63116

  14. Christian Kuhn uploaded patch set 8 08/09/24, 08:51

  15. Christian Kuhn uploaded patch set 9 08/09/24, 08:54

  16. core-ci voted on patch set 8 V -1 08/09/24, 08:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63119

  17. core-ci voted on patch set 9 V -1 08/09/24, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63121

  18. core-ci voted on patch set 9 V +1 08/09/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63121

  19. core-ci commented on patch set 9 08/09/24, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63124

  20. Christian Kuhn voted on patch set 9 CR +1 V +1 08/09/24, 09:41

  21. Benni Mack voted on patch set 9 CR +1 V +1 08/09/24, 09:47

  22. Benni Mack commented on patch set 9 08/09/24, 09:47

    not a fan of cweagans added here, but hopefully we can remove it soon again
  23. Christian Kuhn commented on patch set 9 08/09/24, 09:55

    Reply

    yes. this is intermediate hopefully, and can be removed as soon as firebase/php-jwt has been tagged. i just want it "now" to continue work on functionals and ac tests ...
  24. Anja Leichsenring voted on patch set 9 CR +2 V +2 08/09/24, 09:58

  25. Anja Leichsenring merged patch set 10 08/09/24, 09:58