Review main Merged

85569[TASK] Convert focus area to string explicitly

Simon Praetorius CR +2 V +2 Easy +3 −18 updated 08/09/24, 12:38

Commit message

Currently, the Area object is converted to a JSON string representation
implicitly inside the TagBuilder. With newer Fluid versions, this will
break because of type hints on addAttribute(). To prevent this, we
convert to JSON explicitly before handling the result to TagBuilder.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Simon Praetorius uploaded patch set 1 08/09/24, 10:53

  2. core-ci voted on patch set 1 V -1 08/09/24, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63129

  3. Simon Praetorius uploaded patch set 2 V -1 08/09/24, 11:57

  4. core-ci voted on patch set 2 V +1 08/09/24, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63136

  5. Christian Kuhn voted on patch set 2 CR +1 V +1 08/09/24, 12:25

  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 08/09/24, 12:30

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/09/24, 12:38

  8. Christian Kuhn merged patch set 3 08/09/24, 12:38