85571[WIP][TASK/FEATURE] Add custom TYPO3 flavored AsCommand attribute
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 4
Review log 34
-
Benjamin Franzke uploaded patch set 1 08/09/24, 11:39
-
Benjamin Franzke commented on patch set 1 CR -1 08/09/24, 11:46
I'm against a TYPO3 flavored AsCommand attribute for two reasons * This is not `ext:core` scope, this is `ext:scheduler` business logic * Every command should actually be `schedulable`, it is an anti-pattern that our commands are often to flaky to be schedulable. I therefore think it's fine to keep those unlovely commands defined in `Services.yaml` -
core-ci voted on patch set 1 V +1 08/09/24, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63134
-
Benjamin Franzke abandoned the change 08/27/24, 07:43
not EXT:core scope