Review main Merged

85572[TASK] Merge UnitDeprecated into Unit

Christian Kuhn CR +2 V +2 Expert +606 −1184 updated 08/09/24, 14:12

Commit message

Younger phpunit come with a happy little feature
to suppress E_DEPRECATED and E_USER_DEPRECATED
errors: The attribute `#[IgnoreDeprecations]` makes
a test not fail when such a deprecation is triggered
by the test subject, even when failOnDeprecation=true
is set in phpunit XML.

Using the attribute has been recommended by phpunit
maintainer Sebastian Bergmann.

This allows us to give up on the current strategy of
moving tests that test deprecated subjects to an own
directory. This simplifies maintenance, makes
patches that deprecate things more easy to review,
and saves some CI jobs.

During 'deprecation removal phase' at the beginning
of new major branches, we now simply look up usages
of the attribute to see what needs to be removed.

The patch takes care of 'UnitDeprecated' tests by
merging them back into 'Unit' and adding the
attribute. It also adapts runTests.sh to remove
the `-s unitDeprecated` test suite and adapts CI.
'FunctionalDeprecated' will follow with a separate
patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 42

Show 22 more files

Review log 1218

  1. Christian Kuhn uploaded patch set 1 08/09/24, 11:53

  2. core-ci voted on patch set 1 V +1 08/09/24, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63135

  3. Christian Kuhn updated the commit message in patch set 2 V +1 08/09/24, 12:07

  4. core-ci voted on patch set 2 V +1 08/09/24, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63138

  5. core-ci voted on patch set 1 V +1 08/09/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63137

  6. Christian Kuhn uploaded patch set 3 V +1 08/09/24, 13:43

  7. Christian Kuhn updated the commit message in patch set 4 08/09/24, 13:46

  8. core-ci voted on patch set 3 V -1 08/09/24, 13:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63142

  9. core-ci voted on patch set 4 V +1 08/09/24, 13:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63143

  10. Simon Praetorius voted on patch set 4 CR +1 V +1 08/09/24, 13:55

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 08/09/24, 13:59

  12. Andreas Kienast updated the commit message in patch set 5 CR +1 V +1 08/09/24, 14:00

  13. Andreas Kienast voted on patch set 5 CR +1 V +1 08/09/24, 14:01

  14. Stefan Bürk voted on patch set 5 CR +1 V +1 08/09/24, 14:03

  15. Simon Praetorius voted on patch set 5 CR +1 V +1 08/09/24, 14:05

  16. core-ci voted on patch set 5 V +1 08/09/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63144

  17. Christian Kuhn voted on patch set 5 CR +2 V +2 08/09/24, 14:11

  18. Christian Kuhn merged patch set 6 08/09/24, 14:12