Review main Abandoned

85573[WIP][TASK] Ensure charset and collation can be defined per column

Stefan Bürk CR 0 V 0 Normal +69 −0 updated 11/08/24, 05:55

Commit message

@todo Applying column options (charset/collatoion) needs to
      be fixed in a pre-patch first. Currently, the schema
      (connection) information is applied, not taking into
      account that it may be explicitly overridden for a
      table.

In some cases it can be use-full to set different
`charset` or `collation` on column level compared
to the connection and/or table settings.

The TYPO3 Lexer already recognizes these options,
and the TYPO3 Parser translates it to the proper
Doctrine DBAL names and putting them into DataType
options collection. These DataBase option are not
used and transformed into Doctrine DBAL Column
settings within the `TableBuilder` and thus literlly
breaking the override here.

This change modifies the TableBuilder to ensure that
the collation and charset settings are applied onto
the Column definition adding tests to ensure working
state.

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 23

  1. Stefan Bürk uploaded patch set 1 08/09/24, 12:58

  2. core-ci voted on patch set 1 V -1 08/09/24, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63140

  3. Stefan Bürk abandoned the change 11/08/24, 05:55