Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
85574[WIP][FEATURE] Language-aware slugs and slug normalizer API
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 16
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/85574/16 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/85574/16 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Stefan Bürk -2
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 19
- Build/phpstan/phpstan-baseline.neon+0 −6
- typo3/sysext/core/Classes/DataHandling/DataHandler.php1+84 −5
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+102 −28
- typo3/sysext/core/Classes/Slug/AsciiSlugNormalizer.php1new+54 −0
- typo3/sysext/core/Classes/Slug/LegacySlugNormalizer.php2new+75 −0
- typo3/sysext/core/Classes/Slug/SlugNormalizationOptions.phpnew+43 −0
- typo3/sysext/core/Classes/Slug/SlugNormalizer.phpdeleted+0 −74
- typo3/sysext/core/Classes/Slug/SlugNormalizerFactory.phpnew+81 −0
- typo3/sysext/core/Classes/Slug/SlugNormalizerFactoryInterface.phpnew+23 −0
- typo3/sysext/core/Classes/Slug/SlugNormalizerInterface.phpnew+24 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+3 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+9 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-20612-LanguageAwareSlugs.rstnew+120 −0
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php2+2 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+93 −29
- typo3/sysext/core/Tests/Unit/Slug/LegacySlugNormalizerTest.phprenamed+40 −38
- typo3/sysext/core/composer.json+1 −0
- composer.json+1 −0
- composer.lock+7 −7
Review log 2743
Show 1218 earlier messages
-
Mathias Bolt Lesniak uploaded patch set 1 08/09/24, 14:34
-
core-ci voted on patch set 1 V -1 08/09/24, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63145
-
Garvin Hicking commented on patch set 1 08/09/24, 21:56
Feature-20612-LanguageAwareSlugs.rst:17Even thoufh Hitherto sounds funny, maybe we should not make poor german integrators open up their dictionaries, so maybe use easier language here? *g* -
Chris Müller commented on patch set 1 08/10/24, 07:48
Feature-20612-LanguageAwareSlugs.rst:18Two underscores are missing after the last backtick, so it is rendered correctly as external link.Feature-20612-LanguageAwareSlugs.rst:31Avaliable -> AvailableFeature-20612-LanguageAwareSlugs.rst:91I suggest to add a :caption:, like "EXT:my_extension/Classes/Slug/EmojiSlugNormalizer.php" for easy adoption by the reader.Feature-20612-LanguageAwareSlugs.rst:113This should be a short summary of the feature (not "None now."). -
Chris Müller commented on patch set 1 08/10/24, 07:50
LegacySlugNormalizer.php:30Maybe add @deprecated to it (see also my comment on the rst file).Feature-20612-LanguageAwareSlugs.rst:115As LegacySlugNormalizer is marked as internal, it might not be necessary to deprecate it. Or, when dit should be deprecated, this should also be stated in the class with @deprecated. -
Mathias Bolt Lesniak uploaded patch set 2
V -108/12/24, 09:21 -
Mathias Bolt Lesniak commented on patch set 2 08/12/24, 09:28
LegacySlugNormalizer.php:30Reply UnresolvedI don't know. @stefan@buerk.tech will have to give his input on what the correct strategy would be.Feature-104126-AddConfigurationSettingToDefineBackendLockingFile.rst:6ReplyThanks for noticing! This is fixed in patchset 2.Feature-20612-LanguageAwareSlugs.rst:17ReplyI have changed "Hitherto" to "Until now" in patchset 2.Feature-20612-LanguageAwareSlugs.rst:18ReplyThanks for noticing. This is fixed in patchset 2.Feature-20612-LanguageAwareSlugs.rst:31ReplyThanks for noticing. This is fixed in patchset 2.Feature-20612-LanguageAwareSlugs.rst:91ReplyThanks for the suggestion. This is fixed in patchset 2.Feature-20612-LanguageAwareSlugs.rst:113Reply UnresolvedThanks for the input. This should look better in patchset 2. What do you think?Feature-20612-LanguageAwareSlugs.rst:115Reply UnresolvedI don't know. @stefan@buerk.tech will have to give his input on what the correct strategy would be. -
core-ci voted on patch set 2 V -1 08/12/24, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63209
-
Mathias Bolt Lesniak uploaded patch set 3
V -108/12/24, 09:35 -
core-ci voted on patch set 3 V -1 08/12/24, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63210
-
Mathias Bolt Lesniak uploaded patch set 4
V -108/12/24, 12:36 -
core-ci voted on patch set 4 V -1 08/12/24, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63228
-
Mathias Bolt Lesniak uploaded patch set 5
V -108/13/24, 08:32 -
core-ci voted on patch set 5 V -1 08/13/24, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63284
-
Mathias Bolt Lesniak uploaded patch set 6
V -108/13/24, 10:40 -
core-ci voted on patch set 6 V -1 08/13/24, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63297
-
Mathias Bolt Lesniak uploaded patch set 7
V -108/13/24, 13:05 -
Mathias Bolt Lesniak uploaded patch set 8 08/13/24, 13:11
-
core-ci voted on patch set 7 V -1 08/13/24, 13:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63310
-
Mathias Bolt Lesniak uploaded patch set 9 08/13/24, 13:13
-
Mathias Bolt Lesniak uploaded patch set 10 08/13/24, 13:18
-
core-ci voted on patch set 8 V -1 08/13/24, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63311
-
core-ci voted on patch set 9 V +1 08/13/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63313
-
Mathias Bolt Lesniak commented on patch set 10 08/13/24, 13:30
DataHandler.php:9867Unresolved@stefan@buerk.tech As mentioned in the preceding comment, this seems to be allowed today, but should probably result in an exception. I'm allowing it here, as I had a lot of tests to fail otherwise.SiteBasedTestTrait.php:104@stefan@buerk.tech It seems like a logical inconsistency to allow a site's default language to have a non-zero language ID. If I don't add this, TYPO3 will start looking for content in the non-zero language ID. -
core-ci voted on patch set 10 V +1 08/13/24, 13:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63316
-
Stefan Bürk commented on patch set 10 CR -2 08/14/24, 00:44
Unresolved
tmp -2 .. need to have a detailed look onto this change -
Stefan Bürk uploaded patch set 11
V +109/10/24, 11:25Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Stefan Bürk commented on patch set 11 CR -2 09/10/24, 11:26
Unresolved
Working on this change now ... -
core-ci voted on patch set 11 V +1 09/10/24, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65218
-
Stefan Bürk commented on patch set 11 09/11/24, 17:10
SiteBasedTestTrait.php:104Reply UnresolvedThe point is, that you changed the preset for a language which was meant to be used as "default" language to a language id - and thus needing this now. On the other hand, you changed tests to additional add that language as additional languae requireing a non-zero language id. Not sure if we keep that changing through out all tests. Need to look into it. -
Stefan Bürk uploaded patch set 12
V +109/11/24, 23:22Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 12 V -1 09/11/24, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65508
-
Stefan Bürk uploaded patch set 13
V -109/11/24, 23:46Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 13 V +1 09/11/24, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65510
-
Mathias Bolt Lesniak commented on patch set 13 09/12/24, 08:03
AsciiSlugNormalizer.php:44Unresolved`$slugNormalizerData` should be called `$slugNormalizerOptions` -
Benni Mack commented on patch set 13 03/04/25, 07:14
ping here. What's blocking to make this change in a reviewable state? -
Benni Mack marked it work in progress 03/04/25, 07:14
-
Garvin Hicking uploaded patch set 14
V +107/08/25, 07:37Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 14 V -1 07/08/25, 07:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81462
-
Garvin Hicking uploaded patch set 15
V -107/08/25, 07:52Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Garvin Hicking uploaded patch set 16 07/08/25, 07:53
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 15 V -1 07/08/25, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81466
-
core-ci voted on patch set 16 V -1 07/08/25, 08:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/81467
Feature-104126-AddConfigurationSettingToDefineBackendLockingFile.rst:6