85577[FEATURE] Introduce deployable backend group permission presets
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 65
- Build/Scripts/phpIntegrityChecks/AnnotationChecker.php+3 −1
- Build/Scripts/runTests.sh+1 −1
- typo3/sysext/backend/Classes/Form/FieldInformation/PermissionSetManagedInformation.php2new+46 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowBackendPermission.php2new+102 −0
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/beuser/Classes/Service/UserInformationService.php2+10 −0
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+16 −0
- typo3/sysext/beuser/Resources/Private/Templates/BackendUserGroup/Compare.html+8 −0
- typo3/sysext/core/Classes/Command/PermissionPresetsListCommand.php1new+153 −0
- typo3/sysext/core/Classes/Permission/Provider/Exception/InvalidPermissionSetsProvider.phpnew+35 −0
- typo3/sysext/core/Classes/Permission/Provider/PermissionSetsProviderInterface.phpnew+37 −0
- typo3/sysext/core/Classes/Permission/Provider/YamlPermissionSetsProvider.php4new+155 −0
- typo3/sysext/core/Classes/Permission/Set/Event/RecordPermissionSetApplyEvent.phpnew+106 −0
- typo3/sysext/core/Classes/Permission/Set/EventListener/ApplyPermissionSetsToBackendUserGroups.phpnew+59 −0
- typo3/sysext/core/Classes/Permission/Set/EventListener/BackendUserGroupPermissionSetApplyHandler.phpnew+776 −0
- typo3/sysext/core/Classes/Permission/Set/Exception/PermissionSetCannotBeAppliedForRecordPersistingException.phpnew+30 −0
- typo3/sysext/core/Classes/Permission/Set/Exception/PermissionSetNotFoundException.phpnew+32 −0
- typo3/sysext/core/Classes/Permission/Set/Instructions/BackendPermissionInstruction.phpnew+63 −0
- typo3/sysext/core/Classes/Permission/Set/Instructions/BackendPermissionInstructionFactory.phpnew+332 −0
- typo3/sysext/core/Classes/Permission/Set/Instructions/BackendPermissionInstructionFactoryInterface.php2new+30 −0
Show 45 more files
- typo3/sysext/core/Classes/Permission/Set/Instructions/BackendPermissionInstructionInterface.phpnew+12 −0
- typo3/sysext/core/Classes/Permission/Set/Instructions/GetBackendPermissionInstructionInterface.phpnew+36 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSet.php2new+165 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSetFactory.phpnew+64 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSetFactoryInterface.phpnew+35 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSetInterface.php4new+88 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSetSource.phpnew+114 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSetSourceInterface.phpnew+86 −0
- typo3/sysext/core/Classes/Permission/Set/PermissionSetState.phpnew+54 −0
- typo3/sysext/core/Classes/Permission/TCA/AvailablePermissionSetsItemProc.phpnew+72 −0
- typo3/sysext/core/Classes/Permission/ApplyMode.phpnew+39 −0
- typo3/sysext/core/Classes/Permission/PermissionSetRegistryInfo.phpnew+50 −0
- typo3/sysext/core/Classes/Permission/PermissionSetsRegistry.phpnew+185 −0
- typo3/sysext/core/Classes/Permission/PermissionSetsRegistryInterface.phpnew+61 −0
- typo3/sysext/core/Classes/Permission/RecordPermissionSetsApplyHandler.phpnew+141 −0
- typo3/sysext/core/Classes/Permission/RecordPermissionSetsApplyHandlerInterface.phpnew+56 −0
- typo3/sysext/core/Classes/Permission/RecordPermissionSetsApplyResult.phpnew+47 −0
- typo3/sysext/core/Configuration/TCA/be_groups.php2+12 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+7 −0
- typo3/sysext/core/Configuration/Services.yaml+8 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-104672-IntroduceDeployablePermissionPresets.rstnew+408 −0
- typo3/sysext/core/Resources/Private/Language/locallang_command.xlfnew+38 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+6 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+6 −0
- typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/all_web_modules.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/custom_instructions.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/empty-file.yamlnew+0 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/full-example.yamlnew+57 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/invalid-web-modules.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/invalid.name.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/only-label.yamlnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/settings.yamlnew+7 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/user-module.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/Configuration/PermissionSets/yaml-syntax-error.yamlnew+2 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/composer.jsonnew+14 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_permission_sets/ext_emconf.phpnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_sets/Configuration/PermissionSets/fileadmin-access.yamlnew+3 −0
- typo3/sysext/core/Tests/Functional/Permission/Fixture/permission-sets-test-instance.csvnew+6 −0
- typo3/sysext/core/Tests/Functional/Permission/Fixture/TestPermissionApplyDataHandlerHooks.phpnew+67 −0
- typo3/sysext/core/Tests/Functional/Permission/PermissionSetsContainerTest.phpnew+147 −0
- typo3/sysext/core/Tests/Functional/Permission/RecordPermissionSetsApplyHandlerTest.phpnew+2153 −0
- typo3/sysext/core/Tests/Unit/Permission/Set/Instructions/BackendPermissionInstructionFactoryTest.phpnew+455 −0
- typo3/sysext/dashboard/Classes/EventListener/BackendUserGroupPermissionSetApplyHandler.phpnew+101 −0
- typo3/sysext/workspaces/Classes/EventListener/BackendUserGroupPermissionSetApplyHandler.phpnew+53 −0
Review log 167265
Show 150240 earlier messages
-
Tomek Woldański uploaded patch set 1 08/09/24, 15:22
-
core-ci voted on patch set 1 V -1 08/09/24, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63150
-
Tomek Woldański uploaded patch set 2
V -108/12/24, 14:01 -
core-ci voted on patch set 2 V -1 08/12/24, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63243
-
Tomek Woldański uploaded patch set 3
V -108/12/24, 14:27 -
core-ci voted on patch set 3 V +1 08/12/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63246
-
Tomek Woldański uploaded patch set 4
V +108/13/24, 10:19 -
core-ci voted on patch set 4 V -1 08/13/24, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63292
-
Tomek Woldański uploaded patch set 5
V -108/13/24, 10:28 -
core-ci voted on patch set 5 V -1 08/13/24, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63294
-
Tomek Woldański uploaded patch set 6
V -108/13/24, 10:38 -
core-ci voted on patch set 6 V +1 08/13/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63296
-
Tomek Woldański uploaded patch set 7
V +108/14/24, 13:53 -
Tomek Woldański uploaded patch set 8 08/14/24, 13:57
-
core-ci voted on patch set 7 V -1 08/14/24, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63386
-
core-ci voted on patch set 8 V -1 08/14/24, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63387
-
Tomek Woldański uploaded patch set 9
V -108/14/24, 14:08 -
Tomek Woldański uploaded patch set 10 08/14/24, 14:12
-
core-ci voted on patch set 9 V -1 08/14/24, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63389
-
Tomek Woldański uploaded patch set 11 08/14/24, 14:17
-
core-ci voted on patch set 10 V -1 08/14/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63391
-
Tomek Woldański uploaded patch set 12 08/14/24, 14:22
-
core-ci voted on patch set 11 V -1 08/14/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63393
-
core-ci voted on patch set 12 V +1 08/14/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63394
-
Tomek Woldański uploaded patch set 13
V +108/14/24, 16:52 -
core-ci voted on patch set 13 V +1 08/14/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63396
-
Tomek Woldański uploaded patch set 14
V +108/20/24, 14:45 -
core-ci voted on patch set 14 V -1 08/20/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63839
-
Tomek Woldański uploaded patch set 15
V -108/20/24, 15:09 -
core-ci voted on patch set 15 V -1 08/20/24, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63841
-
Tomek Woldański uploaded patch set 16
V -108/20/24, 15:19 -
core-ci voted on patch set 16 V -1 08/20/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63842
-
Tomek Woldański uploaded patch set 17
V -108/20/24, 15:37 -
core-ci voted on patch set 17 V +1 08/20/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63843
-
Nikita Hovratov commented on patch set 17 08/20/24, 16:28
-
Tomek Woldański uploaded patch set 18
V +108/21/24, 12:56 -
Tomek Woldański commented on patch set 18 08/21/24, 12:59
PermissionSetOverlay.php:137ReplyThx! Done. -
core-ci voted on patch set 18 V +1 08/21/24, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63913
-
Tomek Woldański uploaded patch set 19
V +108/23/24, 14:18 -
core-ci voted on patch set 19 V -1 08/23/24, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64084
-
Tomek Woldański uploaded patch set 20
V -108/26/24, 12:46 -
core-ci voted on patch set 20 V -1 08/26/24, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64200
-
Tomek Woldański uploaded patch set 21
V -108/26/24, 13:10 -
core-ci voted on patch set 21 V -1 08/26/24, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64202
-
Tomek Woldański uploaded patch set 22
V -108/26/24, 14:35 -
core-ci voted on patch set 22 V -1 08/26/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64214
-
Stefan Bürk commented on patch set 23
V -108/26/24, 18:32Published edit on patch set 22. -
core-ci voted on patch set 23 V -1 08/26/24, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64243
-
Tomek Woldański uploaded patch set 24
V -108/27/24, 06:30 -
core-ci voted on patch set 24 V -1 08/27/24, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64269
-
Tomek Woldański uploaded patch set 25
V -108/27/24, 06:45 -
core-ci voted on patch set 25 V +1 08/27/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64271
-
Tomek Woldański uploaded patch set 26
V +108/27/24, 07:28 -
core-ci voted on patch set 26 V -1 08/27/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64275
-
Tomek Woldański uploaded patch set 27
V -108/27/24, 12:59 -
Tomek Woldański rebased onto patch set 28 08/27/24, 13:00
-
core-ci voted on patch set 27 V -1 08/27/24, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64310
-
core-ci voted on patch set 28 V -1 08/27/24, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64311
-
Tomek Woldański uploaded patch set 29
V -108/27/24, 13:11 -
core-ci voted on patch set 29 V -1 08/27/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64312
-
Tomek Woldański rebased onto patch set 30
V -108/27/24, 13:56 -
core-ci voted on patch set 30 V +1 08/27/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64323
-
Benni Mack commented on patch set 30 08/28/24, 11:41
General topic: * Do we want permission sets at user- or group-level?AbstractServiceProvider.php:76don't do absolute namespacing here (unrelated)AbstractServiceProvider.php:95same etc.PermissionSetFileProvider.php:32we should use Services.yaml and tagged iterator instead of TYPO3_CONF_VARS.ext_tables.sql:29I assume we can remove this since TYPO3 v13.0 -
Benni Mack commented on patch set 30 08/28/24, 11:42
PermissionSet.php:34should we use "getIdentifier()" instead?PermissionSetInterface.php:25not sue if we need an interface... just thinking out loud.. .the interface is rather "huge" (and undocumented btw) -
Tomek Woldański uploaded patch set 31
V +108/28/24, 14:54 -
core-ci voted on patch set 31 V -1 08/28/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64428
-
Tomek Woldański commented on patch set 31 08/28/24, 15:24
AbstractServiceProvider.php:76ReplyDoneAbstractServiceProvider.php:95ReplyFixedPermissionSet.php:34ReplyFixed, id field a little weird. Fixed.PermissionSetFileProvider.php:32ReplyI agree, right tagged services are better approach. Done.PermissionSetInterface.php:25ReplyFor flexibility reasons, I added it so you could replace it just in case, but maybe a little overkill it is, or we could streamline `PermissionSetInterface` to be a little more lean API?ext_tables.sql:29ReplyFixed -
Tomek Woldański commented on patch set 31 08/28/24, 15:29
Reply
Group IMHO more flexible & not breaking change, but we should consider both approaches. -
Stefan Bürk commented on patch set 31 CR -2 09/08/24, 09:23
@t.woldanski@macopedia.com thanks for the already great work and time putted into that - alone code wise, but I assume also in pre-planing and making kind of a concept for it (which I miss somehow in the issue). Without going into detail, the class permission set API has the one or other flaw in my eyes and needs to be changed. Beside that, the file provider logic has also flaws and are not that flexible as it may seem. I would take the work over to get this feature finished for 13.3 and doing the work while keeping you as author because of the already great and massive work on that. I thought about commenting all the peaces but I fear that would not be of much help to get that and thus the point with doing the work. I already pinged you on slack to talk about that last week, but got no feedback yet. Still open for it - otherwise I would start working on this on thusday in the morning. Don't get the above as blaming, the goal is to give it the final polish along with going through the failing tests. -
Tomek Woldański rebased onto patch set 32
V -109/09/24, 07:20Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 32 V -1 09/09/24, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65059
-
Tomek Woldański uploaded patch set 33
V -109/09/24, 07:44Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 33 V -1 09/09/24, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65060
-
Frank Nägler commented on patch set 33 09/09/24, 12:35
YamlSetFileProvider.php:32only yaml allowed, what about yml?Feature-104672-DeployablePermissionPresetsForExtensions.rst:102We should provide only "one and only" way, the yaml way. PHP allows to much shit and is not the best way for configuration. SiteSets are also only supports yaml as far as I know. I would opt for removing the PHP way. -
Stefan Bürk commented on patch set 33 CR -2 09/09/24, 13:22
Feature-104672-DeployablePermissionPresetsForExtensions.rst:102ReplyAck. And if someone need it it can be implemented as custom provider. I talked with Tomek about changes, and he will work on them. -
Tomek Woldański uploaded patch set 34
V -109/09/24, 15:31Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Tomek Woldański commented on patch set 34 09/09/24, 15:35
YamlSetFileProvider.php:32ReplyIMHO we should stick to "yaml" convention, to be consistent with Services.yaml/config.yaml files, which T3 already usesFeature-104672-DeployablePermissionPresetsForExtensions.rst:102ReplyI removed PHP implementation for now. -
core-ci voted on patch set 34 V -1 09/09/24, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65110
-
Tomek Woldański uploaded patch set 35
V -109/09/24, 15:45Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Tomek Woldański uploaded patch set 36 09/09/24, 15:50
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 35 V +1 09/09/24, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65111
-
core-ci voted on patch set 36 V +1 09/09/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65113
-
Stefan Bürk uploaded patch set 37
V +109/10/24, 00:32Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 37 V +1 09/10/24, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65157
-
Stefan Bürk updated the commit message in patch set 38
V +109/10/24, 00:55Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 38 V +1 09/10/24, 01:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65158
-
Stefan Bürk uploaded patch set 39
V +109/10/24, 01:00Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 39 V +1 09/10/24, 01:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65159
-
Stefan Bürk uploaded patch set 40
V +109/10/24, 01:21Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 40 V +1 09/10/24, 01:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65161
-
Frank Nägler commented on patch set 40 09/10/24, 07:25
Feature-104672-DeployablePermissionPresetsForExtensions.rst:102Replythanks -
Stefan Bürk commented on patch set 40 CR -2 09/10/24, 09:37
Feature-104672-DeployablePermissionPresetsForExtensions.rst:102ReplyDone -
Tomek Woldański uploaded patch set 41
V +109/10/24, 15:22Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 41 V -1 09/10/24, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65272
-
Tomek Woldański uploaded patch set 42
V -109/10/24, 15:30Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 42 V +1 09/10/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65274
-
Tomek Woldański uploaded patch set 43
V +109/11/24, 08:20Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Tomek Woldański commented on patch set 43 09/11/24, 08:21
Reply
Acknowledged -
core-ci voted on patch set 43 V -1 09/11/24, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65387
-
Michael Schams commented on patch set 43 09/12/24, 05:36
all_web_modules.yaml:40I know this is just a test file. However, the permission reads "recursivedeleteFolder" (lower-case "d"elete). Maybe this comment saves some time if tests fail 😊 -
Tomek Woldański commented on patch set 43 09/12/24, 07:46
all_web_modules.yaml:40Replythx for finding a typo, this permission will be skipped as invalid, I leave it as it, to test scenario. Tests are failing on unrelated changes from the core (I have to wait for decision in other non-related patches to adjust or not adjust tests) -
Stefan Bürk uploaded patch set 44
V -109/12/24, 17:45Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 44 V +1 09/12/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65598
-
Stefan Bürk uploaded patch set 45
V +109/13/24, 12:58Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 45 V -1 09/13/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65677
-
Stefan Bürk uploaded patch set 46
V -109/13/24, 13:11Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Stefan Bürk voted on patch set 46 CR 0 09/13/24, 13:11
-
core-ci voted on patch set 46 V +1 09/13/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65678
-
Stefan Bürk uploaded patch set 47
V +109/13/24, 15:29 -
core-ci voted on patch set 47 V +1 09/13/24, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65695
-
Stefan Bürk commented on patch set 47 09/14/24, 00:10
PermissionSetInterface.php:25ReplyYes. We can think about having a small/reduced one and this one, and the core default permissionset uses this variant. We can keep the "simple" interface for method type hinting, but check against the interface and skip the default core record apply here https://review.typo3.org/c/Packages/TYPO3.CMS/+/85577/47/typo3/sysext/core/Classes/Permission/Set/BackendUserGroupPermissionSetApplier.php#73 but still dispatch the event than (doing literally nothing without the concrete richer interface. In the end, we could have interfaces for each "method" and extension authors implementing custom provider / schema / permission sets can "compose" the custom permission set when to use the core implementation and when to fallback to custom implementation - but that would blow up the whole api even more. Documenting the API is already a little challenge and it would not get better. Thinking about that, a meta and a second complete interface like this one would be a good start. That way, we could later extract single methods in dedicated interfaces (v14) if needed, composing the "fullblown" intefcace by extending the extracted interfaces and later deprecate (v14) and remove (v15) it. What do you think @benni@typo3.org ? -
Stefan Bürk uploaded patch set 48
V +109/14/24, 17:09 -
core-ci voted on patch set 48 V -1 09/14/24, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65764
-
Stefan Bürk uploaded patch set 49
V -109/15/24, 16:21 -
core-ci voted on patch set 49 V +1 09/15/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65818
-
Stefan Bürk uploaded patch set 50
V +109/15/24, 19:04 -
core-ci voted on patch set 50 V -1 09/15/24, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65822
-
Benni Mack commented on patch set 50 09/16/24, 05:06
GroupResolver.php:46any reason not to use the AfterGroupesResolvedEvent? If we use the Event, this actually decouples two separate pieces of code from each other properly. -
Stefan Bürk commented on patch set 50 09/16/24, 07:09
GroupResolver.php:46ReplyGood point, missed that. Will add a eventlistener for that event and do the apply stuff there. -
Stefan Bürk uploaded patch set 51
V -109/16/24, 08:01 -
Stefan Bürk commented on patch set 51 09/16/24, 08:02
GroupResolver.php:46ReplyDone -
core-ci voted on patch set 51 V +1 09/16/24, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65860
-
Stefan Bürk uploaded patch set 52
V +109/16/24, 09:20 -
core-ci voted on patch set 52 V +1 09/16/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65864
-
Stefan Bürk uploaded patch set 53
V +109/16/24, 10:00 -
core-ci voted on patch set 53 V +1 09/16/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65872
-
Tomek Woldański commented on patch set 53 09/16/24, 12:25
PermissionSetsContainer.php:138We should also check PermissionsState -
Stefan Bürk commented on patch set 53 09/16/24, 12:28
PermissionSetsContainer.php:138ReplyNot here. They should be added. The reasoning behind this is to have them in cache and for a future backend module to display all sets (and states) it would be not good to drop them here. But you are right, it needs to be checked for formengine apply and TCA select items thingy. -
Tomek Woldański commented on patch set 53 09/16/24, 12:30
PermissionSetsContainer.php:138ReplyI see, makes sense. In this case check should be in other place. -
Stefan Bürk uploaded patch set 54
V +109/16/24, 13:22 -
Stefan Bürk commented on patch set 54 09/16/24, 13:24
Example permission preset: https://gist.github.com/sbuerk/14a7a8f8a1c05b99ff7c999a23fd988e which can be used and put in `typo3conf/permission-sets/` or adding custom presets. -
core-ci voted on patch set 54 V +1 09/16/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65889
-
Stefan Bürk uploaded patch set 55
V +109/16/24, 13:42 -
core-ci voted on patch set 55 V +1 09/16/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65893
-
Tomek Woldański voted on patch set 55 CR +1 V +1 09/16/24, 14:14
-
Garvin Hicking updated the commit message in patch set 56
CR +1V +109/16/24, 15:38 -
core-ci voted on patch set 56 V +1 09/16/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65904
-
Anja Leichsenring updated the commit message in patch set 57
V +109/16/24, 15:59 -
Garvin Hicking commented on patch set 58 09/16/24, 16:10
Published edit on patch set 57. -
core-ci voted on patch set 57 V +1 09/16/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65907
-
Garvin Hicking commented on patch set 58 09/16/24, 16:17
Feature-104672-IntroduceDeployablePermissionPresets.rst:94what is a schema in this context?Feature-104672-IntroduceDeployablePermissionPresets.rst:101what does "removing the module" meanFeature-104672-IntroduceDeployablePermissionPresets.rst:106are these page uids or site identifiers?Feature-104672-IntroduceDeployablePermissionPresets.rst:136What does that mean, how can it be "provided"?Feature-104672-IntroduceDeployablePermissionPresets.rst:142What does this mean, EB? -
core-ci voted on patch set 58 V +1 09/16/24, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65909
-
Tomek Woldański commented on patch set 58 09/16/24, 16:35
Feature-104672-IntroduceDeployablePermissionPresets.rst:94ReplyYou can have multiple schemas (format of for example yaml file)Feature-104672-IntroduceDeployablePermissionPresets.rst:101ReplyDo not provide permission for it (permission is not set)Feature-104672-IntroduceDeployablePermissionPresets.rst:106ReplyBoth (you can use root page ID or site identifiers)Feature-104672-IntroduceDeployablePermissionPresets.rst:136ReplyGood catch, you should use locales only in current implementationFeature-104672-IntroduceDeployablePermissionPresets.rst:142Reply -
Tomek Woldański uploaded patch set 59
V +109/16/24, 17:05 -
Tomek Woldański commented on patch set 58 09/16/24, 17:06
Feature-104672-IntroduceDeployablePermissionPresets.rst:94Replyadded additional infoFeature-104672-IntroduceDeployablePermissionPresets.rst:101Replyclarify it RSTFeature-104672-IntroduceDeployablePermissionPresets.rst:136Replyfixed -
Stefan Bürk uploaded patch set 60 09/16/24, 17:15
-
Stefan Bürk commented on patch set 60 09/16/24, 17:18
Feature-104672-IntroduceDeployablePermissionPresets.rst:94Replyleft over, should not be in that example.Feature-104672-IntroduceDeployablePermissionPresets.rst:101Reply``` media_management: false ``` would not make sense - if the db record has it or another preset defines it, it will not be removed. Literally it is the does the same (nothing) like having it not written at all. Will adjust the comment in the example. done.Feature-104672-IntroduceDeployablePermissionPresets.rst:136ReplyThe can also be provided manually slipped in there by accident, was meant as anser on slack :blush: -
core-ci voted on patch set 59 V +1 09/16/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65914
-
Stefan Bürk updated the commit message in patch set 61 09/16/24, 17:21
-
core-ci voted on patch set 61 V +1 09/16/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65917
-
Tomek Woldański voted on patch set 61 CR +1 V +1 09/16/24, 17:27
-
core-ci voted on patch set 60 V -1 09/16/24, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65916
-
Stefan Bürk commented on patch set 61 09/16/24, 17:40
Reply
I guess user level may be doable, however for the dynamic variant there is no real suitable event available - at least for a direct core implementation. A extension can later use this permission base and make the addition for be_user with some quirks. We can talk about that benni. Resolving this for because I guess we would not get these changes for be_users in in the remaining time frame.YamlSetFileProvider.php:32ReplyLet's stay with one ending to avoid confusing. If someone really want they can copy&paste the YamlSetFileProvider to an extension and change that to custom file extension with a simple php attribute and it would kickin beside the core variant. Provider does not work like the point that remark was made. Resolving this for now.PermissionSetInterface.php:25ReplyDone -
Anja Leichsenring voted on patch set 61 CR +1 V +1 09/16/24, 17:41
-
core-ci voted on patch set 60 V +1 09/16/24, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65916
-
Garvin Hicking commented on patch set 61 09/16/24, 18:09
PermissionSetsInformation.html:40missin l10n -
Stefan Bürk commented on patch set 61 CR -1 09/16/24, 18:17
on it .... -
Stefan Bürk uploaded patch set 62
CR +1V +109/16/24, 18:21 -
Stefan Bürk commented on patch set 62 09/16/24, 18:21
Reply
DonePermissionSetsInformation.html:40ReplyDone -
Anja Leichsenring voted on patch set 62 CR +1 V +1 09/16/24, 18:23
-
core-ci voted on patch set 62 V +1 09/16/24, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65918
-
Oli Bartsch commented on patch set 62 09/16/24, 21:43
I had just a quick look and added some comments. At first sight, the feature looks promising while the added code and abstraction is quite huge. I'm very sceptical about adding such a big change hours before FF. However, I won't block this for now.OuterWrapContainer.php:172This special handling which applies **only** for be_groups should IMO not be added to the general OuterWrapContainer. Besides adding unrelated code here, it breaks the current UI and leads to inconsistence. We are actually about to make FormEngine more consistent, e.g. by automatically generating showitem (see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85859). Introducing such special UI counteracts this.PermissionSetsInformation.html:42For me, selecting a set and saving the record leads to the set being selected after reload but it is not getting stored in the database.PermissionSetsInformation.html:52What is this view for, since the selected sets are visible in the record itself already?PermissionSetNotExistException.php:27This should implement Psr\Container\NotFoundExceptionInterfaceRecordPermissionSetApplier.php:53This would add a hard dependencies to EXT:dashboardRecordPermissionSetApplier.php:395We might want to use TcaSchema here.InvalidPermissionSetSchemaException.php:21Resolve todo?InvalidSchemaException.php:21Resolve todo?AvailablePermissionSetsItemProc.php:76This is not necessary. ->sL() handles this. However, IMO the whole method is not necessary since translation is done by the TcaSelectItems data provider.AvailablePermissionSetsItemProc.php:77If used, please always encapsulate $GLOBALS into methods, making replacement easier in the future. -
Benni Mack commented on patch set 62 CR -2 09/16/24, 21:54
I think we need to clean a few things up, let's rather sort this out properly instead of rushing it in, as a possible exception for Feature Freeze. - Avoid pollution of OuterWrapContainer - Ensure that we show proper message above each field that permission sets alters this value (e.g. via fieldInformation https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/FieldInformation.html) - thus, ensure that this is not going to be persisted via DataHandler hook -
Benni Mack voted on patch set 62 CR -1 09/18/24, 06:16
-
Michael Schams wrote 09/18/24, 06:34
Removed cc Michael Schams. -
Stefan Bürk updated the commit message in patch set 63
CR +1V +109/18/24, 07:22 -
Stefan Bürk voted on patch set 63 CR -1 09/18/24, 07:22
-
core-ci voted on patch set 63 V +1 09/18/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66104
-
Stefan Bürk voted on patch set 63 CR -2 09/26/24, 09:33
-
Stefan Bürk uploaded patch set 64
V +110/04/24, 16:00Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 64 V +1 10/04/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67107
-
Stefan Bürk uploaded patch set 65
V +110/05/24, 00:36Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Stefan Bürk uploaded patch set 66 10/05/24, 00:49
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 66 V +1 10/05/24, 01:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67116
-
core-ci voted on patch set 65 V -1 10/05/24, 01:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67115
-
Stefan Bürk uploaded patch set 67
V +110/05/24, 13:04Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Stefan Bürk uploaded patch set 68 10/05/24, 13:19
Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 67 V +1 10/05/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67153
-
core-ci voted on patch set 68 V +1 10/05/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67155
-
Stefan Bürk uploaded patch set 69
V +110/06/24, 19:22Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 69 V -1 10/06/24, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67190
-
Stefan Bürk uploaded patch set 70
V -110/06/24, 21:01Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 70 V +1 10/06/24, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67191
-
Stefan Bürk rebased onto patch set 71
V +110/07/24, 20:28Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 71 V +1 10/07/24, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67289
-
Stefan Bürk uploaded patch set 72
V +110/09/24, 00:36Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 72 V +1 10/09/24, 00:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67399
-
Stefan Bürk uploaded patch set 73
V +110/09/24, 08:54Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
core-ci voted on patch set 73 V +1 10/09/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67425
-
Stefan Bürk voted on patch set 73 CR 0 10/09/24, 09:20
-
Stefan Bürk commented on patch set 73 10/09/24, 09:38
Reply
Reduced the PHP api and cutted out parts.OuterWrapContainer.php:172ReplyRemoved and solved by using a new `fieldInformation`.PermissionSetsInformation.html:42ReplyOriginally, this change provided 2 modes. Sets which are applied during the group resolving (not perssted) and by applying it directly to the record. After discussing this with Benni and lolli (multiple) times, the feature is reduced to the "on-the-fly" apply only. Thus, when presets are now selected (and saved), managed fields are marked as read-only, values cleared and a fieldInformation added to managed fields along with displaying all applied permission for managed fields of selected presets (aka preview directly in the edit form).PermissionSetsInformation.html:52ReplyRemoved. Partly dropped, rest solved with field fieldInformation.PermissionSetNotExistException.php:27ReplyThanks for mention that, done.RecordPermissionSetApplier.php:53ReplyGood point. I solved this by adding a event listener for the dispatched event to `EXT:dashboard`, and also to `EXT:workspaces` to handle permission apply requiring these system extensions to be installed in the event listener. That should solve the `dependency of extension within the core` issue cycle. Thanks for mention that point ❤️RecordPermissionSetApplier.php:395ReplyAck. Done, albeit code has changed. But all tca related places should now use TcaSchema and not the global anymore.InvalidPermissionSetSchemaException.php:21ReplyThis exception clas has been removed meanwhile, along witht eh whole schema part of the php-api as part of reducing it.InvalidSchemaException.php:21ReplyThis exception clas has been removed meanwhile, along witht eh whole schema part of the php-api as part of reducing it.AvailablePermissionSetsItemProc.php:76ReplyAck. Removed method and not doing translation here at all.AvailablePermissionSetsItemProc.php:77ReplyRemoved. -
Stefan Bürk commented on patch set 73 10/09/24, 09:51
Reply
Updated gist to contain example with adoption of changed syntax. See also the rest file. Additionally, added a preset with invalid yaml syntax to the gist to see the difference in the cli command. -
Stefan Bürk uploaded patch set 74
V +110/09/24, 09:52 -
core-ci voted on patch set 74 V +1 10/09/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67435
-
Stefan Bürk commented on patch set 74 10/09/24, 14:04
Reply
Done -
Tomek Woldański uploaded patch set 75
V +110/09/24, 14:40 -
core-ci voted on patch set 75 V +1 10/09/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67454
-
Tomek Woldański uploaded patch set 76
V +110/09/24, 15:30 -
core-ci voted on patch set 76 V -1 10/09/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67455
-
Tomek Woldański uploaded patch set 77
V -110/09/24, 16:11 -
core-ci voted on patch set 77 V -1 10/09/24, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67457
-
Garvin Hicking commented on patch set 77 10/09/24, 20:38
few minor changelog comments (can patch myself tomorrow, and finish the rest)Feature-104672-IntroduceDeployablePermissionPresets.rst:55": yaml" > ":yaml"Feature-104672-IntroduceDeployablePermissionPresets.rst:55"mointpoints" -> "mountpoints"Feature-104672-IntroduceDeployablePermissionPresets.rst:66"provided to provide" just "provides"Feature-104672-IntroduceDeployablePermissionPresets.rst:74"could display the following output for example": -
Stefan Bürk commented on patch set 77 CR -1 10/10/24, 07:15
on it .. -
Tomek Woldański uploaded patch set 78
CR -1V -110/10/24, 13:16 -
Tomek Woldański commented on patch set 77 10/10/24, 13:16
Feature-104672-IntroduceDeployablePermissionPresets.rst:55ReplyDoneFeature-104672-IntroduceDeployablePermissionPresets.rst:55ReplyDoneFeature-104672-IntroduceDeployablePermissionPresets.rst:66ReplyDoneFeature-104672-IntroduceDeployablePermissionPresets.rst:74ReplyDone -
Tomek Woldański commented on patch set 78 10/10/24, 13:17
Reply
Done & small fix for PHPStan -
core-ci voted on patch set 78 V +1 10/10/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67511
-
Tomek Woldański commented on patch set 78 10/10/24, 13:23
Reply
Done -
Stefan Bürk commented on patch set 78 CR -1 10/10/24, 13:30
on it - please do not push on it as I will override intermediate chagnes -
Stefan Bürk uploaded patch set 79
CR -1V +110/10/24, 16:20 -
Stefan Bürk voted on patch set 79 CR -1 10/10/24, 16:21
-
Nikita Hovratov wrote 10/10/24, 16:25
Removed cc Nikita Hovratov. -
core-ci voted on patch set 79 V -1 10/10/24, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67518
-
Stefan Bürk uploaded patch set 80
CR -1V -110/10/24, 16:29 -
core-ci voted on patch set 80 V +1 10/10/24, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67519
-
Stefan Bürk uploaded patch set 81
V +110/10/24, 19:00 -
core-ci voted on patch set 81 V -1 10/10/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67533
-
Stefan Bürk uploaded patch set 82
V -110/10/24, 19:07 -
core-ci voted on patch set 82 V +1 10/10/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67534
-
Garvin Hicking commented on patch set 82 CR -1 10/10/24, 20:12
on it to push documentation related changes -
Garvin Hicking uploaded patch set 83
CR -1V +110/10/24, 20:22Adjust ReST file and commit message -
core-ci voted on patch set 83 V +1 10/10/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67536
-
Garvin Hicking uploaded patch set 84
V +110/10/24, 20:34Adjust user facing formengine hints -
core-ci voted on patch set 84 V +1 10/10/24, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67537
-
Garvin Hicking uploaded patch set 85
V +110/10/24, 20:46Adjust rendering addendum -
core-ci voted on patch set 85 V +1 10/10/24, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67538
-
Garvin Hicking commented on patch set 85 10/10/24, 21:11
PermissionSetManagedInformation.php:25@internal?DatabaseRowBackendPermission.php:28@internal classification?BackendPermissionPresetsDataHandler.php:47leftover?InvalidPermissionSetsProvider.php:33@internal?YamlPermissionSetsProvider.php:95maybe ~ and + as some more characters that people sometimes use? Otherwise we should probably document in the changelog that it's not "*.yaml" but a "*.yaml without special characters other than dash and underscore"?GetBackendPermissionInstructionTrait.php:28@internal? -
Stefan Bürk uploaded patch set 86
V +110/11/24, 09:59 -
Stefan Bürk commented on patch set 86 10/11/24, 09:59
PermissionSetManagedInformation.php:25ReplyDoneDatabaseRowBackendPermission.php:28ReplyDoneBackendPermissionPresetsDataHandler.php:47Replyyip, thanks. Removed.InvalidPermissionSetsProvider.php:33ReplyDoneYamlPermissionSetsProvider.php:95Replywill think about it, but tilde looks weired. The goal behind that was to get clean structured names which also makes sense to be used as part of the set identifier, in the backend selection and so forth. But ack, should at least be documented - had that original in mind but during the rest file rewrite it passed away.GetBackendPermissionInstructionTrait.php:28ReplyDone -
Tomek Woldański commented on patch set 86 10/11/24, 10:05
Reply
Acknowledged -
core-ci voted on patch set 86 V +1 10/11/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67583
-
Oli Bartsch uploaded patch set 87
V +110/11/24, 13:33 -
core-ci voted on patch set 87 V -1 10/11/24, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67600
-
Oli Bartsch uploaded patch set 88
V -110/11/24, 21:32 -
core-ci voted on patch set 88 V -1 10/11/24, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67622
-
Stefan Bürk commented on patch set 88 CR -1 10/13/24, 17:51
on it ... -
Stefan Bürk uploaded patch set 89
CR -1V -110/14/24, 03:08 -
core-ci voted on patch set 89 V +1 10/14/24, 03:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67720
-
Stefan Bürk commented on patch set 89 10/14/24, 03:18
Reply
DoneYamlPermissionSetsProvider.php:95ReplyAdded the pattern to the documentation, decided against `~` and `+` - mainly to avoid eventually url encoding issues if used as url argument at some point. It's better to use `-` or `_` as separator characts anyway and the more commonly used replacement for spaces or separator. At least for dinosaurs 😊 -
Stefan Bürk commented on patch set 89 10/14/24, 03:19
YamlPermissionSetsProvider.php:95ReplyDone
-
Stefan Bürk commented on patch set 89 10/14/24, 03:24
UserInformationService.php:58Should we also add the set state ? (valid, error/loading error) ? -
Stefan Bürk uploaded patch set 90
V +110/14/24, 03:36 -
core-ci voted on patch set 90 V +1 10/14/24, 03:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67721
-
Oli Bartsch uploaded patch set 91
V +110/14/24, 10:23 -
core-ci voted on patch set 91 V -1 10/14/24, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67749
-
Oli Bartsch uploaded patch set 92
V -110/14/24, 10:46 -
Oli Bartsch commented on patch set 92 10/14/24, 10:47
UserInformationService.php:58ReplyLet's keep it simple for now. Maybe in a next step. -
core-ci voted on patch set 92 V +1 10/14/24, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67750
-
Benni Mack commented on patch set 92 10/14/24, 11:34
GroupResolver.php:47IMHO unrelated, let's leave this change out pleasePermissionSetsContainer.php:43should be named "Registry" right?InvalidPermissionSetsProvider.php:18I don't know if we ever use "Exceptions" has namespace? Can you recheck. Also, "InvalidPermissionSetsProvider" should be named "InvalidPermissionSetsProviderException" IMHO.BackendPermissionInstructionFactoryInterface.php:29I'd rather get rid of this interface for the time being. Why? The factory has an interface, but the implementation doesn't.GetBackendPermissionInstructionTrait.php:30This looks like a strange piece of code... do we really need this in the current state of work, or just keep it "simple"?MethodTraitClassImplementsInterfacesTrait.php:28This looks like a strange piece of code... do we really need this in the current state of work, or just keep it "simple"?be_groups.php:272I think we can live without the palette. -
Oli Bartsch commented on patch set 92 V -1 10/14/24, 11:36
on it .. -
Benni Mack commented on patch set 92 10/14/24, 12:41
PermissionPresetsListCommand.php:36UnresolvedI fail to understand the usefulness of this CLI command. What does "loaded" in this regard mean? Loaded = available in the system or loaded for a usergroup? Also, what does "Check against table" really mean? I mean, the most interesting part - when using deployable permissions - is to understand "Hey, this user actually has these 12 permissions, which come from these 5 permission sets which have been selected in these 3 groups" -
Stefan Bürk commented on patch set 92 10/14/24, 13:06
GroupResolver.php:47ReplyLeft over - original a additional event was dispatched. So yeah, let's revert that unrelated change.PermissionSetsContainer.php:43Reply UnresolvedDon't want to discuss naming here, in my eyes now. A registry allows to add/remove things during runtime, this does not. But as Registry has been used already for other similar things, fine to rename.InvalidPermissionSetsProvider.php:18Reply UnresolvedShould be `Exception/`. Fine to add Exception in the end.BackendPermissionInstructionFactoryInterface.php:29Reply UnresolvedLet's drop it.GetBackendPermissionInstructionTrait.php:30Reply UnresolvedNot really, let's drop it.MethodTraitClassImplementsInterfacesTrait.php:28Reply UnresolvedLet's drop it. -
Oli Bartsch uploaded patch set 93
V +110/14/24, 14:17 -
core-ci voted on patch set 93 V -1 10/14/24, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67762
-
Oli Bartsch uploaded patch set 94
V -110/14/24, 14:27 -
Oli Bartsch commented on patch set 94 10/14/24, 14:28
GroupResolver.php:47ReplyDonebe_groups.php:272ReplyDone -
core-ci voted on patch set 94 V +1 10/14/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67763
-
Oli Bartsch uploaded patch set 95
V +105/23/25, 09:42 -
core-ci voted on patch set 95 V -1 05/23/25, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79416
-
Tomek Woldański uploaded patch set 96
V -109/01/25, 10:10 -
core-ci voted on patch set 96 V -1 09/01/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84136
-
Tomek Woldański uploaded patch set 97
V -109/01/25, 10:25 -
core-ci voted on patch set 97 V -1 09/01/25, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84137
-
Benni Mack wrote 04/21/26, 15:01
Removed reviewer Benni Mack. -
Benni Mack abandoned the change 11/10/26, 13:35
no activity for over a year, I will abandon this change now. It can be re-isntantiated later-on
PermissionSetOverlay.php:137