Review main Abandoned

85577[FEATURE] Introduce deployable backend group permission presets

Tomek Woldański CR 0 V -1 Nightmare +6887 −3 updated 11/10/26, 13:35

Commit message

Handling of content management permissions for large
site(s) can be a little cumbersome and take some time
and effort due to the need of using a GUI for it.

Permission presets are the key to simplify this maintenance
task and make the process faster and easier. Defined and
selectable permission presets can be used to compose
permissions on a backend usergroup level.

File-based permission presets allow to add, revoke and
modify presets as part of project deployment strategies.
Further, extension authors can now provide permission
presets within the extension, which can be used to
kickstart the usage of the extension. Or they can be
used as examples to compose own custom presets.

The main audience for this feature are integrators and
instance maintainers/administrators, but also targets
for extension authors.

* Maintainers can now create fine granular presets to
  compose backend user group permissions by selecting
  one or more presets for a group in a deployable way
  and commit these files to a version-controlled
  repository.

* Extension authors are now able to provide permission
  presets containing only provided features of their
  extension, either as example, quick start or to be
  used as templates for instance maintainers. Besides
  that, it could also be used as part of the extension
  to feature and document its configuration.

To achieve this goal, this feature introduces the ability
to provide `yaml` files within extensions or on instance
system level in following places:

* extension           : Configuration/PermissionSets/*.yaml
* system composer-mode: config/permission-sets/*.yaml
* system legacy-mode` : typo3conf/permission-sets/*.yaml

`\TYPO3\CMS\Core\Permission\Provider\YamlPermissionSetsProvider`
finds and loads permission presets provided in the mentioned
places.

One or more permission presets can be selected for backend user
groups (`permission_sets`), which (when applied) clear and prevent
persisting managed fields using the introduced DataHandler hook class
`\TYPO3\CMS\Core\Permission\Hooks\BackendPermissionPresetsDataHandler`.

Permission presets are applied within the backend user authentication
process listening to the event `AfterGroupsResolvedEvent`.
This is dispatched in the corresponding method
`\TYPO3\CMS\Core\Authentication\GroupResolver::resolveGroupsForUser()`.

Values are also applied and displayed in the backend UI when editing
a backend user group record in read-only state and show additional
field information to achieve user awareness.

Note that this change also introduces a PHP-API for handling permission
presets along with a new PSR-14 event (@internal) and highly
experimental.

TYPO3 v14 will modify and extend this API to add additional features on
top, which could otherwise require breaking changes (which needs to
be prevented). Thus, the PHP-API is not a public-facing part of this
feature and for internal use only. It is built with modern approaches
in mind to be extendable in the future.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 65

Show 45 more files

Review log 167265

Show 150240 earlier messages
  1. Tomek Woldański uploaded patch set 1 08/09/24, 15:22

  2. core-ci voted on patch set 1 V -1 08/09/24, 15:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63150

  3. Tomek Woldański uploaded patch set 2 V -1 08/12/24, 14:01

  4. core-ci voted on patch set 2 V -1 08/12/24, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63243

  5. Tomek Woldański uploaded patch set 3 V -1 08/12/24, 14:27

  6. core-ci voted on patch set 3 V +1 08/12/24, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63246

  7. Tomek Woldański uploaded patch set 4 V +1 08/13/24, 10:19

  8. core-ci voted on patch set 4 V -1 08/13/24, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63292

  9. Tomek Woldański uploaded patch set 5 V -1 08/13/24, 10:28

  10. core-ci voted on patch set 5 V -1 08/13/24, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63294

  11. Tomek Woldański uploaded patch set 6 V -1 08/13/24, 10:38

  12. core-ci voted on patch set 6 V +1 08/13/24, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63296

  13. Tomek Woldański uploaded patch set 7 V +1 08/14/24, 13:53

  14. Tomek Woldański uploaded patch set 8 08/14/24, 13:57

  15. core-ci voted on patch set 7 V -1 08/14/24, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63386

  16. core-ci voted on patch set 8 V -1 08/14/24, 14:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63387

  17. Tomek Woldański uploaded patch set 9 V -1 08/14/24, 14:08

  18. Tomek Woldański uploaded patch set 10 08/14/24, 14:12

  19. core-ci voted on patch set 9 V -1 08/14/24, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63389

  20. Tomek Woldański uploaded patch set 11 08/14/24, 14:17

  21. core-ci voted on patch set 10 V -1 08/14/24, 14:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63391

  22. Tomek Woldański uploaded patch set 12 08/14/24, 14:22

  23. core-ci voted on patch set 11 V -1 08/14/24, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63393

  24. core-ci voted on patch set 12 V +1 08/14/24, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63394

  25. Tomek Woldański uploaded patch set 13 V +1 08/14/24, 16:52

  26. core-ci voted on patch set 13 V +1 08/14/24, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63396

  27. Tomek Woldański uploaded patch set 14 V +1 08/20/24, 14:45

  28. core-ci voted on patch set 14 V -1 08/20/24, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63839

  29. Tomek Woldański uploaded patch set 15 V -1 08/20/24, 15:09

  30. core-ci voted on patch set 15 V -1 08/20/24, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63841

  31. Tomek Woldański uploaded patch set 16 V -1 08/20/24, 15:19

  32. core-ci voted on patch set 16 V -1 08/20/24, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63842

  33. Tomek Woldański uploaded patch set 17 V -1 08/20/24, 15:37

  34. core-ci voted on patch set 17 V +1 08/20/24, 15:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63843

  35. Nikita Hovratov commented on patch set 17 08/20/24, 16:28

    PermissionSetOverlay.php:137

    You can now use the TcaSchema for that :)
  36. Tomek Woldański uploaded patch set 18 V +1 08/21/24, 12:56

  37. Tomek Woldański commented on patch set 18 08/21/24, 12:59

    PermissionSetOverlay.php:137 Reply

    Thx! Done.
  38. core-ci voted on patch set 18 V +1 08/21/24, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63913

  39. Tomek Woldański uploaded patch set 19 V +1 08/23/24, 14:18

  40. core-ci voted on patch set 19 V -1 08/23/24, 14:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64084

  41. Tomek Woldański uploaded patch set 20 V -1 08/26/24, 12:46

  42. core-ci voted on patch set 20 V -1 08/26/24, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64200

  43. Tomek Woldański uploaded patch set 21 V -1 08/26/24, 13:10

  44. core-ci voted on patch set 21 V -1 08/26/24, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64202

  45. Tomek Woldański uploaded patch set 22 V -1 08/26/24, 14:35

  46. core-ci voted on patch set 22 V -1 08/26/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64214

  47. Stefan Bürk commented on patch set 23 V -1 08/26/24, 18:32

    Published edit on patch set 22.
  48. core-ci voted on patch set 23 V -1 08/26/24, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64243

  49. Tomek Woldański uploaded patch set 24 V -1 08/27/24, 06:30

  50. core-ci voted on patch set 24 V -1 08/27/24, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64269

  51. Tomek Woldański uploaded patch set 25 V -1 08/27/24, 06:45

  52. core-ci voted on patch set 25 V +1 08/27/24, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64271

  53. Tomek Woldański uploaded patch set 26 V +1 08/27/24, 07:28

  54. core-ci voted on patch set 26 V -1 08/27/24, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64275

  55. Tomek Woldański uploaded patch set 27 V -1 08/27/24, 12:59

  56. Tomek Woldański rebased onto patch set 28 08/27/24, 13:00

  57. core-ci voted on patch set 27 V -1 08/27/24, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64310

  58. core-ci voted on patch set 28 V -1 08/27/24, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64311

  59. Tomek Woldański uploaded patch set 29 V -1 08/27/24, 13:11

  60. core-ci voted on patch set 29 V -1 08/27/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64312

  61. Tomek Woldański rebased onto patch set 30 V -1 08/27/24, 13:56

  62. core-ci voted on patch set 30 V +1 08/27/24, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64323

  63. Benni Mack commented on patch set 30 08/28/24, 11:41

    General topic: * Do we want permission sets at user- or group-level?

    AbstractServiceProvider.php:76

    don't do absolute namespacing here (unrelated)

    AbstractServiceProvider.php:95

    same etc.

    PermissionSetFileProvider.php:32

    we should use Services.yaml and tagged iterator instead of TYPO3_CONF_VARS.

    ext_tables.sql:29

    I assume we can remove this since TYPO3 v13.0
  64. Benni Mack commented on patch set 30 08/28/24, 11:42

    PermissionSet.php:34

    should we use "getIdentifier()" instead?

    PermissionSetInterface.php:25

    not sue if we need an interface... just thinking out loud.. .the interface is rather "huge" (and undocumented btw)
  65. Tomek Woldański uploaded patch set 31 V +1 08/28/24, 14:54

  66. core-ci voted on patch set 31 V -1 08/28/24, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/64428

  67. Tomek Woldański commented on patch set 31 08/28/24, 15:24

    AbstractServiceProvider.php:76 Reply

    Done

    AbstractServiceProvider.php:95 Reply

    Fixed

    PermissionSet.php:34 Reply

    Fixed, id field a little weird. Fixed.

    PermissionSetFileProvider.php:32 Reply

    I agree, right tagged services are better approach. Done.

    PermissionSetInterface.php:25 Reply

    For flexibility reasons, I added it so you could replace it just in case, but maybe a little overkill it is, or we could streamline `PermissionSetInterface` to be a little more lean API?

    ext_tables.sql:29 Reply

    Fixed
  68. Tomek Woldański commented on patch set 31 08/28/24, 15:29

    Reply

    Group IMHO more flexible & not breaking change, but we should consider both approaches.
  69. Stefan Bürk commented on patch set 31 CR -2 09/08/24, 09:23

    @t.woldanski@macopedia.com thanks for the already great work and time putted into that - alone code wise, but I assume also in pre-planing and making kind of a concept for it (which I miss somehow in the issue). Without going into detail, the class permission set API has the one or other flaw in my eyes and needs to be changed. Beside that, the file provider logic has also flaws and are not that flexible as it may seem. I would take the work over to get this feature finished for 13.3 and doing the work while keeping you as author because of the already great and massive work on that. I thought about commenting all the peaces but I fear that would not be of much help to get that and thus the point with doing the work. I already pinged you on slack to talk about that last week, but got no feedback yet. Still open for it - otherwise I would start working on this on thusday in the morning. Don't get the above as blaming, the goal is to give it the final polish along with going through the failing tests.
  70. Tomek Woldański rebased onto patch set 32 V -1 09/09/24, 07:20

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  71. core-ci voted on patch set 32 V -1 09/09/24, 07:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65059

  72. Tomek Woldański uploaded patch set 33 V -1 09/09/24, 07:44

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  73. core-ci voted on patch set 33 V -1 09/09/24, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65060

  74. Frank Nägler commented on patch set 33 09/09/24, 12:35

    YamlSetFileProvider.php:32

    only yaml allowed, what about yml?

    Feature-104672-DeployablePermissionPresetsForExtensions.rst:102

    We should provide only "one and only" way, the yaml way. PHP allows to much shit and is not the best way for configuration. SiteSets are also only supports yaml as far as I know. I would opt for removing the PHP way.
  75. Stefan Bürk commented on patch set 33 CR -2 09/09/24, 13:22

    Feature-104672-DeployablePermissionPresetsForExtensions.rst:102 Reply

    Ack. And if someone need it it can be implemented as custom provider. I talked with Tomek about changes, and he will work on them.
  76. Tomek Woldański uploaded patch set 34 V -1 09/09/24, 15:31

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  77. Tomek Woldański commented on patch set 34 09/09/24, 15:35

    YamlSetFileProvider.php:32 Reply

    IMHO we should stick to "yaml" convention, to be consistent with Services.yaml/config.yaml files, which T3 already uses

    Feature-104672-DeployablePermissionPresetsForExtensions.rst:102 Reply

    I removed PHP implementation for now.
  78. core-ci voted on patch set 34 V -1 09/09/24, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65110

  79. Tomek Woldański uploaded patch set 35 V -1 09/09/24, 15:45

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  80. Tomek Woldański uploaded patch set 36 09/09/24, 15:50

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  81. core-ci voted on patch set 35 V +1 09/09/24, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65111

  82. core-ci voted on patch set 36 V +1 09/09/24, 16:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65113

  83. Stefan Bürk uploaded patch set 37 V +1 09/10/24, 00:32

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  84. core-ci voted on patch set 37 V +1 09/10/24, 00:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65157

  85. Stefan Bürk updated the commit message in patch set 38 V +1 09/10/24, 00:55

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  86. core-ci voted on patch set 38 V +1 09/10/24, 01:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65158

  87. Stefan Bürk uploaded patch set 39 V +1 09/10/24, 01:00

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  88. core-ci voted on patch set 39 V +1 09/10/24, 01:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65159

  89. Stefan Bürk uploaded patch set 40 V +1 09/10/24, 01:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  90. core-ci voted on patch set 40 V +1 09/10/24, 01:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65161

  91. Frank Nägler commented on patch set 40 09/10/24, 07:25

    Feature-104672-DeployablePermissionPresetsForExtensions.rst:102 Reply

    thanks
  92. Stefan Bürk commented on patch set 40 CR -2 09/10/24, 09:37

    Feature-104672-DeployablePermissionPresetsForExtensions.rst:102 Reply

    Done
  93. Tomek Woldański uploaded patch set 41 V +1 09/10/24, 15:22

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  94. core-ci voted on patch set 41 V -1 09/10/24, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65272

  95. Tomek Woldański uploaded patch set 42 V -1 09/10/24, 15:30

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  96. core-ci voted on patch set 42 V +1 09/10/24, 15:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65274

  97. Tomek Woldański uploaded patch set 43 V +1 09/11/24, 08:20

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  98. Tomek Woldański commented on patch set 43 09/11/24, 08:21

    Reply

    Acknowledged
  99. core-ci voted on patch set 43 V -1 09/11/24, 08:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65387

  100. Michael Schams commented on patch set 43 09/12/24, 05:36

    all_web_modules.yaml:40

    I know this is just a test file. However, the permission reads "recursivedeleteFolder" (lower-case "d"elete). Maybe this comment saves some time if tests fail 😊
  101. Tomek Woldański commented on patch set 43 09/12/24, 07:46

    all_web_modules.yaml:40 Reply

    thx for finding a typo, this permission will be skipped as invalid, I leave it as it, to test scenario. Tests are failing on unrelated changes from the core (I have to wait for decision in other non-related patches to adjust or not adjust tests)
  102. Stefan Bürk uploaded patch set 44 V -1 09/12/24, 17:45

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  103. core-ci voted on patch set 44 V +1 09/12/24, 17:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65598

  104. Stefan Bürk uploaded patch set 45 V +1 09/13/24, 12:58

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  105. core-ci voted on patch set 45 V -1 09/13/24, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65677

  106. Stefan Bürk uploaded patch set 46 V -1 09/13/24, 13:11

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  107. Stefan Bürk voted on patch set 46 CR 0 09/13/24, 13:11

  108. core-ci voted on patch set 46 V +1 09/13/24, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65678

  109. Stefan Bürk uploaded patch set 47 V +1 09/13/24, 15:29

  110. core-ci voted on patch set 47 V +1 09/13/24, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65695

  111. Stefan Bürk commented on patch set 47 09/14/24, 00:10

    PermissionSetInterface.php:25 Reply

    Yes. We can think about having a small/reduced one and this one, and the core default permissionset uses this variant. We can keep the "simple" interface for method type hinting, but check against the interface and skip the default core record apply here https://review.typo3.org/c/Packages/TYPO3.CMS/+/85577/47/typo3/sysext/core/Classes/Permission/Set/BackendUserGroupPermissionSetApplier.php#73 but still dispatch the event than (doing literally nothing without the concrete richer interface. In the end, we could have interfaces for each "method" and extension authors implementing custom provider / schema / permission sets can "compose" the custom permission set when to use the core implementation and when to fallback to custom implementation - but that would blow up the whole api even more. Documenting the API is already a little challenge and it would not get better. Thinking about that, a meta and a second complete interface like this one would be a good start. That way, we could later extract single methods in dedicated interfaces (v14) if needed, composing the "fullblown" intefcace by extending the extracted interfaces and later deprecate (v14) and remove (v15) it. What do you think @benni@typo3.org ?
  112. Stefan Bürk uploaded patch set 48 V +1 09/14/24, 17:09

  113. core-ci voted on patch set 48 V -1 09/14/24, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65764

  114. Stefan Bürk uploaded patch set 49 V -1 09/15/24, 16:21

  115. core-ci voted on patch set 49 V +1 09/15/24, 16:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65818

  116. Stefan Bürk uploaded patch set 50 V +1 09/15/24, 19:04

  117. core-ci voted on patch set 50 V -1 09/15/24, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65822

  118. Benni Mack commented on patch set 50 09/16/24, 05:06

    GroupResolver.php:46

    any reason not to use the AfterGroupesResolvedEvent? If we use the Event, this actually decouples two separate pieces of code from each other properly.
  119. Stefan Bürk commented on patch set 50 09/16/24, 07:09

    GroupResolver.php:46 Reply

    Good point, missed that. Will add a eventlistener for that event and do the apply stuff there.
  120. Stefan Bürk uploaded patch set 51 V -1 09/16/24, 08:01

  121. Stefan Bürk commented on patch set 51 09/16/24, 08:02

    GroupResolver.php:46 Reply

    Done
  122. core-ci voted on patch set 51 V +1 09/16/24, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65860

  123. Stefan Bürk uploaded patch set 52 V +1 09/16/24, 09:20

  124. core-ci voted on patch set 52 V +1 09/16/24, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65864

  125. Stefan Bürk uploaded patch set 53 V +1 09/16/24, 10:00

  126. core-ci voted on patch set 53 V +1 09/16/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65872

  127. Tomek Woldański commented on patch set 53 09/16/24, 12:25

    PermissionSetsContainer.php:138

    We should also check PermissionsState
  128. Stefan Bürk commented on patch set 53 09/16/24, 12:28

    PermissionSetsContainer.php:138 Reply

    Not here. They should be added. The reasoning behind this is to have them in cache and for a future backend module to display all sets (and states) it would be not good to drop them here. But you are right, it needs to be checked for formengine apply and TCA select items thingy.
  129. Tomek Woldański commented on patch set 53 09/16/24, 12:30

    PermissionSetsContainer.php:138 Reply

    I see, makes sense. In this case check should be in other place.
  130. Stefan Bürk uploaded patch set 54 V +1 09/16/24, 13:22

  131. Stefan Bürk commented on patch set 54 09/16/24, 13:24

    Example permission preset: https://gist.github.com/sbuerk/14a7a8f8a1c05b99ff7c999a23fd988e which can be used and put in `typo3conf/permission-sets/` or adding custom presets.
  132. core-ci voted on patch set 54 V +1 09/16/24, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65889

  133. Stefan Bürk uploaded patch set 55 V +1 09/16/24, 13:42

  134. core-ci voted on patch set 55 V +1 09/16/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65893

  135. Tomek Woldański voted on patch set 55 CR +1 V +1 09/16/24, 14:14

  136. Garvin Hicking updated the commit message in patch set 56 CR +1 V +1 09/16/24, 15:38

  137. core-ci voted on patch set 56 V +1 09/16/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65904

  138. Anja Leichsenring updated the commit message in patch set 57 V +1 09/16/24, 15:59

  139. Garvin Hicking commented on patch set 58 09/16/24, 16:10

    Published edit on patch set 57.
  140. core-ci voted on patch set 57 V +1 09/16/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65907

  141. Garvin Hicking commented on patch set 58 09/16/24, 16:17

    Feature-104672-IntroduceDeployablePermissionPresets.rst:94

    what is a schema in this context?

    Feature-104672-IntroduceDeployablePermissionPresets.rst:101

    what does "removing the module" mean

    Feature-104672-IntroduceDeployablePermissionPresets.rst:106

    are these page uids or site identifiers?

    Feature-104672-IntroduceDeployablePermissionPresets.rst:136

    What does that mean, how can it be "provided"?

    Feature-104672-IntroduceDeployablePermissionPresets.rst:142

    What does this mean, EB?
  142. core-ci voted on patch set 58 V +1 09/16/24, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65909

  143. Tomek Woldański commented on patch set 58 09/16/24, 16:35

    Feature-104672-IntroduceDeployablePermissionPresets.rst:94 Reply

    You can have multiple schemas (format of for example yaml file)

    Feature-104672-IntroduceDeployablePermissionPresets.rst:101 Reply

    Do not provide permission for it (permission is not set)

    Feature-104672-IntroduceDeployablePermissionPresets.rst:106 Reply

    Both (you can use root page ID or site identifiers)

    Feature-104672-IntroduceDeployablePermissionPresets.rst:136 Reply

    Good catch, you should use locales only in current implementation
  144. Tomek Woldański uploaded patch set 59 V +1 09/16/24, 17:05

  145. Tomek Woldański commented on patch set 58 09/16/24, 17:06

    Feature-104672-IntroduceDeployablePermissionPresets.rst:94 Reply

    added additional info

    Feature-104672-IntroduceDeployablePermissionPresets.rst:101 Reply

    clarify it RST

    Feature-104672-IntroduceDeployablePermissionPresets.rst:136 Reply

    fixed
  146. Stefan Bürk uploaded patch set 60 09/16/24, 17:15

  147. Stefan Bürk commented on patch set 60 09/16/24, 17:18

    Feature-104672-IntroduceDeployablePermissionPresets.rst:94 Reply

    left over, should not be in that example.

    Feature-104672-IntroduceDeployablePermissionPresets.rst:101 Reply

    ``` media_management: false ``` would not make sense - if the db record has it or another preset defines it, it will not be removed. Literally it is the does the same (nothing) like having it not written at all. Will adjust the comment in the example. done.

    Feature-104672-IntroduceDeployablePermissionPresets.rst:136 Reply

    The can also be provided manually slipped in there by accident, was meant as anser on slack :blush:
  148. core-ci voted on patch set 59 V +1 09/16/24, 17:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65914

  149. Stefan Bürk updated the commit message in patch set 61 09/16/24, 17:21

  150. core-ci voted on patch set 61 V +1 09/16/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65917

  151. Tomek Woldański voted on patch set 61 CR +1 V +1 09/16/24, 17:27

  152. core-ci voted on patch set 60 V -1 09/16/24, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65916

  153. Stefan Bürk commented on patch set 61 09/16/24, 17:40

    Reply

    I guess user level may be doable, however for the dynamic variant there is no real suitable event available - at least for a direct core implementation. A extension can later use this permission base and make the addition for be_user with some quirks. We can talk about that benni. Resolving this for because I guess we would not get these changes for be_users in in the remaining time frame.

    YamlSetFileProvider.php:32 Reply

    Let's stay with one ending to avoid confusing. If someone really want they can copy&paste the YamlSetFileProvider to an extension and change that to custom file extension with a simple php attribute and it would kickin beside the core variant. Provider does not work like the point that remark was made. Resolving this for now.

    PermissionSetInterface.php:25 Reply

    Done
  154. Anja Leichsenring voted on patch set 61 CR +1 V +1 09/16/24, 17:41

  155. core-ci voted on patch set 60 V +1 09/16/24, 17:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65916

  156. Garvin Hicking commented on patch set 61 09/16/24, 18:09

    PermissionSetsInformation.html:40

    missin l10n
  157. Stefan Bürk commented on patch set 61 CR -1 09/16/24, 18:17

    on it ....
  158. Stefan Bürk uploaded patch set 62 CR +1 V +1 09/16/24, 18:21

  159. Stefan Bürk commented on patch set 62 09/16/24, 18:21

    Reply

    Done

    PermissionSetsInformation.html:40 Reply

    Done
  160. Anja Leichsenring voted on patch set 62 CR +1 V +1 09/16/24, 18:23

  161. core-ci voted on patch set 62 V +1 09/16/24, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/65918

  162. Oli Bartsch commented on patch set 62 09/16/24, 21:43

    I had just a quick look and added some comments. At first sight, the feature looks promising while the added code and abstraction is quite huge. I'm very sceptical about adding such a big change hours before FF. However, I won't block this for now.

    OuterWrapContainer.php:172

    This special handling which applies **only** for be_groups should IMO not be added to the general OuterWrapContainer. Besides adding unrelated code here, it breaks the current UI and leads to inconsistence. We are actually about to make FormEngine more consistent, e.g. by automatically generating showitem (see: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85859). Introducing such special UI counteracts this.

    PermissionSetsInformation.html:42

    For me, selecting a set and saving the record leads to the set being selected after reload but it is not getting stored in the database.

    PermissionSetsInformation.html:52

    What is this view for, since the selected sets are visible in the record itself already?

    PermissionSetNotExistException.php:27

    This should implement Psr\Container\NotFoundExceptionInterface

    RecordPermissionSetApplier.php:53

    This would add a hard dependencies to EXT:dashboard

    RecordPermissionSetApplier.php:395

    We might want to use TcaSchema here.

    InvalidPermissionSetSchemaException.php:21

    Resolve todo?

    InvalidSchemaException.php:21

    Resolve todo?

    AvailablePermissionSetsItemProc.php:76

    This is not necessary. ->sL() handles this. However, IMO the whole method is not necessary since translation is done by the TcaSelectItems data provider.

    AvailablePermissionSetsItemProc.php:77

    If used, please always encapsulate $GLOBALS into methods, making replacement easier in the future.
  163. Benni Mack commented on patch set 62 CR -2 09/16/24, 21:54

    I think we need to clean a few things up, let's rather sort this out properly instead of rushing it in, as a possible exception for Feature Freeze. - Avoid pollution of OuterWrapContainer - Ensure that we show proper message above each field that permission sets alters this value (e.g. via fieldInformation https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/FieldInformation.html) - thus, ensure that this is not going to be persisted via DataHandler hook
  164. Benni Mack voted on patch set 62 CR -1 09/18/24, 06:16

  165. Michael Schams wrote 09/18/24, 06:34

    Removed cc Michael Schams.
  166. Stefan Bürk updated the commit message in patch set 63 CR +1 V +1 09/18/24, 07:22

  167. Stefan Bürk voted on patch set 63 CR -1 09/18/24, 07:22

  168. core-ci voted on patch set 63 V +1 09/18/24, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/66104

  169. Stefan Bürk voted on patch set 63 CR -2 09/26/24, 09:33

  170. Stefan Bürk uploaded patch set 64 V +1 10/04/24, 16:00

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  171. core-ci voted on patch set 64 V +1 10/04/24, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67107

  172. Stefan Bürk uploaded patch set 65 V +1 10/05/24, 00:36

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  173. Stefan Bürk uploaded patch set 66 10/05/24, 00:49

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  174. core-ci voted on patch set 66 V +1 10/05/24, 01:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67116

  175. core-ci voted on patch set 65 V -1 10/05/24, 01:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67115

  176. Stefan Bürk uploaded patch set 67 V +1 10/05/24, 13:04

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  177. Stefan Bürk uploaded patch set 68 10/05/24, 13:19

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  178. core-ci voted on patch set 67 V +1 10/05/24, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67153

  179. core-ci voted on patch set 68 V +1 10/05/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67155

  180. Stefan Bürk uploaded patch set 69 V +1 10/06/24, 19:22

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  181. core-ci voted on patch set 69 V -1 10/06/24, 19:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67190

  182. Stefan Bürk uploaded patch set 70 V -1 10/06/24, 21:01

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  183. core-ci voted on patch set 70 V +1 10/06/24, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67191

  184. Stefan Bürk rebased onto patch set 71 V +1 10/07/24, 20:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  185. core-ci voted on patch set 71 V +1 10/07/24, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67289

  186. Stefan Bürk uploaded patch set 72 V +1 10/09/24, 00:36

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  187. core-ci voted on patch set 72 V +1 10/09/24, 00:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67399

  188. Stefan Bürk uploaded patch set 73 V +1 10/09/24, 08:54

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  189. core-ci voted on patch set 73 V +1 10/09/24, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67425

  190. Stefan Bürk voted on patch set 73 CR 0 10/09/24, 09:20

  191. Stefan Bürk commented on patch set 73 10/09/24, 09:38

    Reply

    Reduced the PHP api and cutted out parts.

    OuterWrapContainer.php:172 Reply

    Removed and solved by using a new `fieldInformation`.

    PermissionSetsInformation.html:42 Reply

    Originally, this change provided 2 modes. Sets which are applied during the group resolving (not perssted) and by applying it directly to the record. After discussing this with Benni and lolli (multiple) times, the feature is reduced to the "on-the-fly" apply only. Thus, when presets are now selected (and saved), managed fields are marked as read-only, values cleared and a fieldInformation added to managed fields along with displaying all applied permission for managed fields of selected presets (aka preview directly in the edit form).

    PermissionSetsInformation.html:52 Reply

    Removed. Partly dropped, rest solved with field fieldInformation.

    PermissionSetNotExistException.php:27 Reply

    Thanks for mention that, done.

    RecordPermissionSetApplier.php:53 Reply

    Good point. I solved this by adding a event listener for the dispatched event to `EXT:dashboard`, and also to `EXT:workspaces` to handle permission apply requiring these system extensions to be installed in the event listener. That should solve the `dependency of extension within the core` issue cycle. Thanks for mention that point ❤️

    RecordPermissionSetApplier.php:395 Reply

    Ack. Done, albeit code has changed. But all tca related places should now use TcaSchema and not the global anymore.

    InvalidPermissionSetSchemaException.php:21 Reply

    This exception clas has been removed meanwhile, along witht eh whole schema part of the php-api as part of reducing it.

    InvalidSchemaException.php:21 Reply

    This exception clas has been removed meanwhile, along witht eh whole schema part of the php-api as part of reducing it.

    AvailablePermissionSetsItemProc.php:76 Reply

    Ack. Removed method and not doing translation here at all.

    AvailablePermissionSetsItemProc.php:77 Reply

    Removed.
  192. Stefan Bürk commented on patch set 73 10/09/24, 09:51

    Reply

    Updated gist to contain example with adoption of changed syntax. See also the rest file. Additionally, added a preset with invalid yaml syntax to the gist to see the difference in the cli command.
  193. Stefan Bürk uploaded patch set 74 V +1 10/09/24, 09:52

  194. core-ci voted on patch set 74 V +1 10/09/24, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67435

  195. Stefan Bürk commented on patch set 74 10/09/24, 14:04

    Reply

    Done
  196. Tomek Woldański uploaded patch set 75 V +1 10/09/24, 14:40

  197. core-ci voted on patch set 75 V +1 10/09/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67454

  198. Tomek Woldański uploaded patch set 76 V +1 10/09/24, 15:30

  199. core-ci voted on patch set 76 V -1 10/09/24, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67455

  200. Tomek Woldański uploaded patch set 77 V -1 10/09/24, 16:11

  201. core-ci voted on patch set 77 V -1 10/09/24, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67457

  202. Garvin Hicking commented on patch set 77 10/09/24, 20:38

    few minor changelog comments (can patch myself tomorrow, and finish the rest)

    Feature-104672-IntroduceDeployablePermissionPresets.rst:55

    ": yaml" > ":yaml"

    Feature-104672-IntroduceDeployablePermissionPresets.rst:55

    "mointpoints" -> "mountpoints"

    Feature-104672-IntroduceDeployablePermissionPresets.rst:66

    "provided to provide" just "provides"

    Feature-104672-IntroduceDeployablePermissionPresets.rst:74

    "could display the following output for example":
  203. Stefan Bürk commented on patch set 77 CR -1 10/10/24, 07:15

    on it ..
  204. Tomek Woldański uploaded patch set 78 CR -1 V -1 10/10/24, 13:16

  205. Tomek Woldański commented on patch set 77 10/10/24, 13:16

    Feature-104672-IntroduceDeployablePermissionPresets.rst:55 Reply

    Done

    Feature-104672-IntroduceDeployablePermissionPresets.rst:55 Reply

    Done

    Feature-104672-IntroduceDeployablePermissionPresets.rst:66 Reply

    Done

    Feature-104672-IntroduceDeployablePermissionPresets.rst:74 Reply

    Done
  206. Tomek Woldański commented on patch set 78 10/10/24, 13:17

    Reply

    Done & small fix for PHPStan
  207. core-ci voted on patch set 78 V +1 10/10/24, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67511

  208. Tomek Woldański commented on patch set 78 10/10/24, 13:23

    Reply

    Done
  209. Stefan Bürk commented on patch set 78 CR -1 10/10/24, 13:30

    on it - please do not push on it as I will override intermediate chagnes
  210. Stefan Bürk uploaded patch set 79 CR -1 V +1 10/10/24, 16:20

  211. Stefan Bürk voted on patch set 79 CR -1 10/10/24, 16:21

  212. Nikita Hovratov wrote 10/10/24, 16:25

    Removed cc Nikita Hovratov.
  213. core-ci voted on patch set 79 V -1 10/10/24, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67518

  214. Stefan Bürk uploaded patch set 80 CR -1 V -1 10/10/24, 16:29

  215. core-ci voted on patch set 80 V +1 10/10/24, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67519

  216. Stefan Bürk uploaded patch set 81 V +1 10/10/24, 19:00

  217. core-ci voted on patch set 81 V -1 10/10/24, 19:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67533

  218. Stefan Bürk uploaded patch set 82 V -1 10/10/24, 19:07

  219. core-ci voted on patch set 82 V +1 10/10/24, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67534

  220. Garvin Hicking commented on patch set 82 CR -1 10/10/24, 20:12

    on it to push documentation related changes
  221. Garvin Hicking uploaded patch set 83 CR -1 V +1 10/10/24, 20:22

    Adjust ReST file and commit message
  222. core-ci voted on patch set 83 V +1 10/10/24, 20:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67536

  223. Garvin Hicking uploaded patch set 84 V +1 10/10/24, 20:34

    Adjust user facing formengine hints
  224. core-ci voted on patch set 84 V +1 10/10/24, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67537

  225. Garvin Hicking uploaded patch set 85 V +1 10/10/24, 20:46

    Adjust rendering addendum
  226. core-ci voted on patch set 85 V +1 10/10/24, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67538

  227. Garvin Hicking commented on patch set 85 10/10/24, 21:11

    PermissionSetManagedInformation.php:25

    @internal?

    DatabaseRowBackendPermission.php:28

    @internal classification?

    BackendPermissionPresetsDataHandler.php:47

    leftover?

    InvalidPermissionSetsProvider.php:33

    @internal?

    YamlPermissionSetsProvider.php:95

    maybe ~ and + as some more characters that people sometimes use? Otherwise we should probably document in the changelog that it's not "*.yaml" but a "*.yaml without special characters other than dash and underscore"?

    GetBackendPermissionInstructionTrait.php:28

    @internal?
  228. Stefan Bürk uploaded patch set 86 V +1 10/11/24, 09:59

  229. Stefan Bürk commented on patch set 86 10/11/24, 09:59

    PermissionSetManagedInformation.php:25 Reply

    Done

    DatabaseRowBackendPermission.php:28 Reply

    Done

    BackendPermissionPresetsDataHandler.php:47 Reply

    yip, thanks. Removed.

    InvalidPermissionSetsProvider.php:33 Reply

    Done

    YamlPermissionSetsProvider.php:95 Reply

    will think about it, but tilde looks weired. The goal behind that was to get clean structured names which also makes sense to be used as part of the set identifier, in the backend selection and so forth. But ack, should at least be documented - had that original in mind but during the rest file rewrite it passed away.

    GetBackendPermissionInstructionTrait.php:28 Reply

    Done
  230. Tomek Woldański commented on patch set 86 10/11/24, 10:05

    Reply

    Acknowledged
  231. core-ci voted on patch set 86 V +1 10/11/24, 10:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67583

  232. Oli Bartsch uploaded patch set 87 V +1 10/11/24, 13:33

  233. core-ci voted on patch set 87 V -1 10/11/24, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67600

  234. Oli Bartsch uploaded patch set 88 V -1 10/11/24, 21:32

  235. core-ci voted on patch set 88 V -1 10/11/24, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67622

  236. Stefan Bürk commented on patch set 88 CR -1 10/13/24, 17:51

    on it ...
  237. Stefan Bürk uploaded patch set 89 CR -1 V -1 10/14/24, 03:08

  238. core-ci voted on patch set 89 V +1 10/14/24, 03:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67720

  239. Stefan Bürk commented on patch set 89 10/14/24, 03:18

    Reply

    Done

    YamlPermissionSetsProvider.php:95 Reply

    Added the pattern to the documentation, decided against `~` and `+` - mainly to avoid eventually url encoding issues if used as url argument at some point. It's better to use `-` or `_` as separator characts anyway and the more commonly used replacement for spaces or separator. At least for dinosaurs 😊
  240. Stefan Bürk commented on patch set 89 10/14/24, 03:19

    YamlPermissionSetsProvider.php:95 Reply

    Done
  1. Stefan Bürk commented on patch set 89 10/14/24, 03:24

    UserInformationService.php:58

    Should we also add the set state ? (valid, error/loading error) ?
  2. Stefan Bürk uploaded patch set 90 V +1 10/14/24, 03:36

  3. core-ci voted on patch set 90 V +1 10/14/24, 03:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67721

  4. Oli Bartsch uploaded patch set 91 V +1 10/14/24, 10:23

  5. core-ci voted on patch set 91 V -1 10/14/24, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67749

  6. Oli Bartsch uploaded patch set 92 V -1 10/14/24, 10:46

  7. Oli Bartsch commented on patch set 92 10/14/24, 10:47

    UserInformationService.php:58 Reply

    Let's keep it simple for now. Maybe in a next step.
  8. core-ci voted on patch set 92 V +1 10/14/24, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67750

  9. Benni Mack commented on patch set 92 10/14/24, 11:34

    GroupResolver.php:47

    IMHO unrelated, let's leave this change out please

    PermissionSetsContainer.php:43

    should be named "Registry" right?

    InvalidPermissionSetsProvider.php:18

    I don't know if we ever use "Exceptions" has namespace? Can you recheck. Also, "InvalidPermissionSetsProvider" should be named "InvalidPermissionSetsProviderException" IMHO.

    BackendPermissionInstructionFactoryInterface.php:29

    I'd rather get rid of this interface for the time being. Why? The factory has an interface, but the implementation doesn't.

    GetBackendPermissionInstructionTrait.php:30

    This looks like a strange piece of code... do we really need this in the current state of work, or just keep it "simple"?

    MethodTraitClassImplementsInterfacesTrait.php:28

    This looks like a strange piece of code... do we really need this in the current state of work, or just keep it "simple"?

    be_groups.php:272

    I think we can live without the palette.
  10. Oli Bartsch commented on patch set 92 V -1 10/14/24, 11:36

    on it ..
  11. Benni Mack commented on patch set 92 10/14/24, 12:41

    PermissionPresetsListCommand.php:36 Unresolved

    I fail to understand the usefulness of this CLI command. What does "loaded" in this regard mean? Loaded = available in the system or loaded for a usergroup? Also, what does "Check against table" really mean? I mean, the most interesting part - when using deployable permissions - is to understand "Hey, this user actually has these 12 permissions, which come from these 5 permission sets which have been selected in these 3 groups"
  12. Stefan Bürk commented on patch set 92 10/14/24, 13:06

    GroupResolver.php:47 Reply

    Left over - original a additional event was dispatched. So yeah, let's revert that unrelated change.

    PermissionSetsContainer.php:43 Reply Unresolved

    Don't want to discuss naming here, in my eyes now. A registry allows to add/remove things during runtime, this does not. But as Registry has been used already for other similar things, fine to rename.

    InvalidPermissionSetsProvider.php:18 Reply Unresolved

    Should be `Exception/`. Fine to add Exception in the end.

    BackendPermissionInstructionFactoryInterface.php:29 Reply Unresolved

    Let's drop it.

    GetBackendPermissionInstructionTrait.php:30 Reply Unresolved

    Not really, let's drop it.

    MethodTraitClassImplementsInterfacesTrait.php:28 Reply Unresolved

    Let's drop it.
  13. Oli Bartsch uploaded patch set 93 V +1 10/14/24, 14:17

  14. core-ci voted on patch set 93 V -1 10/14/24, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67762

  15. Oli Bartsch uploaded patch set 94 V -1 10/14/24, 14:27

  16. Oli Bartsch commented on patch set 94 10/14/24, 14:28

    GroupResolver.php:47 Reply

    Done

    be_groups.php:272 Reply

    Done
  17. core-ci voted on patch set 94 V +1 10/14/24, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67763

  18. Oli Bartsch uploaded patch set 95 V +1 05/23/25, 09:42

  19. core-ci voted on patch set 95 V -1 05/23/25, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79416

  20. Tomek Woldański uploaded patch set 96 V -1 09/01/25, 10:10

  21. core-ci voted on patch set 96 V -1 09/01/25, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84136

  22. Tomek Woldański uploaded patch set 97 V -1 09/01/25, 10:25

  23. core-ci voted on patch set 97 V -1 09/01/25, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/84137

  24. Benni Mack wrote 04/21/26, 15:01

    Removed reviewer Benni Mack.
  25. Benni Mack abandoned the change 11/10/26, 13:35

    no activity for over a year, I will abandon this change now. It can be re-isntantiated later-on