Review main Merged

85581[TASK] Sanitize idn_to_ascii with empty string

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 08/10/24, 13:07

Commit message

idn_to_ascii() must not be called with empty
string in PHP 8.4.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 08/10/24, 12:12

  2. Christian Kuhn updated the commit message in patch set 2 08/10/24, 12:14

  3. core-ci voted on patch set 1 V +1 08/10/24, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63168

  4. core-ci voted on patch set 2 V +1 08/10/24, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63169

  5. Jasmina Ließmann voted on patch set 2 CR +1 V +1 08/10/24, 12:24

  6. Stefan Bürk voted on patch set 2 CR +1 V +1 08/10/24, 13:05

  7. Christian Kuhn voted on patch set 2 CR +2 V +2 08/10/24, 13:07

  8. Christian Kuhn merged patch set 3 08/10/24, 13:07