Review main Merged

85591[TASK] Allow to disable CSP headers for a particular site

Oliver Hader CR +2 V +2 Easy +29 −2 updated 08/15/24, 10:45

Commit message

This change allows to disable CSP headers for a particular site
configured in `sites/<my-site>/csp.yaml` by using the assignment
`enable: false`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Oliver Hader uploaded patch set 1 08/12/24, 11:42

  2. Oliver Hader wrote 08/12/24, 11:43

    Topic set to csp
  3. core-ci voted on patch set 1 V +1 08/12/24, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63216

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 08/12/24, 21:18

    Works for me in a 12.4 installation Tested: - Use CSP without 'enable' directive - Use CSP with 'enable: true' directive - Do not use CSP with 'enable: false' directive (A Configuration/ContentSecurityPolicies.php file of my EXT:sitepackage is then not applied; this matches my expecation)
  5. Georg Ringer voted on patch set 1 CR +1 V +1 08/13/24, 21:38

  6. Stefan Bürk voted on patch set 1 CR +1 V +1 08/14/24, 00:49

  7. Oliver Hader voted on patch set 1 CR +2 V +2 08/14/24, 06:45

  8. Oliver Hader merged patch set 2 08/14/24, 06:45

  9. Oliver Hader commented on patch set 2 08/15/24, 10:45