Review main Merged

85592[TASK] Have PHP 8.4 functionals

Christian Kuhn CR +2 V +2 Easy +29 −13 updated 08/12/24, 20:13

Commit message

Activate PHP 8.4 functional tests in pre-merge
and a nightly combination.

Similar to unit tests with #104578, we patch
another library: enshrined/svg-sanitize. A
patch is pending [1], but not yet merged nor
released. Codewise its trivial.

Some tests need a minor adaption since XML
files are created slightly differently with
PHP 8.4, the change aligns the fixtures to
deal with this.

[1] https://github.com/darylldoyle/svg-sanitizer/pull/110

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1119

  1. Christian Kuhn uploaded patch set 1 08/12/24, 11:50

  2. core-ci voted on patch set 1 V -1 08/12/24, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63217

  3. Christian Kuhn uploaded patch set 2 V -1 08/12/24, 13:01

  4. core-ci voted on patch set 2 V +1 08/12/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63238

  5. Christian Kuhn uploaded patch set 3 V +1 08/12/24, 13:09

  6. core-ci voted on patch set 3 V +1 08/12/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63239

  7. Christian Kuhn updated the commit message in patch set 4 V +1 08/12/24, 13:15

  8. core-ci voted on patch set 4 V +1 08/12/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63240

  9. core-ci voted on patch set 4 V -1 08/12/24, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63241

  10. Christian Kuhn rebased onto patch set 5 V -1 08/12/24, 14:42

  11. core-ci voted on patch set 5 V +1 08/12/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63250

  12. Anja Leichsenring voted on patch set 5 CR +1 V +1 08/12/24, 15:01

  13. core-ci commented on patch set 5 08/12/24, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63251

  14. Christian Kuhn uploaded patch set 6 08/12/24, 15:17

    Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  15. core-ci voted on patch set 6 V +1 08/12/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63252

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 08/12/24, 16:03

  17. Garvin Hicking commented on patch set 6 CR +1 V +1 08/12/24, 16:31

    Gna, that utf-8 change is a weeeny bit annoying ;)
  18. Christian Kuhn voted on patch set 6 CR +2 V +2 08/12/24, 20:13

  19. Christian Kuhn merged patch set 7 08/12/24, 20:13