85592[TASK] Have PHP 8.4 functionals
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- Anja Leichsenring +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 8
- Build/gitlab-ci/nightly/functional.yml+3 −3
- Build/gitlab-ci/pre-merge/functional.yml+3 −3
- Build/patches/darylldoyle-svg-sanitizer-php-8.4.diffnew+13 −0
- Build/patches/patches.json+3 −0
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/external.svg+1 −1
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/svgOne.svg+1 −1
- typo3/sysext/core/Tests/Functional/Resource/Fixtures/DirtySVG/xlinkLoop.svg+1 −1
- typo3/sysext/core/Tests/Functional/Resource/Security/SvgSanitizerTest.php+4 −4
Review log 1119
-
Christian Kuhn uploaded patch set 1 08/12/24, 11:50
-
core-ci voted on patch set 1 V -1 08/12/24, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63217
-
Christian Kuhn uploaded patch set 2
V -108/12/24, 13:01 -
core-ci voted on patch set 2 V +1 08/12/24, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63238
-
Christian Kuhn uploaded patch set 3
V +108/12/24, 13:09 -
core-ci voted on patch set 3 V +1 08/12/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63239
-
Christian Kuhn updated the commit message in patch set 4
V +108/12/24, 13:15 -
core-ci voted on patch set 4 V +1 08/12/24, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63240
-
core-ci voted on patch set 4 V -1 08/12/24, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63241
-
Christian Kuhn rebased onto patch set 5
V -108/12/24, 14:42 -
core-ci voted on patch set 5 V +1 08/12/24, 14:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63250
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 08/12/24, 15:01
-
core-ci commented on patch set 5 08/12/24, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63251
-
Christian Kuhn uploaded patch set 6 08/12/24, 15:17
Copied Votes: * Code-Review+1 (copy condition: "**changekind:NO_CHANGE** OR is:MIN") * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 6 V +1 08/12/24, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63252
-
Stefan Bürk voted on patch set 6 CR +1 V +1 08/12/24, 16:03
-
Garvin Hicking commented on patch set 6 CR +1 V +1 08/12/24, 16:31
Gna, that utf-8 change is a weeeny bit annoying ;) -
Christian Kuhn voted on patch set 6 CR +2 V +2 08/12/24, 20:13
-
Christian Kuhn merged patch set 7 08/12/24, 20:13