Review main Merged

85597[DOCS] Document site sets of EXT:form

Lina Wolf CR +2 V +2 Normal +54 −30 updated 08/16/24, 09:05

Commit message

This patch adds a description on how to utilize
site sets from `EXT:form` to the Integrator Quick start.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2026

Show 1 earlier messages
  1. Lina Wolf uploaded patch set 1 08/12/24, 12:48

  1. Chris Müller commented on patch set 1 08/12/24, 12:58

  2. core-ci voted on patch set 1 V +1 08/12/24, 13:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63233

  3. Lina Wolf uploaded patch set 2 V +1 08/12/24, 16:39

  4. Lina Wolf updated the commit message in patch set 3 08/12/24, 16:41

  5. Lina Wolf commented on patch set 3 08/12/24, 16:43

  6. core-ci voted on patch set 2 V +1 08/12/24, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63254

  7. core-ci voted on patch set 3 V +1 08/12/24, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63255

  8. Garvin Hicking commented on patch set 3 08/12/24, 19:43

    Index.rst:27

    I would prefer something like the following: ``` 1. Activate TypoScript .. versionchanged:: 13.3 TYPO3 13.3 introduced site sets for TypoScript settings, and `EXT:form` can utilize them. You can either enable the needed TypoScript configuration via site sets (recommended) or utilize the classic TypoScript method: 1. Include via site sets Include the site set "Form Framework" via the :ref:`site set in the site configuration <t3coreapi:site-sets>` or a custom :ref:`sitepackage's site set <t3sitepackage:site_set>`. .. figure:: /Images/SiteSet.png Add the site set "Form Framework". 2. Include via TypoScript sets First, open the `TypoScript` module in the backend and edit your root TypoScript record. In the tab "Includes", ensure that `Fluid Content Elements (fluid_styled_content)` and `Form (form)` are among the selected items. Save the record. ``` My reasoning is: Not everyone may switch directly to site sets with TYPO3 v13. Until the "old" way is removed, it is still valid and needs documentation. What do you think?
  9. Garvin Hicking updated the commit message in patch set 4 V +1 08/12/24, 19:44

  10. core-ci voted on patch set 4 V +1 08/12/24, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63258

  11. Lina Wolf commented on patch set 4 08/12/24, 20:18

    Index.rst:27 Reply

    Everyone should definitely switch to using site sets once they use TYPO3 13. There is no reason whatsover to newly manually include the typoscript. Presenting them as alternative ways would only cause more confusion. See also https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.1/Feature-103439-TypoScriptProviderForSitesAndSets.html#set-typoscript "In contrast to static_file_include, dependencies are to be included via sets. Dependencies are included recursively. **This mechanism supersedes the previous include** via static_file_include or manual @import statements as sets are automatically ordered and deduplicated. That means TypoScript will not be loaded multiple times, if a shared dependency is required by multiple sets. Note that @import statements are still fine to be used for local includes, **but should be avoided for cross-set/extensions dependencies.**"
  12. Garvin Hicking commented on patch set 4 08/12/24, 20:42

    Index.rst:27 Reply

    I understand your point of view. I'll wait for some more feedback, hope that's fine with you. :-)
  13. Lina Wolf uploaded patch set 5 V +1 08/13/24, 08:08

  14. Lina Wolf commented on patch set 5 08/13/24, 08:10

    Index.rst:27 Reply

    So, to get this in for now I moved the legacy TypoScript includes to the bottom. I called them "Includes" as that is the text used in the Backend and "TypoScript sets" might cause more confusion. However I mentioned that they were also sometimes called that.
  15. core-ci voted on patch set 5 V +1 08/13/24, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63279

  16. Garvin Hicking uploaded patch set 6 V +1 08/14/24, 13:36

  17. Garvin Hicking commented on patch set 6 CR +1 V +1 08/14/24, 13:40

    I think the flow of this has some issues with a bottom paragraph needing to continue in the upper section, but it's better to me than the intial patch and I could live with it.
  18. Garvin Hicking commented on patch set 6 08/14/24, 13:40

    Index.rst:27 Reply

    Done
  19. core-ci voted on patch set 6 V +1 08/14/24, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63385

  20. Stefan Froemken commented on patch set 6 CR +1 08/14/24, 14:21

    Looks good. Will not down-votes because of that "a"

    Index.rst:42

    "a .xlf file"
  21. Lina Wolf commented on patch set 6 08/14/24, 14:24

    Index.rst:42 Reply

    aktually it is "an x" as it is spoken "an ex"
  22. Christian Kuhn voted on patch set 6 CR +1 V +1 08/14/24, 16:14

  23. Garvin Hicking voted on patch set 6 CR +2 V +2 08/14/24, 17:00

  24. Garvin Hicking merged patch set 7 08/14/24, 17:01

  25. Benjamin Franzke commented on patch set 7 08/16/24, 09:05

    Index.rst:27 Reply

    Ack, I think site sets should be suggested and we're convident that they are the way to go for v13. I think it's important to keep the documentation for TypoScript records for two reasons: * they will *not* be deprecated anytime soon. * I personally wouldn't consider it bad practice to *not* migrate every record to sets when updating to v13. A system that runs perfectly fine with TypoScript records doesn't need to be changed "agressively".