Review 12.4 Merged

85601[TASK] Deal with sebastian/comparator:5.0.2

Christian Kuhn CR +2 V +2 Easy +17 −10 updated 08/12/24, 14:41

Commit message

sebastian/comparator:5.0.2 got a minor bugfix release
changing a detail of assertEqualsCanonicalizing().
Two tests fail when this transitive dependency
is raised. We slightly refactor the tests to deal
with this.

> composer u sebastian/comparator

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 08/12/24, 14:23

  2. core-ci voted on patch set 1 V -1 08/12/24, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63245

  3. Christian Kuhn uploaded patch set 2 V -1 08/12/24, 14:31

  4. core-ci voted on patch set 2 V +1 08/12/24, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63248

  5. Christian Kuhn voted on patch set 2 CR +2 V +2 08/12/24, 14:41

  6. Christian Kuhn merged patch set 3 08/12/24, 14:41