Review main Merged

85609[BUGFIX] Update `symfony/polyfill-php83` for PHP 8.4 compat

Andreas Kienast CR +2 V +2 Easy +7 −8 updated 08/13/24, 10:55

Commit message

The package `symfony/polyfill-php83` can be upgraded to version 1.30.0,
solving deprecations regarding nullable types in PHP 8.4
environments [1].

Executed command:

    composer update symfony/polyfill-php83

[1] https://github.com/symfony/polyfill-php83/compare/v1.29.0...v1.30.0

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 08/13/24, 09:30

  2. Andreas Kienast updated the commit message in patch set 2 08/13/24, 09:31

  3. Andreas Kienast updated the commit message in patch set 3 08/13/24, 09:37

  4. core-ci voted on patch set 1 V -1 08/13/24, 09:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63287

  5. core-ci voted on patch set 3 V +1 08/13/24, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63289

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 08/13/24, 10:47

  7. Stefan Bürk voted on patch set 3 CR +1 V +1 08/13/24, 10:49

  8. Andreas Kienast voted on patch set 3 CR +2 V +2 08/13/24, 10:55

  9. Andreas Kienast merged patch set 4 08/13/24, 10:55