Review 12.4 Merged

85614[BUGFIX] Replace method returnWebmounts() with getWebmounts()

Christian Kuhn CR +2 V +2 Normal +41 −14 updated 08/13/24, 11:55

Commit message

The method BackendUserAuthentication::returnWebmounts() returns
an array of strings. This triggers a type error when calling
DatabaseIntegrityController::getTreeList() since this method
now requires the mountpoint as an integer.

In order to keep backwards compatibility a new method
BackendUserAuthentication::getWebmounts() has been introduced,
which returns an array of integers.

Existing calls to returnWebmounts() have been replaced by calls
to getWebmounts() and fixes by applying array_map(intval(...)
on the result is now superfluous.

A follow up issue has been created #104607 to deprecate method
returnWebmounts() and to investigate if	succesive calls	to
array_unique can be done in getWebmounts() and removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 10

Review log 34

  1. Christian Kuhn uploaded patch set 1 08/13/24, 11:40

  2. core-ci voted on patch set 1 V +1 08/13/24, 11:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63305

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 08/13/24, 11:55

  4. Christian Kuhn merged patch set 2 08/13/24, 11:55