Review main Merged

85616[BUGFIX] Allow "Fieldset" form element w/o "fluidAdditionalAttributes"

Mathias Brodala CR +2 V +2 Easy +12 −6 updated 08/14/24, 15:13

Commit message

This is a mitigation of an issue introduced
with #102291, where f:for now tends to iterate
an empty string and crashes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Tung Ngo +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 810

  1. Mathias Brodala uploaded patch set 1 08/13/24, 12:44

  2. core-ci voted on patch set 1 V +1 08/13/24, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63309

  3. Christian Kuhn uploaded patch set 2 V +1 08/13/24, 13:15

  4. core-ci voted on patch set 2 V +1 08/13/24, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63314

  5. Christian Kuhn voted on patch set 2 CR +1 08/13/24, 13:55

  6. Tung Ngo voted on patch set 2 V +1 08/14/24, 13:22

  7. Christian Kuhn voted on patch set 2 V +1 08/14/24, 13:59

  8. Stefan Bürk voted on patch set 2 CR +1 V +1 08/14/24, 14:07

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 08/14/24, 15:13

  10. Christian Kuhn merged patch set 3 08/14/24, 15:13