85618[TASK] Deprecate `BackendUserAuthentication::returnWebmounts()`
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
-
Verified V +2 Done
- Christian Kuhn +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+2 −0
- typo3/sysext/core/Documentation/Changelog/13.3/Deprecation-104607-BackendUserAuthenticationReturnWebmounts.rst2new+48 −0
- typo3/sysext/core/Tests/Functional/Authentication/BackendUserAuthenticationTest.php+2 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1825
-
Thomas Hohn uploaded patch set 1 08/13/24, 13:59
-
Thomas Hohn uploaded patch set 2 08/13/24, 14:01
-
Thomas Hohn updated the commit message in patch set 3 08/13/24, 14:02
-
core-ci voted on patch set 1 V -1 08/13/24, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63319
-
core-ci voted on patch set 2 V -1 08/13/24, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63320
-
core-ci voted on patch set 3 V -1 08/13/24, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63321
-
Thomas Hohn uploaded patch set 4
V -108/13/24, 14:35 -
core-ci voted on patch set 4 V +1 08/13/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63322
-
Thomas Hohn updated the commit message in patch set 5
V +108/13/24, 14:47 -
core-ci voted on patch set 5 V +1 08/13/24, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63323
-
Christian Kuhn uploaded patch set 6
V +108/13/24, 15:02 -
Garvin Hicking commented on patch set 6 08/13/24, 15:03
-
Christian Kuhn voted on patch set 6 CR +1 V +1 08/13/24, 15:03
-
Christian Kuhn commented on patch set 6 08/13/24, 15:04
Deprecation-104607-BackendUserAuthenticationReturnWebmounts.rst:48ReplyDone. reworded already. -
core-ci voted on patch set 6 V +1 08/13/24, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63326
-
Stefan Bürk voted on patch set 6 CR +1 V +1 08/13/24, 16:12
-
Garvin Hicking commented on patch set 6 08/14/24, 07:32
Please merge https://review.typo3.org/c/Packages/TYPO3.CMS/+/85623 first, so that in this patch the changelog can already be changed to mention the array_unique replacement too? -
Thomas Hohn commented on patch set 6 08/14/24, 07:39
Reply
Fine with me :) - will do once it's ready -
Stefan Bürk commented on patch set 6 CR -1 08/14/24, 13:44
Reply
The mentioned change has been merged. @tho@gyldendal.dk can you update the rest file like suggested by @gh@faktor-e.de ? -
Thomas Hohn uploaded patch set 7
CR +1V +108/14/24, 16:05 -
Thomas Hohn commented on patch set 7 08/14/24, 16:05
Reply
Done -
Garvin Hicking commented on patch set 7 CR +1 V +1 08/14/24, 16:10
Reply
I think the first addition of the now duplicate paragraphs would not be needed, but I can also live with it. So either way, +1 from me, thanks for all that work. -
core-ci voted on patch set 7 V +1 08/14/24, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63395
-
Christian Kuhn voted on patch set 7 CR +2 V +2 08/14/24, 16:15
-
Christian Kuhn merged patch set 8 08/14/24, 16:15
Deprecation-104607-BackendUserAuthenticationReturnWebmounts.rst:48