Review main Merged

85618[TASK] Deprecate `BackendUserAuthentication::returnWebmounts()`

Thomas Hohn CR +2 V +2 Normal +59 −0 updated 08/14/24, 16:15

Commit message

TYPO3 has a method to retrieve webmounts
`BackendUserAuthentication::returnWebmounts()`.
The method returns the uid's of the webmounts as an array
of strings. A more suitable representation is an array of
integers.

A new method `BackendUserAuthentication::getWebmounts()` has
been introduced with #104591 that returns a list of integers.
With #104614 it is additionally ensured that the call to the method
BackendUserAuthentication::getWebmounts() returns an unique list
of webmounts. Superfluous calls to array_unique() can be removed.

The patch deprecates `BackendUserAuthentication::returnWebmounts()`.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 1825

  1. Thomas Hohn uploaded patch set 1 08/13/24, 13:59

  2. Thomas Hohn uploaded patch set 2 08/13/24, 14:01

  3. Thomas Hohn updated the commit message in patch set 3 08/13/24, 14:02

  4. core-ci voted on patch set 1 V -1 08/13/24, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63319

  5. core-ci voted on patch set 2 V -1 08/13/24, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63320

  6. core-ci voted on patch set 3 V -1 08/13/24, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63321

  7. Thomas Hohn uploaded patch set 4 V -1 08/13/24, 14:35

  8. core-ci voted on patch set 4 V +1 08/13/24, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63322

  9. Thomas Hohn updated the commit message in patch set 5 V +1 08/13/24, 14:47

  10. core-ci voted on patch set 5 V +1 08/13/24, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63323

  11. Christian Kuhn uploaded patch set 6 V +1 08/13/24, 15:02

  12. Garvin Hicking commented on patch set 6 08/13/24, 15:03

    Deprecation-104607-BackendUserAuthenticationReturnWebmounts.rst:48

    Instead of "this step" maybe "this conversion can be skipped, as getWebmounts takes care of tnks now" (or similar). If we do the array_unique() at some point, that could be mentioned too, like "Also, performing a unique array sort is performed by the new method."
  13. Christian Kuhn voted on patch set 6 CR +1 V +1 08/13/24, 15:03

  14. Christian Kuhn commented on patch set 6 08/13/24, 15:04

    Deprecation-104607-BackendUserAuthenticationReturnWebmounts.rst:48 Reply

    Done. reworded already.
  15. core-ci voted on patch set 6 V +1 08/13/24, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63326

  16. Stefan Bürk voted on patch set 6 CR +1 V +1 08/13/24, 16:12

  17. Garvin Hicking commented on patch set 6 08/14/24, 07:32

    Please merge https://review.typo3.org/c/Packages/TYPO3.CMS/+/85623 first, so that in this patch the changelog can already be changed to mention the array_unique replacement too?
  18. Thomas Hohn commented on patch set 6 08/14/24, 07:39

    Reply

    Fine with me :) - will do once it's ready
  19. Stefan Bürk commented on patch set 6 CR -1 08/14/24, 13:44

    Reply

    The mentioned change has been merged. @tho@gyldendal.dk can you update the rest file like suggested by @gh@faktor-e.de ?
  20. Thomas Hohn uploaded patch set 7 CR +1 V +1 08/14/24, 16:05

  21. Thomas Hohn commented on patch set 7 08/14/24, 16:05

    Reply

    Done
  22. Garvin Hicking commented on patch set 7 CR +1 V +1 08/14/24, 16:10

    Reply

    I think the first addition of the now duplicate paragraphs would not be needed, but I can also live with it. So either way, +1 from me, thanks for all that work.
  23. core-ci voted on patch set 7 V +1 08/14/24, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63395

  24. Christian Kuhn voted on patch set 7 CR +2 V +2 08/14/24, 16:15

  25. Christian Kuhn merged patch set 8 08/14/24, 16:15