85619[TASK] Introduce TypolinkParameter object
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+14 −8
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+13 −10
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Link/TypolinkViewHelperTest.php+26 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Uri/TypolinkViewHelperTest.php+63 −6
- typo3/sysext/frontend/Classes/Typolink/TypolinkParameter.php5new+68 −0
Review log 1218
-
Oli Bartsch uploaded patch set 1 08/13/24, 15:06
-
core-ci voted on patch set 1 V -1 08/13/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327
-
core-ci commented on patch set 1 08/13/24, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327
-
core-ci commented on patch set 1 08/13/24, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327
-
core-ci commented on patch set 1 08/13/24, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327
-
Christian Kuhn commented on patch set 1 CR -1 08/13/24, 16:07
TypolinkParameter.php:104this most likely should not happen in this value object: this is a depedency to a service that actually is a real service doing things like event dispatching and all that jazz. it feels as if this shouldn't be part of a value object, but could very well be externalized to services working with that value object?! -
Benni Mack commented on patch set 1 08/14/24, 09:08
Can be combined with https://review.typo3.org/c/Packages/TYPO3.CMS/+/82678 which adds a new interface that could then receive the new object instead of the array. -
Oli Bartsch uploaded patch set 2
CR -1V -108/14/24, 09:14 -
Oli Bartsch commented on patch set 2 08/14/24, 09:15
TypolinkParameter.php:29ReplyDoneTypolinkParameter.php:104ReplyDone -
core-ci voted on patch set 2 V -1 08/14/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63360
-
Oli Bartsch uploaded patch set 3
V -108/14/24, 09:33 -
core-ci voted on patch set 3 V +1 08/14/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63363
-
Jochen Roth voted on patch set 3 CR +1 V +1 08/14/24, 09:50
-
Nikita Hovratov voted on patch set 3 CR +1 V +1 08/14/24, 09:55
-
Oli Bartsch voted on patch set 3 CR +2 V +2 08/14/24, 09:56
-
Oli Bartsch merged patch set 4 08/14/24, 09:56
-
Christian Kuhn voted on patch set 4 CR +1 V +1 08/14/24, 11:45
-
Christian Kuhn commented on patch set 4 08/14/24, 11:45
TypolinkParameter.php:23Unresolvedcould should have been set final - there is no point in extending this in any way.
TypolinkParameter.php:29