Review main Merged

85619[TASK] Introduce TypolinkParameter object

Oli Bartsch CR +2 V +2 Normal +184 −24 updated 08/14/24, 11:45

Commit message

This adds a new value object, containing
the resolved parameters of a typolink.

The object will be used as enriched value
for TCA type "link" properties in the
Record object. The enrichment will be added
with #103581.

Since this value is then passed to the view
instead of the plain typolink string, the
TypoLink ViewHelpers do also support the
new object.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1218

  1. Oli Bartsch uploaded patch set 1 08/13/24, 15:06

  2. core-ci voted on patch set 1 V -1 08/13/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327

  3. core-ci commented on patch set 1 08/13/24, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327

  4. core-ci commented on patch set 1 08/13/24, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327

  5. core-ci commented on patch set 1 08/13/24, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63327

  6. Christian Kuhn commented on patch set 1 CR -1 08/13/24, 16:07

    TypolinkParameter.php:29

    all these arguments could be public readonly and the standard getters could be dropped?

    TypolinkParameter.php:104

    this most likely should not happen in this value object: this is a depedency to a service that actually is a real service doing things like event dispatching and all that jazz. it feels as if this shouldn't be part of a value object, but could very well be externalized to services working with that value object?!
  7. Benni Mack commented on patch set 1 08/14/24, 09:08

    Can be combined with https://review.typo3.org/c/Packages/TYPO3.CMS/+/82678 which adds a new interface that could then receive the new object instead of the array.
  8. Oli Bartsch uploaded patch set 2 CR -1 V -1 08/14/24, 09:14

  9. Oli Bartsch commented on patch set 2 08/14/24, 09:15

    TypolinkParameter.php:29 Reply

    Done

    TypolinkParameter.php:104 Reply

    Done
  10. core-ci voted on patch set 2 V -1 08/14/24, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63360

  11. Oli Bartsch uploaded patch set 3 V -1 08/14/24, 09:33

  12. core-ci voted on patch set 3 V +1 08/14/24, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63363

  13. Jochen Roth voted on patch set 3 CR +1 V +1 08/14/24, 09:50

  14. Nikita Hovratov voted on patch set 3 CR +1 V +1 08/14/24, 09:55

  15. Oli Bartsch voted on patch set 3 CR +2 V +2 08/14/24, 09:56

  16. Oli Bartsch merged patch set 4 08/14/24, 09:56

  17. Christian Kuhn voted on patch set 4 CR +1 V +1 08/14/24, 11:45

  18. Christian Kuhn commented on patch set 4 08/14/24, 11:45

    TypolinkParameter.php:23 Unresolved

    could should have been set final - there is no point in extending this in any way.