Review main Merged

85620[TASK] Raise `doctrine/dbal:^4.1`

Stefan Bürk CR +2 V +2 Hard +229 −158 updated 08/15/24, 11:57

Commit message

The Doctrine Team recently released minor version
release `4.1.0` including a couple of bugfixes,
internal changes and also new features [1].

The aforementioned internal changes introduces
breaking stuff within internal implementation,
for example the TYPO3 Database Analyzer stack
enforcing adoption [2][3][4]. Sadly, it's not
possible to provide backwards compatible code
and thus minimum version raise is "absolutly"
required.

Doctrine DBAL 4.1.0 also includes new platform
implementation for some database platforms and
this change adds them as extend replacements
to ensure working state with TYPO3 DB Analyzer.

Note that previous TYPO3 v13.x composer instances
needs to limit doctrine/dbal to 4.0.x on their own
to avoid breaking behaviour.

Used command(s):

\
  composer require --no-update --no-install \
    -d typo3/sysext/redirects \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/core \
    "doctrine/dbal":"^4.1" \
  && composer require --no-update --no-install \
    -d typo3/sysext/install \
    "doctrine/dbal":"^4.1" \
  && composer require "doctrine/dbal":"^4.1"

[1] https://github.com/doctrine/dbal/releases/tag/4.1.0
[2] https://github.com/doctrine/dbal/pull/6280
[3] https://github.com/doctrine/dbal/pull/6482
[4] https://github.com/doctrine/dbal/pull/6490

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 2547

Show 1022 earlier messages
  1. Stefan Bürk uploaded patch set 1 08/13/24, 16:54

  2. core-ci voted on patch set 1 V -1 08/13/24, 16:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63330

  3. Stefan Bürk uploaded patch set 2 V -1 08/13/24, 17:03

  4. Stefan Bürk uploaded patch set 3 08/13/24, 17:07

  5. core-ci voted on patch set 2 V -1 08/13/24, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63331

  6. core-ci voted on patch set 3 V -1 08/13/24, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63332

  7. Stefan Bürk uploaded patch set 4 V -1 08/13/24, 17:23

  8. Stefan Bürk uploaded patch set 5 08/13/24, 17:25

  9. Stefan Bürk uploaded patch set 6 08/13/24, 17:29

  10. core-ci voted on patch set 5 V -1 08/13/24, 17:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63334

  11. core-ci voted on patch set 4 V -1 08/13/24, 17:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63333

  12. core-ci voted on patch set 6 V -1 08/13/24, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63335

  13. Stefan Bürk uploaded patch set 7 V -1 08/13/24, 23:05

  14. core-ci voted on patch set 7 V -1 08/13/24, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63340

  15. Stefan Bürk uploaded patch set 8 V -1 08/13/24, 23:15

  16. core-ci voted on patch set 8 V -1 08/13/24, 23:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63341

  17. Stefan Bürk uploaded patch set 9 V -1 08/13/24, 23:42

  18. core-ci voted on patch set 9 V +1 08/13/24, 23:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63342

  19. core-ci voted on patch set 9 V -1 08/14/24, 00:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63343

  20. core-ci voted on patch set 9 V +1 08/14/24, 00:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63343

  21. Stefan Bürk uploaded patch set 10 V +1 08/14/24, 00:28

  22. core-ci voted on patch set 10 V +1 08/14/24, 00:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63344

  1. Stefan Bürk uploaded patch set 11 V +1 08/14/24, 14:08

  2. core-ci voted on patch set 11 V -1 08/14/24, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63390

  3. Stefan Bürk uploaded patch set 12 V -1 08/14/24, 17:40

  4. core-ci voted on patch set 12 V +1 08/14/24, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63399

  5. Stefan Bürk uploaded patch set 13 V +1 08/14/24, 17:49

  6. core-ci voted on patch set 13 V +1 08/14/24, 17:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63401

  7. Stefan Bürk uploaded patch set 14 V +1 08/14/24, 19:51

  8. Stefan Bürk wrote 08/14/24, 19:52

    Topic set to doctrine/dbal
  9. core-ci voted on patch set 14 V +1 08/14/24, 19:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63413

  10. core-ci commented on patch set 14 08/14/24, 21:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63418

  11. Stefan Bürk uploaded patch set 15 V +1 08/15/24, 08:44

  12. Andreas Kienast commented on patch set 15 08/15/24, 08:48

    composer.dist.json:98

    I don't quite understand why we need this change here.
  13. core-ci voted on patch set 15 V +1 08/15/24, 08:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63451

  14. Stefan Bürk uploaded patch set 16 V +1 08/15/24, 08:58

  15. Stefan Bürk commented on patch set 16 08/15/24, 09:00

    composer.dist.json:98 Reply

    Correct. Using "forks" this is needed, but not for the "release raise". Thanks for stating it. Removed it.
  16. Stefan Bürk updated the commit message in patch set 17 08/15/24, 09:03

  17. core-ci voted on patch set 16 V -1 08/15/24, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63454

  18. core-ci voted on patch set 17 V -1 08/15/24, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63456

  19. core-ci voted on patch set 17 V +1 08/15/24, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63456

  20. Stefan Bürk uploaded patch set 18 V +1 08/15/24, 11:48

  21. Christian Kuhn voted on patch set 18 CR +1 V +1 08/15/24, 11:50

  22. core-ci voted on patch set 18 V +1 08/15/24, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63472

  23. Andreas Kienast voted on patch set 18 CR +1 V +1 08/15/24, 11:56

  24. Stefan Bürk voted on patch set 18 CR +2 V +2 08/15/24, 11:57

  25. Stefan Bürk merged patch set 19 08/15/24, 11:57