Review main Merged

85623[TASK] Streamline BackendUserAuthentication::getWebmounts()

Thomas Hohn CR +2 V +2 Easy +3 −8 updated 08/14/24, 13:43

Commit message

The method BackendUserAuthentication::getWebmounts() now returns
an unique list of webmounts. Before the list could contain
duplicates and it was the callers responsibility to remove these.

Superfluous calls to array_unique() were removed since the uniquess
is now guaranteed by BackendUserAuthentication::getWebmounts().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 811

  1. Thomas Hohn uploaded patch set 1 08/14/24, 07:03

  2. core-ci voted on patch set 1 V +1 08/14/24, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63359

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 08/14/24, 07:30

  4. Andreas Kienast voted on patch set 1 CR +1 08/14/24, 09:32

  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 08/14/24, 09:54

  6. Oli Bartsch voted on patch set 2 CR +1 V +1 08/14/24, 09:55

  7. core-ci voted on patch set 2 V -1 08/14/24, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63366

  8. core-ci voted on patch set 2 V +1 08/14/24, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63366

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 08/14/24, 10:47

  10. Stefan Bürk voted on patch set 2 CR +2 V +2 08/14/24, 13:42

  11. Stefan Bürk merged patch set 3 08/14/24, 13:43