85624[TASK] Modernize position map styling (a bit)
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Ayke Halder +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Andreas Kienast +2
- Andreas Nedbal +1
- Ayke Halder +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/typo3/_element_page_position_map.scss4new+64 −0
- Build/Sources/Sass/backend.scss+1 −0
- typo3/sysext/backend/Classes/Tree/View/AbstractContentPagePositionMap.php+12 −12
- typo3/sysext/backend/Classes/Tree/View/ContentCreationPagePositionMap.php+12 −7
- typo3/sysext/backend/Classes/Tree/View/ContentMovingPagePositionMap.php2+14 −9
- typo3/sysext/backend/Resources/Private/Templates/ContentElement/MoveElement.html4+20 −17
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/PositionMap.html+3 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+8 −0
Review log 2937
Show 912 earlier messages
-
Andreas Kienast uploaded patch set 1 08/14/24, 09:25
-
core-ci voted on patch set 1 V -1 08/14/24, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63361
-
Andreas Kienast commented on patch set 1 CR -2 08/14/24, 09:31
Waiting for https://review.typo3.org/c/Packages/TYPO3.CMS/+/85625 as a pre-patch. -
Andreas Kienast uploaded patch set 2
V -108/14/24, 10:21Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Andreas Kienast voted on patch set 2 CR 0 08/14/24, 10:21
-
Andreas Kienast commented on patch set 2 CR -1 08/14/24, 10:24
Some colors seem off, investigating -
core-ci voted on patch set 2 V +1 08/14/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63368
-
Andreas Kienast uploaded patch set 3
CR -1V +108/14/24, 10:40 -
core-ci voted on patch set 3 V +1 08/14/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63369
-
Andreas Kienast commented on patch set 3 CR -1 08/15/24, 07:29
Something broke terribly -
Andreas Kienast uploaded patch set 4
CR -1V +108/15/24, 07:36 -
Garvin Hicking voted on patch set 4 V +1 08/15/24, 07:41
-
core-ci voted on patch set 4 V +1 08/15/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63444
-
Garvin Hicking commented on patch set 4 08/15/24, 07:41
Reply
Done -
Andreas Kienast uploaded patch set 5
V +108/15/24, 07:41 -
core-ci voted on patch set 5 V +1 08/15/24, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63445
-
Garvin Hicking voted on patch set 5 V +1 08/15/24, 07:50
-
Ayke Halder commented on patch set 5 08/20/24, 14:43
Position map isn't triggered by "New Page Wizard" anymore.The new page wizard in record list does not list CEs which needs positioning anymore. -
Ayke Halder commented on patch set 5 08/20/24, 14:46
Reply
"New Page Content" triggers the position map. "Create new record" does not. All fine.Reply
Done -
Ayke Halder commented on patch set 5 08/20/24, 15:37
_element_page_position_map.scss:5Can we somehow re-use `--pagemodule-grid-*` instead of re-declaring all the identical styles again as `--page-position-grid-*`?_element_page_position_map.scss:21Maybe it is better to not set the background here and let the background of the 'modal' shine through. To really get the same styling like in the page module, the general background of modals might be changed: * current: `--bs-modal-bg: var(--bs-body-bg);` * same style like e.g. page module: `--bs-modal-bg: var(--module-bg);`MoveElement.html:30Remove this unnecessary `<br>`. No visual change with/without it.MoveElement.html:32Remove this unnecessary `<br>`. When removed the bottom-margin around "page-position-map" becomes as visually intended. -
Ayke Halder commented on patch set 5 08/20/24, 16:17
https://review.typo3.org/c/Packages/TYPO3.CMS/+/77524 states: > Creating content elements from within the list module typically leads to wrong colPos selections, **editors should manage content from within the Page module only**. So in module "Web -> List" the options "New Page Content" and "Re-position content element" should be completely removed, shouldn't they? -
Andreas Kienast commented on patch set 5 08/20/24, 16:25
Reply
Maybe, but please not after a .0 release. -
Andreas Kienast commented on patch set 5 08/21/24, 05:54
_element_page_position_map.scss:5ReplyIt makes sense to do so once the API for rendering this grid is streamlined for multiple purposes, as stated in the commit message. For now, I'd keep is separated as the page module does something different._element_page_position_map.scss:21ReplyNot sure. I'd like to have the same contrasts as in the page module. This might change again with Benji's dark mode implementation anyway.MoveElement.html:30ReplyAcknowledgedMoveElement.html:32ReplyAcknowledged -
Andreas Kienast uploaded patch set 6
V +108/21/24, 05:54 -
core-ci voted on patch set 6 V +1 08/21/24, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63878
-
Garvin Hicking voted on patch set 6 V +1 08/21/24, 06:31
-
Ayke Halder commented on patch set 6 08/21/24, 19:19
ContentMovingPagePositionMap.php:81A11y: Add attribute `role="button"` to `<a class="btn…" …>`. -
Andreas Kienast uploaded patch set 7
V +108/22/24, 05:59 -
Andreas Kienast commented on patch set 7 08/22/24, 05:59
ContentMovingPagePositionMap.php:81ReplyDone -
core-ci voted on patch set 7 V +1 08/22/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63955
-
Ayke Halder updated the commit message in patch set 8
V +108/22/24, 07:42 -
core-ci voted on patch set 8 V +1 08/22/24, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63960
-
Ayke Halder voted on patch set 8 CR +1 V +1 08/22/24, 08:02
-
Simon Schaufelberger voted on patch set 8 CR +1 V +1 08/23/24, 12:23
-
Andreas Nedbal voted on patch set 8 CR +1 V +1 08/23/24, 13:33
-
Andreas Kienast voted on patch set 8 CR +2 V +2 08/23/24, 13:45
-
Andreas Kienast merged patch set 9 08/23/24, 13:45