Review main Merged

85624[TASK] Modernize position map styling (a bit)

Andreas Kienast CR +2 V +2 Normal +134 −47 updated 08/23/24, 13:45

Commit message

TYPO3 still uses the infamous position maps (lists with arrow icons) to
allow an user to re-arrange content elements. The position maps are used
in two places:

* "New Page Content" wizard in record list
* "Re-position content element" in record list

This commit aims to improve the styling of position maps and streamline
them with the page module, without the need of major refactorings.

Theoretically, TYPO3 has API to render a "page module"-alike grid
anywhere, but it is currently coupled too tight to page module behavior
and its needs.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Ayke Halder +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Ayke Halder +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2937

Show 912 earlier messages
  1. Andreas Kienast uploaded patch set 1 08/14/24, 09:25

  2. core-ci voted on patch set 1 V -1 08/14/24, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63361

  3. Andreas Kienast commented on patch set 1 CR -2 08/14/24, 09:31

  4. Andreas Kienast uploaded patch set 2 V -1 08/14/24, 10:21

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  5. Andreas Kienast voted on patch set 2 CR 0 08/14/24, 10:21

  6. Andreas Kienast commented on patch set 2 CR -1 08/14/24, 10:24

    Some colors seem off, investigating
  7. core-ci voted on patch set 2 V +1 08/14/24, 10:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63368

  8. Andreas Kienast uploaded patch set 3 CR -1 V +1 08/14/24, 10:40

  9. core-ci voted on patch set 3 V +1 08/14/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63369

  10. Andreas Kienast commented on patch set 3 CR -1 08/15/24, 07:29

    Something broke terribly
  11. Andreas Kienast uploaded patch set 4 CR -1 V +1 08/15/24, 07:36

  12. Garvin Hicking voted on patch set 4 V +1 08/15/24, 07:41

  1. core-ci voted on patch set 4 V +1 08/15/24, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63444

  2. Garvin Hicking commented on patch set 4 08/15/24, 07:41

    Reply

    Done
  3. Andreas Kienast uploaded patch set 5 V +1 08/15/24, 07:41

  4. core-ci voted on patch set 5 V +1 08/15/24, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63445

  5. Garvin Hicking voted on patch set 5 V +1 08/15/24, 07:50

  6. Ayke Halder commented on patch set 5 08/20/24, 14:43

    Position map isn't triggered by "New Page Wizard" anymore.
    The new page wizard in record list does not list CEs which needs positioning anymore.
  7. Ayke Halder commented on patch set 5 08/20/24, 14:46

    Reply

    "New Page Content" triggers the position map. "Create new record" does not. All fine.

    Reply

    Done
  8. Ayke Halder commented on patch set 5 08/20/24, 15:37

    _element_page_position_map.scss:5

    Can we somehow re-use `--pagemodule-grid-*` instead of re-declaring all the identical styles again as `--page-position-grid-*`?

    _element_page_position_map.scss:21

    Maybe it is better to not set the background here and let the background of the 'modal' shine through. To really get the same styling like in the page module, the general background of modals might be changed: * current: `--bs-modal-bg: var(--bs-body-bg);` * same style like e.g. page module: `--bs-modal-bg: var(--module-bg);`

    MoveElement.html:30

    Remove this unnecessary `<br>`. No visual change with/without it.

    MoveElement.html:32

    Remove this unnecessary `<br>`. When removed the bottom-margin around "page-position-map" becomes as visually intended.
  9. Ayke Halder commented on patch set 5 08/20/24, 16:17

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/77524 states: > Creating content elements from within the list module typically leads to wrong colPos selections, **editors should manage content from within the Page module only**. So in module "Web -> List" the options "New Page Content" and "Re-position content element" should be completely removed, shouldn't they?
  10. Andreas Kienast commented on patch set 5 08/20/24, 16:25

    Reply

    Maybe, but please not after a .0 release.
  11. Andreas Kienast commented on patch set 5 08/21/24, 05:54

    _element_page_position_map.scss:5 Reply

    It makes sense to do so once the API for rendering this grid is streamlined for multiple purposes, as stated in the commit message. For now, I'd keep is separated as the page module does something different.

    _element_page_position_map.scss:21 Reply

    Not sure. I'd like to have the same contrasts as in the page module. This might change again with Benji's dark mode implementation anyway.

    MoveElement.html:30 Reply

    Acknowledged

    MoveElement.html:32 Reply

    Acknowledged
  12. Andreas Kienast uploaded patch set 6 V +1 08/21/24, 05:54

  13. core-ci voted on patch set 6 V +1 08/21/24, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63878

  14. Garvin Hicking voted on patch set 6 V +1 08/21/24, 06:31

  15. Ayke Halder commented on patch set 6 08/21/24, 19:19

    ContentMovingPagePositionMap.php:81

    A11y: Add attribute `role="button"` to `<a class="btn…" …>`.
  16. Andreas Kienast uploaded patch set 7 V +1 08/22/24, 05:59

  17. Andreas Kienast commented on patch set 7 08/22/24, 05:59

    ContentMovingPagePositionMap.php:81 Reply

    Done
  18. core-ci voted on patch set 7 V +1 08/22/24, 06:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63955

  19. Ayke Halder updated the commit message in patch set 8 V +1 08/22/24, 07:42

  20. core-ci voted on patch set 8 V +1 08/22/24, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63960

  21. Ayke Halder voted on patch set 8 CR +1 V +1 08/22/24, 08:02

  22. Simon Schaufelberger voted on patch set 8 CR +1 V +1 08/23/24, 12:23

  23. Andreas Nedbal voted on patch set 8 CR +1 V +1 08/23/24, 13:33

  24. Andreas Kienast voted on patch set 8 CR +2 V +2 08/23/24, 13:45

  25. Andreas Kienast merged patch set 9 08/23/24, 13:45