Review 12.4 Merged

85628[BUGFIX] Fix type cast error in DB Compare for 'default' definition

Garvin Hicking CR +2 V +2 Easy +1 −1 updated 08/14/24, 13:24

Commit message

The change in #97498 introduced a specific handling for ENUM/SET
definitions in MariaDB systems. The check may be performed with a
NULL value instead of a string, which can result in a PHP type
mismatch error.

Due to other refactoring, the issue does not exist in main (v13),
but only affects v12 and v11.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 79

  1. Garvin Hicking uploaded patch set 1 08/14/24, 12:57

  2. Andreas Kienast voted on patch set 1 CR +1 08/14/24, 13:00

  3. Stefan Bürk updated the commit message in patch set 2 CR +1 08/14/24, 13:03

  4. Stefan Bürk voted on patch set 2 CR +1 V +1 08/14/24, 13:04

  5. core-ci voted on patch set 1 V +1 08/14/24, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63376

  6. core-ci voted on patch set 2 V +1 08/14/24, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63381

  7. Andreas Kienast voted on patch set 2 CR +1 V +1 08/14/24, 13:22

  8. Stefan Bürk voted on patch set 2 CR +2 V +2 08/14/24, 13:24

  9. Stefan Bürk merged patch set 3 08/14/24, 13:24