Review 12.4 Merged

85630[TASK] Add accessibility ci tests with playwright/axe

Benjamin Franzke CR +2 V +2 Hard +301 −16 updated 08/16/24, 07:38

Commit message

playwright/axe iterates over a list of web pages and highlights
accessibility issues. This tool is now applied as a CI job to
the TYPO3 Backend where the main backend layout and modules are
being tested.

Usage:

  # CI mode
  Build/Scripts/runTests.sh -s accessibility

  # Run against local instance
  ACCESSIBILITY_BASE_URL=https://t3main.devbox.local/typo3 \
  npm --prefix=Build run accessibility

  # Prepare CI mode, run locally (repeatable command will be printed)
  Build/Scripts/runTests.sh -s accessibility-prepare

Commands executed:
  npm --prefix=Build install --save-dev \
    @axe-core/playwright@4.9.1 \
    @playwright/test@1.45.3

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1119

  1. Benjamin Franzke uploaded patch set 1 08/14/24, 13:24

  2. core-ci voted on patch set 1 V -1 08/14/24, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63383

  3. Benjamin Franzke uploaded patch set 2 V -1 08/14/24, 13:35

  4. core-ci voted on patch set 2 V -1 08/14/24, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63384

  5. Benjamin Franzke uploaded patch set 3 V -1 08/15/24, 08:26

  6. core-ci voted on patch set 3 V -1 08/15/24, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63450

  7. Frank Nägler uploaded patch set 4 V -1 08/15/24, 09:55

  8. Frank Nägler uploaded patch set 5 08/15/24, 10:00

  9. core-ci voted on patch set 4 V +1 08/15/24, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63463

  10. core-ci voted on patch set 5 V +1 08/15/24, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63465

  11. Frank Nägler uploaded patch set 6 V +1 08/15/24, 14:24

  12. core-ci voted on patch set 6 V +1 08/15/24, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63499

  13. Benjamin Franzke uploaded patch set 7 V +1 08/15/24, 16:00

  14. Benjamin Franzke uploaded patch set 8 08/15/24, 16:02

  15. core-ci voted on patch set 8 V +1 08/15/24, 16:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63517

  16. core-ci commented on patch set 8 08/15/24, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63518

  17. Benjamin Franzke voted on patch set 8 CR +1 V +1 08/15/24, 17:35

  18. Andreas Kienast voted on patch set 8 CR +2 V +2 08/16/24, 07:37

  19. Andreas Kienast merged patch set 9 08/16/24, 07:38