85633[TASK] Make ext:core YamlFileLoader a stateless service
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Andreas Nedbal +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 13
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/core/Classes/Configuration/Loader/YamlFileLoader.php+18 −30
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+3 −3
- typo3/sysext/core/Classes/Configuration/SiteWriter.php+4 −4
- typo3/sysext/core/Classes/ServiceProvider.php+5 −1
- typo3/sysext/core/Tests/Functional/Configuration/Loader/YamlFileLoaderTest.php+19 −42
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+3 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+16 −3
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Configuration/SiteWriterTest.php+6 −4
- typo3/sysext/form/Classes/Mvc/Configuration/YamlSource.php+12 −41
- typo3/sysext/form/Tests/Unit/Mvc/Configuration/YamlSourceTest.php+29 −19
Review log 915
-
Christian Kuhn uploaded patch set 1 08/14/24, 17:18
-
core-ci voted on patch set 1 V -1 08/14/24, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63398
-
Christian Kuhn uploaded patch set 2
V -108/14/24, 18:28 -
core-ci voted on patch set 2 V -1 08/14/24, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63406
-
core-ci commented on patch set 2 08/14/24, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63406
-
Christian Kuhn uploaded patch set 3
V -108/14/24, 18:47 -
core-ci voted on patch set 3 V -1 08/14/24, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63407
-
Christian Kuhn rebased onto patch set 4
V -108/14/24, 19:25 -
core-ci voted on patch set 4 V +1 08/14/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63409
-
Christian Kuhn updated the commit message in patch set 5
V +108/14/24, 19:34 -
core-ci voted on patch set 5 V +1 08/14/24, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63411
-
Stefan Bürk voted on patch set 5 CR +1 V +1 08/14/24, 19:44
-
Andreas Nedbal voted on patch set 5 CR +1 V +1 08/14/24, 20:23
-
Christian Kuhn voted on patch set 5 CR +2 V +2 08/14/24, 20:32
-
Christian Kuhn merged patch set 6 08/14/24, 20:32