Review main Merged

85633[TASK] Make ext:core YamlFileLoader a stateless service

Christian Kuhn CR +2 V +2 Hard +122 −156 updated 08/14/24, 20:32

Commit message

* Slightly refactor YamlFileLoader to make it obvious
  it is a stateless service. Declare it readonly.
* Inject YamlFileLoader in a couple of places and
  adapt tests to deal with this.
* Refactor ext:form YamlSource to a readonly stateless
  serice as well, add some type hints and clean up
  some details. Adapt tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 915

  1. Christian Kuhn uploaded patch set 1 08/14/24, 17:18

  2. core-ci voted on patch set 1 V -1 08/14/24, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63398

  3. Christian Kuhn uploaded patch set 2 V -1 08/14/24, 18:28

  4. core-ci voted on patch set 2 V -1 08/14/24, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63406

  5. core-ci commented on patch set 2 08/14/24, 18:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63406

  6. Christian Kuhn uploaded patch set 3 V -1 08/14/24, 18:47

  7. core-ci voted on patch set 3 V -1 08/14/24, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63407

  8. Christian Kuhn rebased onto patch set 4 V -1 08/14/24, 19:25

  9. core-ci voted on patch set 4 V +1 08/14/24, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63409

  10. Christian Kuhn updated the commit message in patch set 5 V +1 08/14/24, 19:34

  11. core-ci voted on patch set 5 V +1 08/14/24, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63411

  12. Stefan Bürk voted on patch set 5 CR +1 V +1 08/14/24, 19:44

  13. Andreas Nedbal voted on patch set 5 CR +1 V +1 08/14/24, 20:23

  14. Christian Kuhn voted on patch set 5 CR +2 V +2 08/14/24, 20:32

  15. Christian Kuhn merged patch set 6 08/14/24, 20:32