Review main Merged

85637[TASK] Inject interface, not implementation in ext:form

Christian Kuhn CR +2 V +2 Easy +4 −7 updated 08/14/24, 20:33

Commit message

Inject ext:form ConfigurationManagerInterface, not
the implementation ConfigurationManager in the ext:form
"Show Configuration" ProviderInterface feature for
ext:lowlevel.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Nedbal +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 08/14/24, 20:12

  2. core-ci voted on patch set 1 V +1 08/14/24, 20:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63416

  3. Andreas Nedbal voted on patch set 1 CR +1 V +1 08/14/24, 20:24

  4. Stefan Bürk voted on patch set 1 CR +1 V +1 08/14/24, 20:32

  5. Christian Kuhn voted on patch set 1 CR +2 V +2 08/14/24, 20:33

  6. Christian Kuhn merged patch set 2 08/14/24, 20:33