85638[TASK] Decouple ext:form ConfigurationManager from extbase
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Praetorius +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Praetorius +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 18
- typo3/sysext/form/Classes/ConfigurationModuleProvider/FormYamlProvider.php2+10 −6
- typo3/sysext/form/Classes/Controller/FormEditorController.php+3 −4
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −1
- typo3/sysext/form/Classes/Controller/FormManagerController.php+3 −4
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+15 −6
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+8 −3
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+2 −1
- typo3/sysext/form/Classes/Mvc/Configuration/Exception/ExtensionNameRequiredException.phpdeleted+0 −28
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManager.php+26 −128
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManagerInterface.php+2 −4
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/form/Configuration/Services.yaml+0 −4
- typo3/sysext/form/Tests/Functional/Domain/Configuration/ConfigurationServiceTest.php+13 −8
- typo3/sysext/form/Tests/Functional/Domain/Model/Renderable/AbstractRenderableTest.php+7 −4
- typo3/sysext/form/Tests/Functional/Domain/Runtime/FormRuntimeTest.php+4 −3
- typo3/sysext/form/Tests/Functional/Mvc/Configuration/ConfigurationManagerTest.php+11 −22
- typo3/sysext/form/Tests/Functional/ViewHelpers/RenderFormValueViewHelperTest.php+3 −3
Review log 1625
-
Christian Kuhn uploaded patch set 1 08/14/24, 21:05
-
core-ci voted on patch set 1 V -1 08/14/24, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63419
-
Christian Kuhn rebased onto patch set 2
V -108/15/24, 13:08 -
core-ci voted on patch set 2 V -1 08/15/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63489
-
Christian Kuhn uploaded patch set 3
V -108/15/24, 13:48 -
core-ci voted on patch set 3 V +1 08/15/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63495
-
Christian Kuhn uploaded patch set 4
V +108/20/24, 10:31 -
core-ci voted on patch set 4 V +1 08/20/24, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63824
-
Christian Kuhn uploaded patch set 5
V +108/20/24, 10:55 -
core-ci voted on patch set 5 V +1 08/20/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63826
-
Christian Kuhn uploaded patch set 6
V +108/20/24, 11:53 -
Christian Kuhn uploaded patch set 7 08/20/24, 11:56
-
core-ci voted on patch set 6 V +1 08/20/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63828
-
core-ci voted on patch set 7 V -1 08/20/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63829
-
Christian Kuhn uploaded patch set 8
V -108/20/24, 12:04 -
core-ci voted on patch set 8 V +1 08/20/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63830
-
Christian Kuhn uploaded patch set 9
V +108/20/24, 12:39 -
core-ci voted on patch set 9 V +1 08/20/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63831
-
Stefan Bürk voted on patch set 9 CR +1 08/20/24, 15:31
-
Stefan Bürk voted on patch set 9 V +1 08/20/24, 15:56
-
Simon Praetorius voted on patch set 9 CR +1 V +1 08/20/24, 16:35
-
Christian Kuhn voted on patch set 9 CR +2 V +2 08/20/24, 16:40
-
Christian Kuhn merged patch set 10 08/20/24, 16:40
-
Mathias Brodala commented on patch set 10 08/21/24, 12:09
-
Christian Kuhn commented on patch set 10 08/22/24, 23:07
FormYamlProvider.php:31ReplyI'm using that alias at a lot of places right now to distinct ext:form ConfigurationManager from ext:extbase ConfigurationManager. If that alias is not happy with you, feel free to push a patch to change it. (no pun, just do it if you like a different naming better! just have it consistent.)
FormYamlProvider.php:31