Review main Merged

85638[TASK] Decouple ext:form ConfigurationManager from extbase

Christian Kuhn CR +2 V +2 Hard +110 −231 updated 08/22/24, 23:07

Commit message

Next change in the "Tame extbase ConfigurationManager" series.

ext:form comes with an add-on class of extbase
ConfigurationManager: It extends the class with an own feature
to load the relevant YAML configuration from the extensions
TypoScript. This is accompanied by an own interface.

This is not a great idea from a structural point of view:
The ext:form ConfigurationManager should be decoupled from
extbase ConfigurationManager. It may decorate it, but should
not extend it. Or - even better - not have a dependency to
extbase ConfigurationManager at all, but get the required
extbase ConfigurationManager state hand over. The latter
option is preferred since extbase ConfigurationManager
is this evil injectable stateful singleton, that hides
required state away. Turning this around in ext:form forces
consumers to hand over state directly, making the
dependency to extbase ConfigurationManager state explicit
in callers of ext:form ConfigurationManager.

The patch does this: ext:form ConfigurationManager no longer
extends extbase ConfigurationManager, but is turned into a
standalone and stateless service with an own signature that
actively receives needed state from consumers.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Praetorius +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 18

Review log 1625

  1. Christian Kuhn uploaded patch set 1 08/14/24, 21:05

  2. core-ci voted on patch set 1 V -1 08/14/24, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63419

  3. Christian Kuhn rebased onto patch set 2 V -1 08/15/24, 13:08

  4. core-ci voted on patch set 2 V -1 08/15/24, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63489

  5. Christian Kuhn uploaded patch set 3 V -1 08/15/24, 13:48

  6. core-ci voted on patch set 3 V +1 08/15/24, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63495

  7. Christian Kuhn uploaded patch set 4 V +1 08/20/24, 10:31

  8. core-ci voted on patch set 4 V +1 08/20/24, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63824

  9. Christian Kuhn uploaded patch set 5 V +1 08/20/24, 10:55

  10. core-ci voted on patch set 5 V +1 08/20/24, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63826

  11. Christian Kuhn uploaded patch set 6 V +1 08/20/24, 11:53

  12. Christian Kuhn uploaded patch set 7 08/20/24, 11:56

  13. core-ci voted on patch set 6 V +1 08/20/24, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63828

  14. core-ci voted on patch set 7 V -1 08/20/24, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63829

  15. Christian Kuhn uploaded patch set 8 V -1 08/20/24, 12:04

  16. core-ci voted on patch set 8 V +1 08/20/24, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63830

  17. Christian Kuhn uploaded patch set 9 V +1 08/20/24, 12:39

  18. core-ci voted on patch set 9 V +1 08/20/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63831

  19. Stefan Bürk voted on patch set 9 CR +1 08/20/24, 15:31

  20. Stefan Bürk voted on patch set 9 V +1 08/20/24, 15:56

  21. Simon Praetorius voted on patch set 9 CR +1 V +1 08/20/24, 16:35

  22. Christian Kuhn voted on patch set 9 CR +2 V +2 08/20/24, 16:40

  23. Christian Kuhn merged patch set 10 08/20/24, 16:40

  24. Mathias Brodala commented on patch set 10 08/21/24, 12:09

    FormYamlProvider.php:31

    Late to the party as usual but this should have been "formConfigurationManager". We use the "ext" prefix nowhere for injected services and right now it's rather confusing to read. ;-)
  25. Christian Kuhn commented on patch set 10 08/22/24, 23:07

    FormYamlProvider.php:31 Reply

    I'm using that alias at a lot of places right now to distinct ext:form ConfigurationManager from ext:extbase ConfigurationManager. If that alias is not happy with you, feel free to push a patch to change it. (no pun, just do it if you like a different naming better! just have it consistent.)