Review main Merged

85639[BUGFIX] Allow HTML tags "mark" and "s" in RTE frontend output

Garvin Hicking CR +2 V +2 Easy +36 −4 updated 08/23/24, 06:20

Commit message

With #101128 a few more RTE plugins for CKEditor have been added,
now supporting the "mark" HTML tag.

This tag is now also allowed in the default parseFunc_RTE definitions
for EXT:fluid_styled_content and the RteHtmlParser default. Also the
missing "s" tag was treated similarly.

Please note that custom sitepackages or themes like the Bootstrap
package may need adoption like the following, if `denyTags` might
otherwise remove the definition:

    lib.parseFunc_RTE {
      allowTags := addToList(mark,s)
    }

The HTML frontend styling of the `<mark>` classes needs to be
done by integrators, no CSS definitions are provided by default.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1728

Show 23 earlier messages
  1. Garvin Hicking uploaded patch set 1 08/14/24, 22:32

  2. core-ci voted on patch set 1 V +1 08/14/24, 22:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63422

  3. Garvin Hicking uploaded patch set 2 V +1 08/14/24, 23:45

    mark not marker
  1. core-ci voted on patch set 2 V -1 08/14/24, 23:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63428

  2. core-ci commented on patch set 2 08/14/24, 23:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63428

  3. core-ci commented on patch set 2 08/15/24, 00:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63428

  4. core-ci commented on patch set 2 08/15/24, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63428

  5. core-ci voted on patch set 2 V +1 08/15/24, 06:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63428

  6. Oliver Hader commented on patch set 2 08/15/24, 12:41

    Shouldn't that be `lib.parseFunc_RTE` instead?
  7. Andreas Kienast updated the commit message in patch set 3 V +1 08/15/24, 12:45

  8. Oliver Hader commented on patch set 3 CR +1 V +1 08/15/24, 12:50

    Reply

    Done
  9. Andreas Kienast commented on patch set 3 08/15/24, 12:50

    I think this is an important (_hint hint_) information.
  10. core-ci voted on patch set 3 V -1 08/15/24, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63482

  11. Andreas Kienast uploaded patch set 4 CR +1 V +1 08/15/24, 12:55

  12. Andreas Kienast updated the commit message in patch set 5 08/15/24, 12:56

  13. Andreas Kienast commented on patch set 5 08/15/24, 12:57

    Reply

    Done
  14. core-ci voted on patch set 5 V +1 08/15/24, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63486

  15. Oliver Hader voted on patch set 5 CR +1 V +1 08/15/24, 13:50

  16. Garvin Hicking uploaded patch set 6 CR +1 V +1 08/15/24, 14:42

    Adjust RST
  17. Garvin Hicking commented on patch set 6 08/15/24, 14:43

    Thanks to both of you, indeed I was mislead by bk2k/bootstrap-package of defining everything thing in lib.parseFunc and afterwars assigning this to lib.parseFunc_RTE. I adjusted the RST a bit for this, and now that we have this RST in place, I added the CSS styling notice, too.
  18. core-ci voted on patch set 6 V +1 08/15/24, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63503

  19. Stefan Bürk commented on patch set 7 V +1 08/16/24, 07:43

    Published edit on patch set 6.
  20. Stefan Bürk voted on patch set 7 CR +1 V +1 08/16/24, 07:45

  21. core-ci voted on patch set 7 V -1 08/16/24, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63552

  22. core-ci voted on patch set 7 V +1 08/16/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/63552

  23. Simon Schaufelberger voted on patch set 7 CR +1 V +1 08/22/24, 22:59

  24. Andreas Kienast voted on patch set 7 CR +2 V +2 08/23/24, 05:53

  25. Andreas Kienast merged patch set 8 08/23/24, 06:20